* [PATCH] spi_mpc8xxx: fix writing to adress 0
@ 2010-09-16 7:04 christophe leroy
2010-09-16 7:39 ` Joakim Tjernlund
0 siblings, 1 reply; 3+ messages in thread
From: christophe leroy @ 2010-09-16 7:04 UTC (permalink / raw)
To: David Brownell, Grant Likely, spi-devel-general, linux-kernel,
linuxppc-dev
This patch applies to 2.6.34.7 (already included in 2.6.35.4)
It fixes an issue when sending only or receiving only (mspi->tx-dma was reset as when no tx_buf is defined, tx_dma is 0)
Signed-off-by: christophe leroy <christophe.leroy@c-s.fr>
diff -urN a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c
--- a/drivers/spi/spi_mpc8xxx.c 2010-09-08 16:42:30.000000000 +0200
+++ b/drivers/spi/spi_mpc8xxx.c 2010-09-08 16:43:50.000000000 +0200
@@ -438,7 +438,7 @@
dev_err(dev, "unable to map tx dma\n");
return -ENOMEM;
}
- } else {
+ } else if (t->tx_buf) {
mspi->tx_dma = t->tx_dma;
}
@@ -449,7 +449,7 @@
dev_err(dev, "unable to map rx dma\n");
goto err_rx_dma;
}
- } else {
+ } else if (t->rx_buf) {
mspi->rx_dma = t->rx_dma;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi_mpc8xxx: fix writing to adress 0
2010-09-16 7:04 [PATCH] spi_mpc8xxx: fix writing to adress 0 christophe leroy
@ 2010-09-16 7:39 ` Joakim Tjernlund
2010-09-16 20:11 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Joakim Tjernlund @ 2010-09-16 7:39 UTC (permalink / raw)
To: christophe leroy
Cc: David Brownell, Grant Likely, linux-kernel, linuxppc-dev,
spi-devel-general
> From: christophe leroy <christophe.leroy@c-s.fr>
> To: David Brownell <dbrownell@users.sourceforge.net>, Grant Likely
> <grant.likely@secretlab.ca>, spi-devel-general@lists.sourceforge.net, linux-
> kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
> Date: 2010/09/16 09:06
> Subject: [PATCH] spi_mpc8xxx: fix writing to adress 0
> Sent by: linuxppc-dev-bounces+joakim.tjernlund=transmode.se@lists.ozlabs.org
>
> This patch applies to 2.6.34.7 (already included in 2.6.35.4)
> It fixes an issue when sending only or receiving only (mspi->tx-dma was reset
> as when no tx_buf is defined, tx_dma is 0)
>
> Signed-off-by: christophe leroy <christophe.leroy@c-s.fr>
Acked-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi_mpc8xxx: fix writing to adress 0
2010-09-16 7:39 ` Joakim Tjernlund
@ 2010-09-16 20:11 ` Grant Likely
0 siblings, 0 replies; 3+ messages in thread
From: Grant Likely @ 2010-09-16 20:11 UTC (permalink / raw)
To: Joakim Tjernlund
Cc: christophe leroy, David Brownell, linux-kernel, linuxppc-dev,
spi-devel-general
On Thu, Sep 16, 2010 at 09:39:09AM +0200, Joakim Tjernlund wrote:
> > From: christophe leroy <christophe.leroy@c-s.fr>
> > To: David Brownell <dbrownell@users.sourceforge.net>, Grant Likely
> > <grant.likely@secretlab.ca>, spi-devel-general@lists.sourceforge.net, linux-
> > kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
> > Date: 2010/09/16 09:06
> > Subject: [PATCH] spi_mpc8xxx: fix writing to adress 0
> > Sent by: linuxppc-dev-bounces+joakim.tjernlund=transmode.se@lists.ozlabs.org
> >
> > This patch applies to 2.6.34.7 (already included in 2.6.35.4)
> > It fixes an issue when sending only or receiving only (mspi->tx-dma was reset
> > as when no tx_buf is defined, tx_dma is 0)
> >
> > Signed-off-by: christophe leroy <christophe.leroy@c-s.fr>
>
> Acked-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
>
You need to send this to the linux-stable list and include the sha1
commit id that fixes it in mainline.
Acked-by: Grant Likely <grant.likely@secretlab.ca>
g.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-16 20:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-16 7:04 [PATCH] spi_mpc8xxx: fix writing to adress 0 christophe leroy
2010-09-16 7:39 ` Joakim Tjernlund
2010-09-16 20:11 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).