[PATCH REPOST v2] spi/spi: don't release the spi device twice

[PATCH REPOST v2] spi/spi: don't release the spi device twice

[Sebastian Andrzej Siewior]

This was fixed by David Lamparter in v2.6.36-rc5 3486008
("spi: free children in spi_unregister_master, not siblings") and broken
again in v2.6.37-rc1~2^2~4 during the merge of 2b9603a0 ("spi: enable
spi_board_info to be registered after spi_master").

Signed-off-by: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Signed-off-by: David Lamparter <equinox-cEeocvCgqOOsTnJN9+BGXg@public.gmane.org>
---

Andrew, I resent this to you because it fixes a regression which was
introduced in the merge window for v2.6.37.
I posted this patch at 2010-11-23 14:59:10 and sent a ping 2010-12-09
16:06:22 and got no response so far from the maintainer. The patch is at
https://patchwork.kernel.org/patch/349721/

 drivers/spi/spi.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 709c836..b02d0cb 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -584,8 +584,7 @@ void spi_unregister_master(struct spi_master *master)
 	list_del(&master->list);
 	mutex_unlock(&board_lock);
 
-	dummy = device_for_each_child(master->dev.parent, &master->dev,
-					__unregister);
+	dummy = device_for_each_child(&master->dev, NULL, __unregister);
 	device_unregister(&master->dev);
 }
 EXPORT_SYMBOL_GPL(spi_unregister_master);

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d

Re: [PATCH REPOST v2] spi/spi: don't release the spi device twice

[Grant Likely]

On Mon, Dec 20, 2010 at 10:13 AM, Sebastian Andrzej Siewior
<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> wrote:
> This was fixed by David Lamparter in v2.6.36-rc5 3486008
> ("spi: free children in spi_unregister_master, not siblings") and broken
> again in v2.6.37-rc1~2^2~4 during the merge of 2b9603a0 ("spi: enable
> spi_board_info to be registered after spi_master").
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
> Signed-off-by: David Lamparter <equinox-cEeocvCgqOOsTnJN9+BGXg@public.gmane.org>
> ---
>
> Andrew, I resent this to you because it fixes a regression which was
> introduced in the merge window for v2.6.37.
> I posted this patch at 2010-11-23 14:59:10 and sent a ping 2010-12-09
> 16:06:22 and got no response so far from the maintainer. The patch is at
> https://patchwork.kernel.org/patch/349721/

Sebastian, sorry I've been completely AWOL for the last month and a
half (or more).  I got completely overwhelmed this fall and it took
until just now to get myself dug out again.  I'm not doing any travel
for the next 4 months, and I've *finally* got an autotest instance set
up so I can properly pick up and test patches quickly, so things
should be better in the new year.

Andrew, Thanks for picking this one up and sending it on.  I've
rearranged the way I work on my end, so this situation shouldn't
happen again.

g.

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl