* [PATCH] spi/pl022: use cpu_relax in the busy loop
@ 2011-05-19 18:01 Linus Walleij
2011-05-19 18:03 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2011-05-19 18:01 UTC (permalink / raw)
To: Grant Likely, spi-devel-general
Cc: Linus Walleij, Lee Jones, Linus Walleij, linux-arm-kernel
This relaxes the cpu in the polling busy-wait loop.
Reported-by: Vitaly Wool <vitalywool@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/spi/amba-pl022.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
index 18667de..8a2b88a 100644
--- a/drivers/spi/amba-pl022.c
+++ b/drivers/spi/amba-pl022.c
@@ -1424,6 +1424,7 @@ static void do_polling_transfer(struct pl022 *pl022)
message->state = STATE_ERROR;
goto out;
}
+ cpu_relax();
}
/* Update total byte transferred */
--
1.7.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi/pl022: use cpu_relax in the busy loop
2011-05-19 18:01 [PATCH] spi/pl022: use cpu_relax in the busy loop Linus Walleij
@ 2011-05-19 18:03 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2011-05-19 18:03 UTC (permalink / raw)
To: Linus Walleij
Cc: spi-devel-general, Linus Walleij, Lee Jones, linux-arm-kernel
On Thu, May 19, 2011 at 08:01:25PM +0200, Linus Walleij wrote:
> This relaxes the cpu in the polling busy-wait loop.
>
> Reported-by: Vitaly Wool <vitalywool@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thanks.
g.
> ---
> drivers/spi/amba-pl022.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
> index 18667de..8a2b88a 100644
> --- a/drivers/spi/amba-pl022.c
> +++ b/drivers/spi/amba-pl022.c
> @@ -1424,6 +1424,7 @@ static void do_polling_transfer(struct pl022 *pl022)
> message->state = STATE_ERROR;
> goto out;
> }
> + cpu_relax();
> }
>
> /* Update total byte transferred */
> --
> 1.7.3.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-19 18:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-19 18:01 [PATCH] spi/pl022: use cpu_relax in the busy loop Linus Walleij
2011-05-19 18:03 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).