* [REPOST PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support
@ 2012-09-18 12:01 Matt Porter
[not found] ` <1347969685-15571-1-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Matt Porter @ 2012-09-18 12:01 UTC (permalink / raw)
To: Linux OMAP List, Linux SPI Devel List, Grant Likely, Tony Lindgren
Cc: AnilKumar, Mark Brown, Linux Kernel Mailing List, Linux ARM Kernel List
Adds pinctrl support to support OMAP platforms that boot from DT
and rely on pinctrl support to set pinmuxes.
Signed-off-by: Matt Porter <mporter-l0cyMroinI0@public.gmane.org>
---
drivers/spi/spi-omap2-mcspi.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
index b2fb141..9502566 100644
--- a/drivers/spi/spi-omap2-mcspi.c
+++ b/drivers/spi/spi-omap2-mcspi.c
@@ -38,6 +38,8 @@
#include <linux/pm_runtime.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/pinctrl/consumer.h>
+#include <linux/err.h>
#include <linux/spi/spi.h>
@@ -1124,6 +1126,7 @@ static int __devinit omap2_mcspi_probe(struct platform_device *pdev)
static int bus_num = 1;
struct device_node *node = pdev->dev.of_node;
const struct of_device_id *match;
+ struct pinctrl *pinctrl;
master = spi_alloc_master(&pdev->dev, sizeof *mcspi);
if (master == NULL) {
@@ -1219,6 +1222,11 @@ static int __devinit omap2_mcspi_probe(struct platform_device *pdev)
if (status < 0)
goto dma_chnl_free;
+ pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+ if (IS_ERR(pinctrl))
+ dev_warn(&pdev->dev,
+ "pins are not configured from the driver\n");
+
pm_runtime_use_autosuspend(&pdev->dev);
pm_runtime_set_autosuspend_delay(&pdev->dev, SPI_AUTOSUSPEND_TIMEOUT);
pm_runtime_enable(&pdev->dev);
--
1.7.9.5
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [REPOST PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support
[not found] ` <1347969685-15571-1-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
@ 2012-09-18 12:08 ` Shubhrajyoti
[not found] ` <50586424.9040601-l0cyMroinI0@public.gmane.org>
2012-09-22 16:06 ` Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Shubhrajyoti @ 2012-09-18 12:08 UTC (permalink / raw)
To: Matt Porter
Cc: Tony Lindgren, Mark Brown, Linux Kernel Mailing List, AnilKumar,
Linux SPI Devel List, Linux OMAP List, Linux ARM Kernel List
On Tuesday 18 September 2012 05:31 PM, Matt Porter wrote:
> Adds pinctrl support to support OMAP platforms that boot from DT
> and rely on pinctrl support to set pinmuxes.
looks good
Acked-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Matt Porter <mporter-l0cyMroinI0@public.gmane.org>
> ---
> drivers/spi/spi-omap2-mcspi.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
> index b2fb141..9502566 100644
> --- a/drivers/spi/spi-omap2-mcspi.c
> +++ b/drivers/spi/spi-omap2-mcspi.c
> @@ -38,6 +38,8 @@
> #include <linux/pm_runtime.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> +#include <linux/pinctrl/consumer.h>
> +#include <linux/err.h>
>
> #include <linux/spi/spi.h>
>
> @@ -1124,6 +1126,7 @@ static int __devinit omap2_mcspi_probe(struct platform_device *pdev)
> static int bus_num = 1;
> struct device_node *node = pdev->dev.of_node;
> const struct of_device_id *match;
> + struct pinctrl *pinctrl;
>
> master = spi_alloc_master(&pdev->dev, sizeof *mcspi);
> if (master == NULL) {
> @@ -1219,6 +1222,11 @@ static int __devinit omap2_mcspi_probe(struct platform_device *pdev)
> if (status < 0)
> goto dma_chnl_free;
>
> + pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> + if (IS_ERR(pinctrl))
> + dev_warn(&pdev->dev,
> + "pins are not configured from the driver\n");
> +
> pm_runtime_use_autosuspend(&pdev->dev);
> pm_runtime_set_autosuspend_delay(&pdev->dev, SPI_AUTOSUSPEND_TIMEOUT);
> pm_runtime_enable(&pdev->dev);
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [REPOST PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support
[not found] ` <50586424.9040601-l0cyMroinI0@public.gmane.org>
@ 2012-09-18 16:55 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2012-09-18 16:55 UTC (permalink / raw)
To: Shubhrajyoti
Cc: Matt Porter, Mark Brown, Linux Kernel Mailing List, AnilKumar,
Linux SPI Devel List, Linux OMAP List, Linux ARM Kernel List
* Shubhrajyoti <shubhrajyoti-l0cyMroinI0@public.gmane.org> [120918 05:09]:
> On Tuesday 18 September 2012 05:31 PM, Matt Porter wrote:
> > Adds pinctrl support to support OMAP platforms that boot from DT
> > and rely on pinctrl support to set pinmuxes.
> looks good
>
> Acked-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [REPOST PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support
[not found] ` <1347969685-15571-1-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-09-18 12:08 ` Shubhrajyoti
@ 2012-09-22 16:06 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-09-22 16:06 UTC (permalink / raw)
To: Matt Porter
Cc: Tony Lindgren, Linux Kernel Mailing List, AnilKumar,
Linux SPI Devel List, Linux OMAP List, Linux ARM Kernel List
On Tue, Sep 18, 2012 at 08:01:25AM -0400, Matt Porter wrote:
> Adds pinctrl support to support OMAP platforms that boot from DT
> and rely on pinctrl support to set pinmuxes.
Applied, thanks.
------------------------------------------------------------------------------
How fast is your code?
3 out of 4 devs don\\\'t know how their code performs in production.
Find out how slow your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219672;13503038;z?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-22 16:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-18 12:01 [REPOST PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support Matt Porter
[not found] ` <1347969685-15571-1-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-09-18 12:08 ` Shubhrajyoti
[not found] ` <50586424.9040601-l0cyMroinI0@public.gmane.org>
2012-09-18 16:55 ` Tony Lindgren
2012-09-22 16:06 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).