[PATCH] spi: qup: Depend on ARCH_QCOM

[PATCH] spi: qup: Depend on ARCH_QCOM

[Paul Bolle]

Commit 8fc1b0f87d9f ("ARM: qcom: Split Qualcomm support into legacy and
multiplatform") removed Kconfig symbol ARCH_MSM_DT. But that commit
left one (optional) dependency on ARCH_MSM_DT untouched.

Three Kconfig symbols used to depend on ARCH_MSM_DT: ARCH_MSM8X60,
ARCH_MSM8960, and ARCH_MSM8974. These three symbols now depend on
ARCH_QCOM. So it appears this driver needs to depend on ARCH_QCOM too.

Signed-off-by: Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
---
Untested!

Note that this is basically guesswork: looking at commit 8fc1b0f87d9f it
appears to make sense to pick ARCH_QCOM here.

 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index efe1960af2b3..60f2b41c7310 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -383,7 +383,7 @@ config SPI_RSPI
 
 config SPI_QUP
 	tristate "Qualcomm SPI controller with QUP interface"
-	depends on ARCH_MSM_DT || (ARM && COMPILE_TEST)
+	depends on ARCH_QCOM || (ARM && COMPILE_TEST)
 	help
 	  Qualcomm Universal Peripheral (QUP) core is an AHB slave that
 	  provides a common data path (an output FIFO and an input FIFO)
-- 
1.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: qup: Depend on ARCH_QCOM

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

On Sun, Apr 06, 2014 at 01:45:33PM +0200, Paul Bolle wrote:
> Commit 8fc1b0f87d9f ("ARM: qcom: Split Qualcomm support into legacy and
> multiplatform") removed Kconfig symbol ARCH_MSM_DT. But that commit
> left one (optional) dependency on ARCH_MSM_DT untouched.
> 
> Three Kconfig symbols used to depend on ARCH_MSM_DT: ARCH_MSM8X60,
> ARCH_MSM8960, and ARCH_MSM8974. These three symbols now depend on
> ARCH_QCOM. So it appears this driver needs to depend on ARCH_QCOM too.

You probably want to CC some of the Qualcomm people (or whoever made the
above change) who know what's going on with these symbols.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[PATCH] [RESEND] spi: qup: Depend on ARCH_QCOM

[Paul Bolle]

Commit 8fc1b0f87d9f ("ARM: qcom: Split Qualcomm support into legacy and
multiplatform") removed Kconfig symbol ARCH_MSM_DT. But that commit
left one (optional) dependency on ARCH_MSM_DT untouched.

Three Kconfig symbols used to depend on ARCH_MSM_DT: ARCH_MSM8X60,
ARCH_MSM8960, and ARCH_MSM8974. These three symbols now depend on
ARCH_QCOM. So it appears this driver needs to depend on ARCH_QCOM too.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Resending, because Mark suggested to include the Qualcomm people (who
know what's going on with these symbols).

Still untested!

Note that this is basically guesswork: looking at commit 8fc1b0f87d9f it
appears to make sense to pick ARCH_QCOM here.

 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index efe1960af2b3..60f2b41c7310 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -383,7 +383,7 @@ config SPI_RSPI
 
 config SPI_QUP
 	tristate "Qualcomm SPI controller with QUP interface"
-	depends on ARCH_MSM_DT || (ARM && COMPILE_TEST)
+	depends on ARCH_QCOM || (ARM && COMPILE_TEST)
 	help
 	  Qualcomm Universal Peripheral (QUP) core is an AHB slave that
 	  provides a common data path (an output FIFO and an input FIFO)
-- 
1.9.0

Re: [PATCH] [RESEND] spi: qup: Depend on ARCH_QCOM

[Stephen Boyd]

On 04/07, Paul Bolle wrote:
> Commit 8fc1b0f87d9f ("ARM: qcom: Split Qualcomm support into legacy and
> multiplatform") removed Kconfig symbol ARCH_MSM_DT. But that commit
> left one (optional) dependency on ARCH_MSM_DT untouched.
> 
> Three Kconfig symbols used to depend on ARCH_MSM_DT: ARCH_MSM8X60,
> ARCH_MSM8960, and ARCH_MSM8974. These three symbols now depend on
> ARCH_QCOM. So it appears this driver needs to depend on ARCH_QCOM too.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

> Resending, because Mark suggested to include the Qualcomm people (who
> know what's going on with these symbols).
> 
> Still untested!
> 
> Note that this is basically guesswork: looking at commit 8fc1b0f87d9f it
> appears to make sense to pick ARCH_QCOM here.

That's correct.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

Re: [PATCH] [RESEND] spi: qup: Depend on ARCH_QCOM

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

On Mon, Apr 07, 2014 at 04:15:45PM +0200, Paul Bolle wrote:
> Commit 8fc1b0f87d9f ("ARM: qcom: Split Qualcomm support into legacy and
> multiplatform") removed Kconfig symbol ARCH_MSM_DT. But that commit
> left one (optional) dependency on ARCH_MSM_DT untouched.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]