[PATCH 1/2] spi: bcm53xx: Fix module dependency

[PATCH 1/2] spi: bcm53xx: Fix module dependency

[Axel Lin]

config SPI_BCM53XX needs to depend on BCMA_POSSIBLE and select BCMA.
This fixes below build error:
ERROR: "bcma_driver_unregister" [drivers/spi/spi-bcm53xx.ko] undefined!
ERROR: "__bcma_driver_register" [drivers/spi/spi-bcm53xx.ko] undefined!

Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
 drivers/spi/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index dc10453..84e7c9e 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -116,6 +116,8 @@ config SPI_AU1550
 config SPI_BCM53XX
 	tristate "Broadcom BCM53xx SPI controller"
 	depends on ARCH_BCM_5301X
+	depends on BCMA_POSSIBLE
+	select BCMA
 	help
           Enable support for the SPI controller on Broadcom BCM53xx ARM SoCs.
 
-- 
1.9.1



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] spi: bcm53xx: Add missing module information

[Axel Lin]

Mainly to fix missing MODULE_LICENSE.
Also add MODULE_DESCRIPTION and MODULE_AUTHOR.

Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
 drivers/spi/spi-bcm53xx.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/spi/spi-bcm53xx.c b/drivers/spi/spi-bcm53xx.c
index e6600f7..17b34cb 100644
--- a/drivers/spi/spi-bcm53xx.c
+++ b/drivers/spi/spi-bcm53xx.c
@@ -293,3 +293,7 @@ static void __exit bcm53xxspi_module_exit(void)
 
 module_init(bcm53xxspi_module_init);
 module_exit(bcm53xxspi_module_exit);
+
+MODULE_DESCRIPTION("Broadcom BCM53xx SPI Controller driver");
+MODULE_AUTHOR("Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>");
+MODULE_LICENSE("GPL");
-- 
1.9.1



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] spi: bcm53xx: Fix module dependency

[Rafał Miłecki]

On 26 September 2014 08:18, Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org> wrote:
> config SPI_BCM53XX needs to depend on BCMA_POSSIBLE and select BCMA.
> This fixes below build error:
> ERROR: "bcma_driver_unregister" [drivers/spi/spi-bcm53xx.ko] undefined!
> ERROR: "__bcma_driver_register" [drivers/spi/spi-bcm53xx.ko] undefined!

Thanks for your patches, look fine!
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] spi: bcm53xx: Fix module dependency

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

On Fri, Sep 26, 2014 at 02:18:31PM +0800, Axel Lin wrote:
> config SPI_BCM53XX needs to depend on BCMA_POSSIBLE and select BCMA.
> This fixes below build error:
> ERROR: "bcma_driver_unregister" [drivers/spi/spi-bcm53xx.ko] undefined!
> ERROR: "__bcma_driver_register" [drivers/spi/spi-bcm53xx.ko] undefined!

Applied both, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]