* [PATCH 1/2] ACPI / APD: Add device HID for Vulcan SPI controller
@ 2016-08-08 12:18 kamlakant.patel-dY08KVG/lbpWk0Htik3J/w
[not found] ` <1470658708-8203-1-git-send-email-kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: kamlakant.patel-dY08KVG/lbpWk0Htik3J/w @ 2016-08-08 12:18 UTC (permalink / raw)
To: Mark Brown
Cc: Kamlakant Patel, linux-spi-u79uwXL29TY76Z2rM5mHXA, Jayachandran C
From: Kamlakant Patel <kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Add device HID for SPI controller on Broadcom Vulcan ARM64.
The default frequency for SPI on Vulcan is 133MHz.
Signed-off-by: Kamlakant Patel <kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
---
drivers/acpi/acpi_apd.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index 1daf9c4..c80c8f8 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -87,6 +87,11 @@ static struct apd_device_desc xgene_i2c_desc = {
.setup = acpi_apd_setup,
.fixed_clk_rate = 100000000,
};
+
+static struct apd_device_desc vulcan_spi_desc = {
+ .setup = acpi_apd_setup,
+ .fixed_clk_rate = 133000000,
+};
#endif
#else
@@ -149,6 +154,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
#endif
#ifdef CONFIG_ARM64
{ "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
+ { "BRCM900D", APD_ADDR(vulcan_spi_desc) },
#endif
{ }
};
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] spi: xlp: Add ACPI support for Vulcan SPI controller
[not found] ` <1470658708-8203-1-git-send-email-kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
@ 2016-08-08 12:18 ` kamlakant.patel-dY08KVG/lbpWk0Htik3J/w
[not found] ` <1470658708-8203-2-git-send-email-kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-08-08 13:14 ` [PATCH 1/2] ACPI / APD: Add device HID " Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: kamlakant.patel-dY08KVG/lbpWk0Htik3J/w @ 2016-08-08 12:18 UTC (permalink / raw)
To: Mark Brown
Cc: Kamlakant Patel, linux-spi-u79uwXL29TY76Z2rM5mHXA, Jayachandran C
From: Kamlakant Patel <kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Add ACPI support for SPI controller on Broadcom Vulcan ARM64.
Signed-off-by: Kamlakant Patel <kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
---
drivers/spi/spi-xlp.c | 17 +++++++++++++----
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-xlp.c b/drivers/spi/spi-xlp.c
index 8f04fec..63483f5 100644
--- a/drivers/spi/spi-xlp.c
+++ b/drivers/spi/spi-xlp.c
@@ -11,6 +11,7 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
+#include <linux/acpi.h>
#include <linux/clk.h>
#include <linux/kernel.h>
#include <linux/module.h>
@@ -403,10 +404,9 @@ static int xlp_spi_probe(struct platform_device *pdev)
}
clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(clk)) {
- dev_err(&pdev->dev, "could not get spi clock\n");
- return -ENODEV;
- }
+ if (IS_ERR(clk))
+ return -EPROBE_DEFER;
+
xspi->spi_clk = clk_get_rate(clk);
master = spi_alloc_master(&pdev->dev, 0);
@@ -437,6 +437,14 @@ static int xlp_spi_probe(struct platform_device *pdev)
return 0;
}
+#ifdef CONFIG_ACPI
+static const struct acpi_device_id xlp_spi_acpi_match[] = {
+ { "BRCM900D", 0 },
+ { },
+};
+MODULE_DEVICE_TABLE(acpi, xlp_spi_acpi_match);
+#endif
+
static const struct of_device_id xlp_spi_dt_id[] = {
{ .compatible = "netlogic,xlp832-spi" },
{ },
@@ -447,6 +455,7 @@ static struct platform_driver xlp_spi_driver = {
.driver = {
.name = "xlp-spi",
.of_match_table = xlp_spi_dt_id,
+ .acpi_match_table = ACPI_PTR(xlp_spi_acpi_match),
},
};
module_platform_driver(xlp_spi_driver);
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] spi: xlp: Add ACPI support for Vulcan SPI controller
[not found] ` <1470658708-8203-2-git-send-email-kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
@ 2016-08-08 13:14 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2016-08-08 13:14 UTC (permalink / raw)
To: kamlakant.patel-dY08KVG/lbpWk0Htik3J/w
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, Jayachandran C
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Mon, Aug 08, 2016 at 05:48:28PM +0530, kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org wrote:
> - if (IS_ERR(clk)) {
> - dev_err(&pdev->dev, "could not get spi clock\n");
> - return -ENODEV;
> - }
> + if (IS_ERR(clk))
> + return -EPROBE_DEFER;
> +
No, this is broken - if there really is a fatal error it'll silently
discard it and replace it with -EPROBE_DEFER. This will cause things to
be incorrectly deferred if there is a real error making it harder for
people to diagnose problems. You should just pass the error code you
get back to the caller.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ACPI / APD: Add device HID for Vulcan SPI controller
[not found] ` <1470658708-8203-1-git-send-email-kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-08-08 12:18 ` [PATCH 2/2] spi: xlp: Add ACPI support " kamlakant.patel-dY08KVG/lbpWk0Htik3J/w
@ 2016-08-08 13:14 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2016-08-08 13:14 UTC (permalink / raw)
To: kamlakant.patel-dY08KVG/lbpWk0Htik3J/w
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, Jayachandran C
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
On Mon, Aug 08, 2016 at 05:48:27PM +0530, kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org wrote:
> From: Kamlakant Patel <kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
>
> Add device HID for SPI controller on Broadcom Vulcan ARM64.
> The default frequency for SPI on Vulcan is 133MHz.
As covered in SubmittingPatches you need to send patches to the relevant
maintainers and lists for them to review.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-08 13:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-08 12:18 [PATCH 1/2] ACPI / APD: Add device HID for Vulcan SPI controller kamlakant.patel-dY08KVG/lbpWk0Htik3J/w
[not found] ` <1470658708-8203-1-git-send-email-kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-08-08 12:18 ` [PATCH 2/2] spi: xlp: Add ACPI support " kamlakant.patel-dY08KVG/lbpWk0Htik3J/w
[not found] ` <1470658708-8203-2-git-send-email-kamlakant.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-08-08 13:14 ` Mark Brown
2016-08-08 13:14 ` [PATCH 1/2] ACPI / APD: Add device HID " Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).