From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Pandy Gao <pandy.gao-3arQi8VN3Tc@public.gmane.org>
Cc: "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [Patch V1 2/2] spi: fsl-lpspi: add VLLS mode support
Date: Tue, 17 Jan 2017 19:04:07 +0000 [thread overview]
Message-ID: <20170117190407.p5ad3dz7ixqm4vz6@sirena.org.uk> (raw)
In-Reply-To: <AM4PR0401MB22737664A5030928464226C7F67C0-4rsfagO7TJw08dPJ0juu2Y3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Tue, Jan 17, 2017 at 07:03:28AM +0000, Pandy Gao wrote:
> > > The patch recovers the pinctrl setting when exit VLLS mode.
> > Why is this a change here and not in the pinctrl driver? It sounds like
> > it's the pinctrl driver that's forgetting the settings and should be
> > restoring them on resume but perhaps I'm missing something here.
> If the pinctrl driver restores the setting on resume, then all device node
> should be scanned, which is irregular.
What would restoring the configuration have to do with scanning the
device tree? The changelog says this is just reapplying the same
settings we started out with so it's just a case of restoring the state
of the device after a runtime resume which is a perfectly normal thing
for a driver to do.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-01-17 19:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 9:38 [Patch V1 1/2] spi: fsl-lpspi: fix indentation error Gao Pan
[not found] ` <1483522697-6691-1-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org>
2017-01-04 9:38 ` [Patch V1 2/2] spi: fsl-lpspi: add VLLS mode support Gao Pan
[not found] ` <1483522697-6691-2-git-send-email-pandy.gao-3arQi8VN3Tc@public.gmane.org>
2017-01-09 19:33 ` Mark Brown
[not found] ` <20170109193350.aufenjuhtge5e3lu-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-01-17 7:03 ` Pandy Gao
[not found] ` <AM4PR0401MB22737664A5030928464226C7F67C0-4rsfagO7TJw08dPJ0juu2Y3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-01-17 19:04 ` Mark Brown [this message]
[not found] ` <20170117190407.p5ad3dz7ixqm4vz6-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-01-18 3:50 ` Pandy Gao
2017-01-09 20:01 ` Applied "spi: fsl-lpspi: fix indentation error" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117190407.p5ad3dz7ixqm4vz6@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pandy.gao-3arQi8VN3Tc@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).