Re: [PATCH v2] ARM: spi/sun7i: Add Master Sample Data Mode for SPI

From: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
To: Vinicius Maciel <viniciusfre-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	siarhei.siamashka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	wens-jdAy2FN1RRM@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org
Subject: Re: [PATCH v2] ARM: spi/sun7i: Add Master Sample Data Mode for SPI
Date: Sat, 11 Feb 2017 14:58:54 +0800	[thread overview]
Message-ID: <20170212033109.V3xe2GIs@smtp2p.mail.yandex.net> (raw)

ARM: is not needed.

2017年2月11日 11:54于 Vinicius Maciel <viniciusfre-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>写道：
>
> In order to work appropriately, the max11043 ADC chip and probably 
> others, needs SPI master samples the data at the correct edge. From 
> max11043 datasheet: "The data at DIN is latched on the rising edge 
> of SCLK". Same to DOUT. 
>
> This patch add Master Sample Data Mode bit in normal sample mode. 
> It will affect only A20. 
>
> Signed-off-by: Vinicius Maciel <viniciusfre-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 
> Reviewed-by: Siarhei Siamashka <siarhei.siamashka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 
> --- 
> drivers/spi/spi-sun4i.c | 4 +++- 
> 1 file changed, 3 insertions(+), 1 deletion(-) 
>
> diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c 
> index c5cd635c28f3..6325be2ce8d9 100644 
> --- a/drivers/spi/spi-sun4i.c 
> +++ b/drivers/spi/spi-sun4i.c 
> @@ -44,6 +44,7 @@ 
> #define SUN4I_CTL_CS_MANUAL BIT(16) 
> #define SUN4I_CTL_CS_LEVEL BIT(17) 
> #define SUN4I_CTL_TP BIT(18) 
> +#define SUN4I_CTL_SDM BIT(20) 
>
> #define SUN4I_INT_CTL_REG 0x0c 
> #define SUN4I_INT_CTL_RF_F34 BIT(4) 
> @@ -407,7 +408,8 @@ static int sun4i_spi_runtime_resume(struct device *dev) 
> } 
>
> sun4i_spi_write(sspi, SUN4I_CTL_REG, 
> - SUN4I_CTL_ENABLE | SUN4I_CTL_MASTER | SUN4I_CTL_TP); 
> + SUN4I_CTL_ENABLE | SUN4I_CTL_MASTER | SUN4I_CTL_TP | 
> + SUN4I_CTL_SDM); 
>
> return 0; 
>
> -- 
> 2.11.0 
>
> -- 
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group. 
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org 
> For more options, visit https://groups.google.com/d/optout. 

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.