linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m
@ 2017-09-21 18:02 Randy Dunlap
       [not found] ` <ed5b8ca2-b853-755d-2801-57cc0b626508-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
  0 siblings, 1 reply; 13+ messages in thread
From: Randy Dunlap @ 2017-09-21 18:02 UTC (permalink / raw)
  To: LKML, linux-spi, Mark Brown

From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors when CONFIG_HWSPINLOCK=m and SPI_SPRD_ADI=y.
That combination is not allowed.

drivers/spi/spi-sprd-adi.o: In function `sprd_adi_remove':
spi-sprd-adi.c:(.text+0x13): undefined reference to `hwspin_lock_free'
drivers/spi/spi-sprd-adi.o: In function `sprd_adi_probe':
spi-sprd-adi.c:(.text+0xf5): undefined reference to `of_hwspin_lock_get_id'
spi-sprd-adi.c:(.text+0x107): undefined reference to `hwspin_lock_request_specific'
spi-sprd-adi.c:(.text+0x22e): undefined reference to `hwspin_lock_free'
drivers/spi/spi-sprd-adi.o: In function `sprd_adi_transfer_one':
spi-sprd-adi.c:(.text+0x2eb): undefined reference to `__hwspin_lock_timeout'
spi-sprd-adi.c:(.text+0x349): undefined reference to `__hwspin_unlock'
spi-sprd-adi.c:(.text+0x389): undefined reference to `__hwspin_lock_timeout'
spi-sprd-adi.c:(.text+0x3ee): undefined reference to `__hwspin_unlock'

v2: allow build with or without HWSPINLOCK, but restrict to =m
if HWSPINLOCK=m.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Baolin Wang <Baolin.Wang@spreadtrum.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org
---
 drivers/spi/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20170921.orig/drivers/spi/Kconfig
+++ linux-next-20170921/drivers/spi/Kconfig
@@ -625,6 +625,7 @@ config SPI_SIRF
 config SPI_SPRD_ADI
 	tristate "Spreadtrum ADI controller"
 	depends on ARCH_SPRD || COMPILE_TEST
+	depends on HWSPINLOCK || HWSPINLOCK=n
 	help
 	  ADI driver based on SPI for Spreadtrum SoCs.
 

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2017-09-25 22:32 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-21 18:02 [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap
     [not found] ` <ed5b8ca2-b853-755d-2801-57cc0b626508-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-09-22  9:26   ` Mark Brown
     [not found]     ` <20170922092621.uq2xsvxangeetewi-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-09-23  1:46       ` Randy Dunlap
     [not found]         ` <9dc8b064-8a6c-98d2-4ade-088cbfd56fb1-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-09-25 16:12           ` Mark Brown
2017-09-25 17:19             ` Randy Dunlap
     [not found]               ` <449abd0e-8d8b-86e9-2b7a-65c27ab3171b-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-09-25 17:36                 ` Mark Brown
2017-09-25 19:20                 ` Geert Uytterhoeven
2017-09-25 19:22                   ` Mark Brown
2017-09-25 19:31                     ` Randy Dunlap
     [not found]                       ` <156431d9-a518-53e7-17d9-bb1ee0f637bb-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-09-25 19:44                         ` Mark Brown
     [not found]                           ` <20170925194417.bjkw5ar6s57bkbdt-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-09-25 19:53                             ` Randy Dunlap
     [not found]                               ` <c0c60c5e-d06f-b246-fb63-3eb507c62449-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-09-25 21:11                                 ` Mark Brown
     [not found]                                   ` <20170925211154.j23g4b2xmu4f3cxc-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-09-25 22:32                                     ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).