* [PATCH v3 0/7] spi: add support for octo mode
@ 2018-10-23 9:37 Yogesh Narayan Gaur
2018-10-23 9:37 ` [PATCH v3 1/7] spi: add support for octo mode I/O data transfer Yogesh Narayan Gaur
` (7 more replies)
0 siblings, 8 replies; 12+ messages in thread
From: Yogesh Narayan Gaur @ 2018-10-23 9:37 UTC (permalink / raw)
To: linux-mtd, boris.brezillon, broonie, marek.vasut, vigneshr,
linux-spi, devicetree
Cc: mark.rutland, robh, Yogesh Narayan Gaur, linux-kernel,
frieder.schrempf, computersforpeace, shawnguo, linux-arm-kernel
Add support for octo mode IO data transfer.
Micron flash, mt35xu512aba, supports octal mode data transfer and
NXP FlexSPI controller supports 8 data lines for data transfer (Rx/Tx).
Patch series
* Add support for octo mode flags and parsing of same in spi driver.
* Add parsing logic for spi-mem framework and m25p80.c device file.
* Add opcodes for octo I/O commands in spi-nor framework, Read and Write proto for (1-1-8/1-8-8) mode.
Opcodes are added as per octal data IO commands required for mt35xu512aba [1] flash.
* Add mode bit required for octo mode in nxp-fspi driver [2].
* Define binding property 'spi-rx/tx-bus-width' for LX2160ARDB target [2].
Cherry pick below 2 patches (from: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git):
c639f871febe6667d9afce28108c634e5636c735 spi: spi-mem: Fix inverted logic in op sanity check
db122eb8a749a1eff038f9a282c620ab16c4be1d spi: spi-mem: Add extra sanity checks on the op param
Tested on LX2160ARDB target with nxp-fspi driver, below are
Read performance number of 1-1-1 and 1-1-8 read protocol.
root@lxxx:~# cat /proc/mtd
dev: size erasesize name
mtd0: 04000000 00001000 "spi0.0"
mtd1: 04000000 00001000 "spi0.1"
root@lxxx:~# time mtd_debug read /dev/mtd0 0x0 0x1000000 0read
Copied 16777216 bytes from address 0x00000000 in flash to 0read
real 0m2.792s
user 0m0.000s
sys 0m2.790s
root@lxxx:~# time mtd_debug read /dev/mtd1 0x0 0x1000000 0read
Copied 16777216 bytes from address 0x00000000 in flash to 0read
real 0m0.441s
user 0m0.000s
sys 0m0.440s
root@ls1012ardb:~#
Flash device MTD0 configured in 1-1-1 protocol.
Flash device MTD1 configured in 1-1-8 protocol.
[1] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=70384
[2] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=72181
Yogesh Gaur (7):
spi: add support for octo mode I/O data transfer
spi: spi-mem: add support for octo mode I/O data transfer
mtd: spi-nor: add opcodes for octo Read/Write commands
mtd: spi-nor: add octo read flag for flash mt35xu512aba
mtd: m25p80: add support of octo mode I/O transfer
spi: nxp-fspi: add octo mode flag bit for octal support
arm64: dts: lx2160a: update fspi node
Changes for v3:
- Add octo mode support in spi_setup().
- Rename all patches with 'octal' string modified as 'octo'.
Changes for v2:
- Incorporated review comments of Boris and Vignesh.
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 4 ++++
drivers/mtd/devices/m25p80.c | 9 ++++++++-
drivers/mtd/spi-nor/spi-nor.c | 15 ++++++++++++++-
drivers/spi/spi-mem.c | 9 ++++++++-
drivers/spi/spi-nxp-fspi.c | 4 ++--
drivers/spi/spi.c | 12 ++++++++++--
include/linux/mtd/spi-nor.h | 8 ++++++++
include/linux/spi/spi.h | 2 ++
8 files changed, 56 insertions(+), 7 deletions(-)
--
2.7.4
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 1/7] spi: add support for octo mode I/O data transfer
2018-10-23 9:37 [PATCH v3 0/7] spi: add support for octo mode Yogesh Narayan Gaur
@ 2018-10-23 9:37 ` Yogesh Narayan Gaur
2018-10-23 9:48 ` Boris Brezillon
2018-10-23 9:37 ` [PATCH v3 2/7] spi: spi-mem: " Yogesh Narayan Gaur
` (6 subsequent siblings)
7 siblings, 1 reply; 12+ messages in thread
From: Yogesh Narayan Gaur @ 2018-10-23 9:37 UTC (permalink / raw)
To: linux-mtd, boris.brezillon, broonie, marek.vasut, vigneshr,
linux-spi, devicetree
Cc: robh, mark.rutland, shawnguo, linux-arm-kernel,
computersforpeace, frieder.schrempf, linux-kernel,
Yogesh Narayan Gaur
Add flags for Octo mode I/O data transfer
Required for the SPI controller which can do the data transfer (TX/RX)
on 8 data lines e.g. NXP FlexSPI controller.
SPI_TX_OCTO: transmit with 8 wires
SPI_RX_OCTO: receive with 8 wires
Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
---
Changes for v3:
- Modified string 'octal' with 'octo'.
- Add octo mode support in spi_setup().
Changes for v2:
- Incorporated review comments of Boris.
drivers/spi/spi.c | 12 ++++++++++--
include/linux/spi/spi.h | 2 ++
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index ec395a6..6d57fa7 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1573,6 +1573,9 @@ static int of_spi_parse_dt(struct spi_controller *ctlr, struct spi_device *spi,
case 4:
spi->mode |= SPI_TX_QUAD;
break;
+ case 8:
+ spi->mode |= SPI_TX_OCTO;
+ break;
default:
dev_warn(&ctlr->dev,
"spi-tx-bus-width %d not supported\n",
@@ -1591,6 +1594,9 @@ static int of_spi_parse_dt(struct spi_controller *ctlr, struct spi_device *spi,
case 4:
spi->mode |= SPI_RX_QUAD;
break;
+ case 8:
+ spi->mode |= SPI_RX_OCTO;
+ break;
default:
dev_warn(&ctlr->dev,
"spi-rx-bus-width %d not supported\n",
@@ -2770,14 +2776,16 @@ int spi_setup(struct spi_device *spi)
/* if it is SPI_3WIRE mode, DUAL and QUAD should be forbidden
*/
if ((spi->mode & SPI_3WIRE) && (spi->mode &
- (SPI_TX_DUAL | SPI_TX_QUAD | SPI_RX_DUAL | SPI_RX_QUAD)))
+ (SPI_TX_DUAL | SPI_TX_QUAD | SPI_TX_OCTO |
+ SPI_RX_DUAL | SPI_RX_QUAD | SPI_RX_OCTO)))
return -EINVAL;
/* help drivers fail *cleanly* when they need options
* that aren't supported with their current controller
*/
bad_bits = spi->mode & ~spi->controller->mode_bits;
ugly_bits = bad_bits &
- (SPI_TX_DUAL | SPI_TX_QUAD | SPI_RX_DUAL | SPI_RX_QUAD);
+ (SPI_TX_DUAL | SPI_TX_QUAD | SPI_TX_OCTO |
+ SPI_RX_DUAL | SPI_RX_QUAD | SPI_RX_OCTO);
if (ugly_bits) {
dev_warn(&spi->dev,
"setup: ignoring unsupported mode bits %x\n",
diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
index a64235e..cea4e49 100644
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -163,6 +163,8 @@ struct spi_device {
#define SPI_TX_QUAD 0x200 /* transmit with 4 wires */
#define SPI_RX_DUAL 0x400 /* receive with 2 wires */
#define SPI_RX_QUAD 0x800 /* receive with 4 wires */
+#define SPI_TX_OCTO 0x1000 /* transmit with 8 wires */
+#define SPI_RX_OCTO 0x2000 /* receive with 8 wires */
int irq;
void *controller_state;
void *controller_data;
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 2/7] spi: spi-mem: add support for octo mode I/O data transfer
2018-10-23 9:37 [PATCH v3 0/7] spi: add support for octo mode Yogesh Narayan Gaur
2018-10-23 9:37 ` [PATCH v3 1/7] spi: add support for octo mode I/O data transfer Yogesh Narayan Gaur
@ 2018-10-23 9:37 ` Yogesh Narayan Gaur
2018-10-23 9:49 ` Boris Brezillon
2018-10-23 9:37 ` [PATCH v3 3/7] mtd: spi-nor: add opcodes for octo Read/Write commands Yogesh Narayan Gaur
` (5 subsequent siblings)
7 siblings, 1 reply; 12+ messages in thread
From: Yogesh Narayan Gaur @ 2018-10-23 9:37 UTC (permalink / raw)
To: linux-mtd, boris.brezillon, broonie, marek.vasut, vigneshr,
linux-spi, devicetree
Cc: robh, mark.rutland, shawnguo, linux-arm-kernel,
computersforpeace, frieder.schrempf, linux-kernel,
Yogesh Narayan Gaur
Add support for octo mode I/O data transfer in spi-mem framework.
Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
---
Changes for v3:
- Modified string 'octal' with 'octo'.
Changes for v2:
- Patch added in v2 version.
drivers/spi/spi-mem.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
index c6bdea7..2379efc 100644
--- a/drivers/spi/spi-mem.c
+++ b/drivers/spi/spi-mem.c
@@ -12,7 +12,7 @@
#include "internals.h"
-#define SPI_MEM_MAX_BUSWIDTH 4
+#define SPI_MEM_MAX_BUSWIDTH 8
/**
* spi_controller_dma_map_mem_op_data() - DMA-map the buffer attached to a
@@ -121,6 +121,13 @@ static int spi_check_buswidth_req(struct spi_mem *mem, u8 buswidth, bool tx)
break;
+ case 8:
+ if ((tx && (mode & SPI_TX_OCTO)) ||
+ (!tx && (mode & SPI_RX_OCTO)))
+ return 0;
+
+ break;
+
default:
break;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 3/7] mtd: spi-nor: add opcodes for octo Read/Write commands
2018-10-23 9:37 [PATCH v3 0/7] spi: add support for octo mode Yogesh Narayan Gaur
2018-10-23 9:37 ` [PATCH v3 1/7] spi: add support for octo mode I/O data transfer Yogesh Narayan Gaur
2018-10-23 9:37 ` [PATCH v3 2/7] spi: spi-mem: " Yogesh Narayan Gaur
@ 2018-10-23 9:37 ` Yogesh Narayan Gaur
2018-10-23 9:37 ` [PATCH v3 4/7] mtd: spi-nor: add octo read flag for flash mt35xu512aba Yogesh Narayan Gaur
` (4 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Yogesh Narayan Gaur @ 2018-10-23 9:37 UTC (permalink / raw)
To: linux-mtd, boris.brezillon, broonie, marek.vasut, vigneshr,
linux-spi, devicetree
Cc: robh, mark.rutland, shawnguo, linux-arm-kernel,
computersforpeace, frieder.schrempf, linux-kernel,
Yogesh Narayan Gaur
- Add opcodes for octo I/O commands
* Read : 1-1-8 and 1-8-8 protocol
* Write : 1-1-8 and 1-8-8 protocol
* opcodes for 4-byte address mode command
- Entry of macros in _convert_3to4_xxx function
- Add flag specifying flash support octo read commands.
Signed-off-by: Vignesh R <vigneshr@ti.com>
Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
---
Changes for v3:
- Modified string 'octal' with 'octo'.
Changes for v2:
- Incorporated review comments of Boris and Vignesh
drivers/mtd/spi-nor/spi-nor.c | 12 ++++++++++++
include/linux/mtd/spi-nor.h | 8 ++++++++
2 files changed, 20 insertions(+)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 0b8a6e0..120c3bc 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -90,6 +90,7 @@ struct flash_info {
#define NO_CHIP_ERASE BIT(12) /* Chip does not support chip erase */
#define SPI_NOR_SKIP_SFDP BIT(13) /* Skip parsing of SFDP tables */
#define USE_CLSR BIT(14) /* use CLSR command */
+#define SPI_NOR_OCTO_READ BIT(15) /* Flash supports Octal Read */
int (*quad_enable)(struct spi_nor *nor);
};
@@ -209,6 +210,8 @@ static inline u8 spi_nor_convert_3to4_read(u8 opcode)
{ SPINOR_OP_READ_1_2_2, SPINOR_OP_READ_1_2_2_4B },
{ SPINOR_OP_READ_1_1_4, SPINOR_OP_READ_1_1_4_4B },
{ SPINOR_OP_READ_1_4_4, SPINOR_OP_READ_1_4_4_4B },
+ { SPINOR_OP_READ_1_1_8, SPINOR_OP_READ_1_1_8_4B },
+ { SPINOR_OP_READ_1_8_8, SPINOR_OP_READ_1_8_8_4B },
{ SPINOR_OP_READ_1_1_1_DTR, SPINOR_OP_READ_1_1_1_DTR_4B },
{ SPINOR_OP_READ_1_2_2_DTR, SPINOR_OP_READ_1_2_2_DTR_4B },
@@ -225,6 +228,8 @@ static inline u8 spi_nor_convert_3to4_program(u8 opcode)
{ SPINOR_OP_PP, SPINOR_OP_PP_4B },
{ SPINOR_OP_PP_1_1_4, SPINOR_OP_PP_1_1_4_4B },
{ SPINOR_OP_PP_1_4_4, SPINOR_OP_PP_1_4_4_4B },
+ { SPINOR_OP_PP_1_1_8, SPINOR_OP_PP_1_1_8_4B },
+ { SPINOR_OP_PP_1_8_8, SPINOR_OP_PP_1_8_8_4B },
};
return spi_nor_convert_opcode(opcode, spi_nor_3to4_program,
@@ -3195,6 +3200,13 @@ static int spi_nor_init_params(struct spi_nor *nor,
SNOR_PROTO_1_1_4);
}
+ if (info->flags & SPI_NOR_OCTO_READ) {
+ params->hwcaps.mask |= SNOR_HWCAPS_READ_1_1_8;
+ spi_nor_set_read_settings(¶ms->reads[SNOR_CMD_READ_1_1_8],
+ 0, 8, SPINOR_OP_READ_1_1_8,
+ SNOR_PROTO_1_1_8);
+ }
+
/* Page Program settings. */
params->hwcaps.mask |= SNOR_HWCAPS_PP;
spi_nor_set_pp_settings(¶ms->page_programs[SNOR_CMD_PP],
diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
index 8b1acf6..019f534 100644
--- a/include/linux/mtd/spi-nor.h
+++ b/include/linux/mtd/spi-nor.h
@@ -50,9 +50,13 @@
#define SPINOR_OP_READ_1_2_2 0xbb /* Read data bytes (Dual I/O SPI) */
#define SPINOR_OP_READ_1_1_4 0x6b /* Read data bytes (Quad Output SPI) */
#define SPINOR_OP_READ_1_4_4 0xeb /* Read data bytes (Quad I/O SPI) */
+#define SPINOR_OP_READ_1_1_8 0x8b /* Read data bytes (Octal Output SPI) */
+#define SPINOR_OP_READ_1_8_8 0xcb /* Read data bytes (Octal I/O SPI) */
#define SPINOR_OP_PP 0x02 /* Page program (up to 256 bytes) */
#define SPINOR_OP_PP_1_1_4 0x32 /* Quad page program */
#define SPINOR_OP_PP_1_4_4 0x38 /* Quad page program */
+#define SPINOR_OP_PP_1_1_8 0x82 /* Octal page program */
+#define SPINOR_OP_PP_1_8_8 0xc2 /* Octal page program */
#define SPINOR_OP_BE_4K 0x20 /* Erase 4KiB block */
#define SPINOR_OP_BE_4K_PMC 0xd7 /* Erase 4KiB block on PMC chips */
#define SPINOR_OP_BE_32K 0x52 /* Erase 32KiB block */
@@ -73,9 +77,13 @@
#define SPINOR_OP_READ_1_2_2_4B 0xbc /* Read data bytes (Dual I/O SPI) */
#define SPINOR_OP_READ_1_1_4_4B 0x6c /* Read data bytes (Quad Output SPI) */
#define SPINOR_OP_READ_1_4_4_4B 0xec /* Read data bytes (Quad I/O SPI) */
+#define SPINOR_OP_READ_1_1_8_4B 0x7c /* Read data bytes (Octal Output SPI) */
+#define SPINOR_OP_READ_1_8_8_4B 0xcc /* Read data bytes (Octal I/O SPI) */
#define SPINOR_OP_PP_4B 0x12 /* Page program (up to 256 bytes) */
#define SPINOR_OP_PP_1_1_4_4B 0x34 /* Quad page program */
#define SPINOR_OP_PP_1_4_4_4B 0x3e /* Quad page program */
+#define SPINOR_OP_PP_1_1_8_4B 0x84 /* Octal page program */
+#define SPINOR_OP_PP_1_8_8_4B 0x8e /* Octal page program */
#define SPINOR_OP_BE_4K_4B 0x21 /* Erase 4KiB block */
#define SPINOR_OP_BE_32K_4B 0x5c /* Erase 32KiB block */
#define SPINOR_OP_SE_4B 0xdc /* Sector erase (usually 64KiB) */
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 4/7] mtd: spi-nor: add octo read flag for flash mt35xu512aba
2018-10-23 9:37 [PATCH v3 0/7] spi: add support for octo mode Yogesh Narayan Gaur
` (2 preceding siblings ...)
2018-10-23 9:37 ` [PATCH v3 3/7] mtd: spi-nor: add opcodes for octo Read/Write commands Yogesh Narayan Gaur
@ 2018-10-23 9:37 ` Yogesh Narayan Gaur
2018-10-23 9:37 ` [PATCH v3 5/7] mtd: m25p80: add support of octo mode I/O transfer Yogesh Narayan Gaur
` (3 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Yogesh Narayan Gaur @ 2018-10-23 9:37 UTC (permalink / raw)
To: linux-mtd, boris.brezillon, broonie, marek.vasut, vigneshr,
linux-spi, devicetree
Cc: robh, mark.rutland, shawnguo, linux-arm-kernel,
computersforpeace, frieder.schrempf, linux-kernel,
Yogesh Narayan Gaur
Add octo read flag for flash mt35xu512aba.
This flash, mt35xu512aba, is only complaint to SFDP JESD216B and does
not seem to support newer JESD216C standard that provides auto
detection of Octal mode capabilities and opcodes. Therefore, this
capability is manually added using new SPI_NOR_OCTO_READ flag.
Signed-off-by: Vignesh R <vigneshr@ti.com>
Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
---
Changes for v3:
- Modified string 'octal' with 'octo'.
Changes for v2:
- Incorporated review comments of Boris and Vignesh
drivers/mtd/spi-nor/spi-nor.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 120c3bc..a04f579 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1413,7 +1413,8 @@ static const struct flash_info spi_nor_ids[] = {
/* Micron */
{
"mt35xu512aba", INFO(0x2c5b1a, 0, 128 * 1024, 512,
- SECT_4K | USE_FSR | SPI_NOR_4B_OPCODES)
+ SECT_4K | USE_FSR | SPI_NOR_OCTO_READ |
+ SPI_NOR_4B_OPCODES)
},
/* PMC */
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 5/7] mtd: m25p80: add support of octo mode I/O transfer
2018-10-23 9:37 [PATCH v3 0/7] spi: add support for octo mode Yogesh Narayan Gaur
` (3 preceding siblings ...)
2018-10-23 9:37 ` [PATCH v3 4/7] mtd: spi-nor: add octo read flag for flash mt35xu512aba Yogesh Narayan Gaur
@ 2018-10-23 9:37 ` Yogesh Narayan Gaur
2018-10-23 9:37 ` [PATCH v3 6/7] spi: nxp-fspi: add octo mode flag bit for octal support Yogesh Narayan Gaur
` (2 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Yogesh Narayan Gaur @ 2018-10-23 9:37 UTC (permalink / raw)
To: linux-mtd, boris.brezillon, broonie, marek.vasut, vigneshr,
linux-spi, devicetree
Cc: robh, mark.rutland, shawnguo, linux-arm-kernel,
computersforpeace, frieder.schrempf, linux-kernel,
Yogesh Narayan Gaur
Add support for octo mode I/O data transfer based on the controller (spi)
mode.
Assign hw-capability mask bits for octo transfer.
Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
---
Changes for v3:
- Modified string 'octal' with 'octo'.
Changes for v2:
- Incorporated review comments of Boris.
drivers/mtd/devices/m25p80.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index cb14cf9..7d5c3a1 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -175,7 +175,14 @@ static int m25p_probe(struct spi_mem *spimem)
spi_mem_set_drvdata(spimem, flash);
flash->spimem = spimem;
- if (spi->mode & SPI_RX_QUAD) {
+ if (spi->mode & SPI_RX_OCTO) {
+ hwcaps.mask |= SNOR_HWCAPS_READ_1_1_8;
+
+ if (spi->mode & SPI_TX_OCTO)
+ hwcaps.mask |= (SNOR_HWCAPS_READ_1_8_8 |
+ SNOR_HWCAPS_PP_1_1_8 |
+ SNOR_HWCAPS_PP_1_8_8);
+ } else if (spi->mode & SPI_RX_QUAD) {
hwcaps.mask |= SNOR_HWCAPS_READ_1_1_4;
if (spi->mode & SPI_TX_QUAD)
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 6/7] spi: nxp-fspi: add octo mode flag bit for octal support
2018-10-23 9:37 [PATCH v3 0/7] spi: add support for octo mode Yogesh Narayan Gaur
` (4 preceding siblings ...)
2018-10-23 9:37 ` [PATCH v3 5/7] mtd: m25p80: add support of octo mode I/O transfer Yogesh Narayan Gaur
@ 2018-10-23 9:37 ` Yogesh Narayan Gaur
2018-10-23 9:37 ` [PATCH v3 7/7] arm64: dts: lx2160a: update fspi node Yogesh Narayan Gaur
2018-11-13 8:00 ` [PATCH v3 0/7] spi: add support for octo mode Vignesh R
7 siblings, 0 replies; 12+ messages in thread
From: Yogesh Narayan Gaur @ 2018-10-23 9:37 UTC (permalink / raw)
To: linux-mtd, boris.brezillon, broonie, marek.vasut, vigneshr,
linux-spi, devicetree
Cc: robh, mark.rutland, shawnguo, linux-arm-kernel,
computersforpeace, frieder.schrempf, linux-kernel,
Yogesh Narayan Gaur
Add octo mode flags for octal I/O data transfer support.
NXP FlexSPI controller supports 8 lines Rx/Tx data transfer.
Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
---
Changes for v3:
- Modified string 'octal' with 'octo'.
Changes for v2:
- None
drivers/spi/spi-nxp-fspi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
index 67eea88..332b730 100644
--- a/drivers/spi/spi-nxp-fspi.c
+++ b/drivers/spi/spi-nxp-fspi.c
@@ -993,8 +993,8 @@ static int nxp_fspi_probe(struct platform_device *pdev)
if (!ctlr)
return -ENOMEM;
- ctlr->mode_bits = SPI_RX_DUAL | SPI_RX_QUAD |
- SPI_TX_DUAL | SPI_TX_QUAD;
+ ctlr->mode_bits = SPI_RX_DUAL | SPI_RX_QUAD | SPI_RX_OCTO |
+ SPI_TX_DUAL | SPI_TX_QUAD | SPI_TX_OCTO;
f = spi_controller_get_devdata(ctlr);
f->dev = dev;
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 7/7] arm64: dts: lx2160a: update fspi node
2018-10-23 9:37 [PATCH v3 0/7] spi: add support for octo mode Yogesh Narayan Gaur
` (5 preceding siblings ...)
2018-10-23 9:37 ` [PATCH v3 6/7] spi: nxp-fspi: add octo mode flag bit for octal support Yogesh Narayan Gaur
@ 2018-10-23 9:37 ` Yogesh Narayan Gaur
2018-11-13 8:00 ` [PATCH v3 0/7] spi: add support for octo mode Vignesh R
7 siblings, 0 replies; 12+ messages in thread
From: Yogesh Narayan Gaur @ 2018-10-23 9:37 UTC (permalink / raw)
To: linux-mtd, boris.brezillon, broonie, marek.vasut, vigneshr,
linux-spi, devicetree
Cc: robh, mark.rutland, shawnguo, linux-arm-kernel,
computersforpeace, frieder.schrempf, linux-kernel,
Yogesh Narayan Gaur
Flash mt35xu512aba connected to FlexSPI controller supports
1-1-8/1-8-8 protocol.
Added flag spi-rx-bus-width and spi-tx-bus-width with values as
8 and 8 respectively for both flashes connected at CS0 and CS1.
Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
---
Changes for v3:
- None
Changes for v2:
- None
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
index 3b20c97..24cc41c 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
@@ -45,6 +45,8 @@
m25p,fast-read;
spi-max-frequency = <20000000>;
reg = <0>;
+ spi-rx-bus-width = <8>;
+ spi-tx-bus-width = <8>;
};
mt35xu512aba1: flash@1 {
@@ -54,6 +56,8 @@
m25p,fast-read;
spi-max-frequency = <20000000>;
reg = <1>;
+ spi-rx-bus-width = <8>;
+ spi-tx-bus-width = <8>;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/7] spi: add support for octo mode I/O data transfer
2018-10-23 9:37 ` [PATCH v3 1/7] spi: add support for octo mode I/O data transfer Yogesh Narayan Gaur
@ 2018-10-23 9:48 ` Boris Brezillon
0 siblings, 0 replies; 12+ messages in thread
From: Boris Brezillon @ 2018-10-23 9:48 UTC (permalink / raw)
To: Yogesh Narayan Gaur
Cc: linux-mtd, broonie, marek.vasut, vigneshr, linux-spi, devicetree,
robh, mark.rutland, shawnguo, linux-arm-kernel,
computersforpeace, frieder.schrempf, linux-kernel
On Tue, 23 Oct 2018 09:37:06 +0000
Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote:
> Add flags for Octo mode I/O data transfer
> Required for the SPI controller which can do the data transfer (TX/RX)
> on 8 data lines e.g. NXP FlexSPI controller.
> SPI_TX_OCTO: transmit with 8 wires
> SPI_RX_OCTO: receive with 8 wires
>
> Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> Changes for v3:
> - Modified string 'octal' with 'octo'.
> - Add octo mode support in spi_setup().
> Changes for v2:
> - Incorporated review comments of Boris.
>
> drivers/spi/spi.c | 12 ++++++++++--
> include/linux/spi/spi.h | 2 ++
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index ec395a6..6d57fa7 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -1573,6 +1573,9 @@ static int of_spi_parse_dt(struct spi_controller *ctlr, struct spi_device *spi,
> case 4:
> spi->mode |= SPI_TX_QUAD;
> break;
> + case 8:
> + spi->mode |= SPI_TX_OCTO;
> + break;
> default:
> dev_warn(&ctlr->dev,
> "spi-tx-bus-width %d not supported\n",
> @@ -1591,6 +1594,9 @@ static int of_spi_parse_dt(struct spi_controller *ctlr, struct spi_device *spi,
> case 4:
> spi->mode |= SPI_RX_QUAD;
> break;
> + case 8:
> + spi->mode |= SPI_RX_OCTO;
> + break;
> default:
> dev_warn(&ctlr->dev,
> "spi-rx-bus-width %d not supported\n",
> @@ -2770,14 +2776,16 @@ int spi_setup(struct spi_device *spi)
> /* if it is SPI_3WIRE mode, DUAL and QUAD should be forbidden
> */
> if ((spi->mode & SPI_3WIRE) && (spi->mode &
> - (SPI_TX_DUAL | SPI_TX_QUAD | SPI_RX_DUAL | SPI_RX_QUAD)))
> + (SPI_TX_DUAL | SPI_TX_QUAD | SPI_TX_OCTO |
> + SPI_RX_DUAL | SPI_RX_QUAD | SPI_RX_OCTO)))
> return -EINVAL;
> /* help drivers fail *cleanly* when they need options
> * that aren't supported with their current controller
> */
> bad_bits = spi->mode & ~spi->controller->mode_bits;
> ugly_bits = bad_bits &
> - (SPI_TX_DUAL | SPI_TX_QUAD | SPI_RX_DUAL | SPI_RX_QUAD);
> + (SPI_TX_DUAL | SPI_TX_QUAD | SPI_TX_OCTO |
> + SPI_RX_DUAL | SPI_RX_QUAD | SPI_RX_OCTO);
> if (ugly_bits) {
> dev_warn(&spi->dev,
> "setup: ignoring unsupported mode bits %x\n",
> diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
> index a64235e..cea4e49 100644
> --- a/include/linux/spi/spi.h
> +++ b/include/linux/spi/spi.h
> @@ -163,6 +163,8 @@ struct spi_device {
> #define SPI_TX_QUAD 0x200 /* transmit with 4 wires */
> #define SPI_RX_DUAL 0x400 /* receive with 2 wires */
> #define SPI_RX_QUAD 0x800 /* receive with 4 wires */
> +#define SPI_TX_OCTO 0x1000 /* transmit with 8 wires */
> +#define SPI_RX_OCTO 0x2000 /* receive with 8 wires */
> int irq;
> void *controller_state;
> void *controller_data;
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/7] spi: spi-mem: add support for octo mode I/O data transfer
2018-10-23 9:37 ` [PATCH v3 2/7] spi: spi-mem: " Yogesh Narayan Gaur
@ 2018-10-23 9:49 ` Boris Brezillon
0 siblings, 0 replies; 12+ messages in thread
From: Boris Brezillon @ 2018-10-23 9:49 UTC (permalink / raw)
To: Yogesh Narayan Gaur
Cc: linux-mtd, broonie, marek.vasut, vigneshr, linux-spi, devicetree,
robh, mark.rutland, shawnguo, linux-arm-kernel,
computersforpeace, frieder.schrempf, linux-kernel
On Tue, 23 Oct 2018 09:37:13 +0000
Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote:
> Add support for octo mode I/O data transfer in spi-mem framework.
>
> Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> Changes for v3:
> - Modified string 'octal' with 'octo'.
> Changes for v2:
> - Patch added in v2 version.
>
> drivers/spi/spi-mem.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
> index c6bdea7..2379efc 100644
> --- a/drivers/spi/spi-mem.c
> +++ b/drivers/spi/spi-mem.c
> @@ -12,7 +12,7 @@
>
> #include "internals.h"
>
> -#define SPI_MEM_MAX_BUSWIDTH 4
> +#define SPI_MEM_MAX_BUSWIDTH 8
>
> /**
> * spi_controller_dma_map_mem_op_data() - DMA-map the buffer attached to a
> @@ -121,6 +121,13 @@ static int spi_check_buswidth_req(struct spi_mem *mem, u8 buswidth, bool tx)
>
> break;
>
> + case 8:
> + if ((tx && (mode & SPI_TX_OCTO)) ||
> + (!tx && (mode & SPI_RX_OCTO)))
> + return 0;
> +
> + break;
> +
> default:
> break;
> }
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 0/7] spi: add support for octo mode
2018-10-23 9:37 [PATCH v3 0/7] spi: add support for octo mode Yogesh Narayan Gaur
` (6 preceding siblings ...)
2018-10-23 9:37 ` [PATCH v3 7/7] arm64: dts: lx2160a: update fspi node Yogesh Narayan Gaur
@ 2018-11-13 8:00 ` Vignesh R
2018-11-22 5:19 ` Yogesh Narayan Gaur
7 siblings, 1 reply; 12+ messages in thread
From: Vignesh R @ 2018-11-13 8:00 UTC (permalink / raw)
To: Yogesh Narayan Gaur, linux-mtd, boris.brezillon, broonie,
marek.vasut, linux-spi, devicetree
Cc: robh, mark.rutland, shawnguo, linux-arm-kernel,
computersforpeace, frieder.schrempf, linux-kernel
Hi Yogesh
On 23/10/18 3:07 PM, Yogesh Narayan Gaur wrote:
> Add support for octo mode IO data transfer.
> Micron flash, mt35xu512aba, supports octal mode data transfer and
> NXP FlexSPI controller supports 8 data lines for data transfer (Rx/Tx).
>
> Patch series
> * Add support for octo mode flags and parsing of same in spi driver.
> * Add parsing logic for spi-mem framework and m25p80.c device file.
> * Add opcodes for octo I/O commands in spi-nor framework, Read and Write proto for (1-1-8/1-8-8) mode.
> Opcodes are added as per octal data IO commands required for mt35xu512aba [1] flash.
> * Add mode bit required for octo mode in nxp-fspi driver [2].
> * Define binding property 'spi-rx/tx-bus-width' for LX2160ARDB target [2].
>
You may have to rebase this series to avoid conflicts with recent spi.h
changes. Also, I suggest merging patches in [1] with this series if you
plan to post another version so that all bits are at one place.
Regards
Vignesh
> Cherry pick below 2 patches (from: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git):
> c639f871febe6667d9afce28108c634e5636c735 spi: spi-mem: Fix inverted logic in op sanity check
> db122eb8a749a1eff038f9a282c620ab16c4be1d spi: spi-mem: Add extra sanity checks on the op param
>
> Tested on LX2160ARDB target with nxp-fspi driver, below are
> Read performance number of 1-1-1 and 1-1-8 read protocol.
>
> root@lxxx:~# cat /proc/mtd
> dev: size erasesize name
> mtd0: 04000000 00001000 "spi0.0"
> mtd1: 04000000 00001000 "spi0.1"
> root@lxxx:~# time mtd_debug read /dev/mtd0 0x0 0x1000000 0read
> Copied 16777216 bytes from address 0x00000000 in flash to 0read
>
> real 0m2.792s
> user 0m0.000s
> sys 0m2.790s
> root@lxxx:~# time mtd_debug read /dev/mtd1 0x0 0x1000000 0read
> Copied 16777216 bytes from address 0x00000000 in flash to 0read
>
> real 0m0.441s
> user 0m0.000s
> sys 0m0.440s
> root@ls1012ardb:~#
>
> Flash device MTD0 configured in 1-1-1 protocol.
> Flash device MTD1 configured in 1-1-8 protocol.
>
> [1] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=70384
> [2] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=72181
>
> Yogesh Gaur (7):
> spi: add support for octo mode I/O data transfer
> spi: spi-mem: add support for octo mode I/O data transfer
> mtd: spi-nor: add opcodes for octo Read/Write commands
> mtd: spi-nor: add octo read flag for flash mt35xu512aba
> mtd: m25p80: add support of octo mode I/O transfer
> spi: nxp-fspi: add octo mode flag bit for octal support
> arm64: dts: lx2160a: update fspi node
>
> Changes for v3:
> - Add octo mode support in spi_setup().
> - Rename all patches with 'octal' string modified as 'octo'.
> Changes for v2:
> - Incorporated review comments of Boris and Vignesh.
>
> arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 4 ++++
> drivers/mtd/devices/m25p80.c | 9 ++++++++-
> drivers/mtd/spi-nor/spi-nor.c | 15 ++++++++++++++-
> drivers/spi/spi-mem.c | 9 ++++++++-
> drivers/spi/spi-nxp-fspi.c | 4 ++--
> drivers/spi/spi.c | 12 ++++++++++--
> include/linux/mtd/spi-nor.h | 8 ++++++++
> include/linux/spi/spi.h | 2 ++
> 8 files changed, 56 insertions(+), 7 deletions(-)
>
--
Regards
Vignesh
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH v3 0/7] spi: add support for octo mode
2018-11-13 8:00 ` [PATCH v3 0/7] spi: add support for octo mode Vignesh R
@ 2018-11-22 5:19 ` Yogesh Narayan Gaur
0 siblings, 0 replies; 12+ messages in thread
From: Yogesh Narayan Gaur @ 2018-11-22 5:19 UTC (permalink / raw)
To: Vignesh R, linux-mtd, boris.brezillon, broonie, marek.vasut,
linux-spi, devicetree
Cc: robh, mark.rutland, shawnguo, linux-arm-kernel,
computersforpeace, frieder.schrempf, linux-kernel
Hi Vignesh,
> -----Original Message-----
> From: Vignesh R [mailto:vigneshr@ti.com]
> Sent: Tuesday, November 13, 2018 1:30 PM
> To: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>; linux-
> mtd@lists.infradead.org; boris.brezillon@bootlin.com; broonie@kernel.org;
> marek.vasut@gmail.com; linux-spi@vger.kernel.org;
> devicetree@vger.kernel.org
> Cc: robh@kernel.org; mark.rutland@arm.com; shawnguo@kernel.org; linux-
> arm-kernel@lists.infradead.org; computersforpeace@gmail.com;
> frieder.schrempf@exceet.de; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3 0/7] spi: add support for octo mode
>
> Hi Yogesh
>
> On 23/10/18 3:07 PM, Yogesh Narayan Gaur wrote:
> > Add support for octo mode IO data transfer.
> > Micron flash, mt35xu512aba, supports octal mode data transfer and NXP
> > FlexSPI controller supports 8 data lines for data transfer (Rx/Tx).
> >
> > Patch series
> > * Add support for octo mode flags and parsing of same in spi driver.
> > * Add parsing logic for spi-mem framework and m25p80.c device file.
> > * Add opcodes for octo I/O commands in spi-nor framework, Read and Write
> proto for (1-1-8/1-8-8) mode.
> > Opcodes are added as per octal data IO commands required for
> mt35xu512aba [1] flash.
> > * Add mode bit required for octo mode in nxp-fspi driver [2].
> > * Define binding property 'spi-rx/tx-bus-width' for LX2160ARDB target [2].
> >
>
> You may have to rebase this series to avoid conflicts with recent spi.h changes.
Done, have send the next version with rebase on top of v4.20-rc2 [1] and resolving conflict with spi.h changes.
> Also, I suggest merging patches in [1] with this series if you plan to post another
> version so that all bits are at one place.
Patches for addition of the flash property has already been accepted.
--
Regards
Yogesh Gaur.
[1] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=77394
>
> Regards
> Vignesh
>
[...]
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-11-22 5:19 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-23 9:37 [PATCH v3 0/7] spi: add support for octo mode Yogesh Narayan Gaur
2018-10-23 9:37 ` [PATCH v3 1/7] spi: add support for octo mode I/O data transfer Yogesh Narayan Gaur
2018-10-23 9:48 ` Boris Brezillon
2018-10-23 9:37 ` [PATCH v3 2/7] spi: spi-mem: " Yogesh Narayan Gaur
2018-10-23 9:49 ` Boris Brezillon
2018-10-23 9:37 ` [PATCH v3 3/7] mtd: spi-nor: add opcodes for octo Read/Write commands Yogesh Narayan Gaur
2018-10-23 9:37 ` [PATCH v3 4/7] mtd: spi-nor: add octo read flag for flash mt35xu512aba Yogesh Narayan Gaur
2018-10-23 9:37 ` [PATCH v3 5/7] mtd: m25p80: add support of octo mode I/O transfer Yogesh Narayan Gaur
2018-10-23 9:37 ` [PATCH v3 6/7] spi: nxp-fspi: add octo mode flag bit for octal support Yogesh Narayan Gaur
2018-10-23 9:37 ` [PATCH v3 7/7] arm64: dts: lx2160a: update fspi node Yogesh Narayan Gaur
2018-11-13 8:00 ` [PATCH v3 0/7] spi: add support for octo mode Vignesh R
2018-11-22 5:19 ` Yogesh Narayan Gaur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).