From: Mark Brown <broonie@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, orsonzhai@gmail.com,
zhang.lyra@gmail.com, lanqing.liu@unisoc.com,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] spi: sprd: spi: sprd: Add DMA mode support
Date: Wed, 13 Feb 2019 12:20:12 +0000 [thread overview]
Message-ID: <20190213122012.GE7540@sirena.org.uk> (raw)
In-Reply-To: <3f9d23d4b250c5046f8c3411606aa9ffe807edd8.1550043082.git.baolin.wang@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
On Wed, Feb 13, 2019 at 03:36:11PM +0800, Baolin Wang wrote:
> +enum sprd_spi_dma_channel {
> + SPI_RX,
> + SPI_TX,
> + SPI_MAX,
> +};
It'd have been better to namespace these (SPRD_SPI_ or something) in
case of conflicts. That's really minor though and everything else looks
good so I'll go ahead and apply, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-13 12:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 7:36 [PATCH v2 1/3] spi: sprd: Add the SPI irq function for the SPI DMA mode Baolin Wang
2019-02-13 7:36 ` [PATCH v2 2/3] dt-bindings: spi: Add the DMA properties for the SPI dma mode Baolin Wang
2019-02-13 12:31 ` Applied "dt-bindings: spi: Add the DMA properties for the SPI dma mode" to the spi tree Mark Brown
2019-02-18 14:02 ` [PATCH v2 2/3] dt-bindings: spi: Add the DMA properties for the SPI dma mode Rob Herring
2019-02-19 4:37 ` Baolin Wang
2019-02-13 7:36 ` [PATCH v2 3/3] spi: sprd: spi: sprd: Add DMA mode support Baolin Wang
2019-02-13 12:20 ` Mark Brown [this message]
2019-02-13 12:35 ` Baolin Wang
2019-02-13 12:31 ` Applied "spi: sprd: spi: sprd: Add DMA mode support" to the spi tree Mark Brown
2019-02-13 12:31 ` Applied "spi: sprd: Add the SPI irq function for the SPI DMA mode" " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213122012.GE7540@sirena.org.uk \
--to=broonie@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lanqing.liu@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).