From: Rob Herring <robh+dt@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Orson Zhai <orsonzhai@gmail.com>,
Lyra Zhang <zhang.lyra@gmail.com>,
lanqing.liu@unisoc.com, linux-spi <linux-spi@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: spi: Add the DMA properties for the SPI dma mode
Date: Mon, 18 Feb 2019 08:02:06 -0600 [thread overview]
Message-ID: <CAL_JsqK+x+XgxSn7ks84_JZxTkpQ-irFBmRc3tp3zsfUcHUPpg@mail.gmail.com> (raw)
In-Reply-To: <2be9d6de92507e5886433fb2cd55117c63b63d72.1550043082.git.baolin.wang@linaro.org>
On Wed, Feb 13, 2019 at 1:37 AM Baolin Wang <baolin.wang@linaro.org> wrote:
>
> From: Lanqing Liu <lanqing.liu@unisoc.com>
>
> Add the DMA properties for the SPI dma mode.
>
> Signed-off-by: Lanqing Liu <lanqing.liu@unisoc.com>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
> Changes from v1:
> - Remove sprd,dma-slave-ids property.
> ---
> Documentation/devicetree/bindings/spi/spi-sprd.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-sprd.txt b/Documentation/devicetree/bindings/spi/spi-sprd.txt
> index bad211a..3c7eacc 100644
> --- a/Documentation/devicetree/bindings/spi/spi-sprd.txt
> +++ b/Documentation/devicetree/bindings/spi/spi-sprd.txt
> @@ -14,6 +14,11 @@ Required properties:
> address on the SPI bus. Should be set to 1.
> - #size-cells: Should be set to 0.
>
> +Optional properties:
> +dma-names: Should contain names of the SPI used DMA channel.
> +dmas: Should contain DMA channels and DMA slave ids which the SPI used
> + sorted in the same order as the dma-names property.
These need to define the order and names.
> +
> Example:
> spi0: spi@70a00000{
> compatible = "sprd,sc9860-spi";
> @@ -21,6 +26,8 @@ spi0: spi@70a00000{
> interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> clock-names = "spi", "source","enable";
> clocks = <&clk_spi0>, <&ext_26m>, <&clk_ap_apb_gates 5>;
> + dma-names = "rx_chn", "tx_chn";
Everyone else uses "rx" and "tx". Do you really need something different?
> + dmas = <&apdma 11 11>, <&apdma 12 12>;
> #address-cells = <1>;
> #size-cells = <0>;
> };
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2019-02-18 14:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 7:36 [PATCH v2 1/3] spi: sprd: Add the SPI irq function for the SPI DMA mode Baolin Wang
2019-02-13 7:36 ` [PATCH v2 2/3] dt-bindings: spi: Add the DMA properties for the SPI dma mode Baolin Wang
2019-02-13 12:31 ` Applied "dt-bindings: spi: Add the DMA properties for the SPI dma mode" to the spi tree Mark Brown
2019-02-18 14:02 ` Rob Herring [this message]
2019-02-19 4:37 ` [PATCH v2 2/3] dt-bindings: spi: Add the DMA properties for the SPI dma mode Baolin Wang
2019-02-13 7:36 ` [PATCH v2 3/3] spi: sprd: spi: sprd: Add DMA mode support Baolin Wang
2019-02-13 12:20 ` Mark Brown
2019-02-13 12:35 ` Baolin Wang
2019-02-13 12:31 ` Applied "spi: sprd: spi: sprd: Add DMA mode support" to the spi tree Mark Brown
2019-02-13 12:31 ` Applied "spi: sprd: Add the SPI irq function for the SPI DMA mode" " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqK+x+XgxSn7ks84_JZxTkpQ-irFBmRc3tp3zsfUcHUPpg@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lanqing.liu@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).