From: Wei Yongjun <weiyongjun1@huawei.com>
To: Mark Brown <broonie@kernel.org>,
Palmer Dabbelt <palmer@sifive.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>
Cc: kernel-janitors@vger.kernel.org, linux-riscv@lists.infradead.org,
Wei Yongjun <weiyongjun1@huawei.com>,
linux-spi@vger.kernel.org
Subject: [PATCH -next] spi: sifive: Remove redundant dev_err call in sifive_spi_probe()
Date: Fri, 22 Feb 2019 05:46:32 +0000 [thread overview]
Message-ID: <20190222054632.4610-1-weiyongjun1@huawei.com> (raw)
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/spi/spi-sifive.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/spi-sifive.c b/drivers/spi/spi-sifive.c
index 961307c4a613..81c5a0363073 100644
--- a/drivers/spi/spi-sifive.c
+++ b/drivers/spi/spi-sifive.c
@@ -310,7 +310,6 @@ static int sifive_spi_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
spi->regs = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(spi->regs)) {
- dev_err(&pdev->dev, "Unable to map IO resources\n");
ret = PTR_ERR(spi->regs);
goto put_master;
}
next reply other threads:[~2019-02-22 5:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 5:46 Wei Yongjun [this message]
2019-02-26 12:07 ` Applied "spi: sifive: Remove redundant dev_err call in sifive_spi_probe()" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222054632.4610-1-weiyongjun1@huawei.com \
--to=weiyongjun1@huawei.com \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).