* [PATCH -next] spi: sifive: Remove redundant dev_err call in sifive_spi_probe()
@ 2019-02-22 5:46 Wei Yongjun
2019-02-26 12:07 ` Applied "spi: sifive: Remove redundant dev_err call in sifive_spi_probe()" to the spi tree Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2019-02-22 5:46 UTC (permalink / raw)
To: Mark Brown, Palmer Dabbelt, Paul Walmsley
Cc: kernel-janitors, linux-riscv, Wei Yongjun, linux-spi
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/spi/spi-sifive.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/spi-sifive.c b/drivers/spi/spi-sifive.c
index 961307c4a613..81c5a0363073 100644
--- a/drivers/spi/spi-sifive.c
+++ b/drivers/spi/spi-sifive.c
@@ -310,7 +310,6 @@ static int sifive_spi_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
spi->regs = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(spi->regs)) {
- dev_err(&pdev->dev, "Unable to map IO resources\n");
ret = PTR_ERR(spi->regs);
goto put_master;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Applied "spi: sifive: Remove redundant dev_err call in sifive_spi_probe()" to the spi tree
2019-02-22 5:46 [PATCH -next] spi: sifive: Remove redundant dev_err call in sifive_spi_probe() Wei Yongjun
@ 2019-02-26 12:07 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2019-02-26 12:07 UTC (permalink / raw)
To: Wei Yongjun
Cc: Palmer Dabbelt, kernel-janitors, linux-spi, Mark Brown,
Paul Walmsley, linux-riscv
The patch
spi: sifive: Remove redundant dev_err call in sifive_spi_probe()
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From daad4d2a0a60b0b2879e66194100b43c41e96ca9 Mon Sep 17 00:00:00 2001
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Fri, 22 Feb 2019 05:46:32 +0000
Subject: [PATCH] spi: sifive: Remove redundant dev_err call in
sifive_spi_probe()
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-sifive.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/spi-sifive.c b/drivers/spi/spi-sifive.c
index ebca3fc4d345..93ec2c6cdbfd 100644
--- a/drivers/spi/spi-sifive.c
+++ b/drivers/spi/spi-sifive.c
@@ -310,7 +310,6 @@ static int sifive_spi_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
spi->regs = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(spi->regs)) {
- dev_err(&pdev->dev, "Unable to map IO resources\n");
ret = PTR_ERR(spi->regs);
goto put_master;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-26 12:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-22 5:46 [PATCH -next] spi: sifive: Remove redundant dev_err call in sifive_spi_probe() Wei Yongjun
2019-02-26 12:07 ` Applied "spi: sifive: Remove redundant dev_err call in sifive_spi_probe()" to the spi tree Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).