Linux-SPI Archive on
 help / color / Atom feed
From: Michael Walle <>
Cc: Yogesh Gaur <>,
	Ashish Kumar <>,
	Mark Brown <>, Michael Walle <>
Subject: [PATCH] spi: nxp-fspi: Ensure width is respected in spi-mem operations
Date: Wed, 11 Dec 2019 20:57:30 +0100
Message-ID: <> (raw)

Make use of a core helper to ensure the desired width is respected
when calling spi-mem operators.

Otherwise only the SPI controller will be matched with the flash chip,
which might lead to wrong widths. Also consider the width specified by
the user in the device tree.

Fixes: a5356aef6a90 ("spi: spi-mem: Add driver for NXP FlexSPI controller")
Signed-off-by: Michael Walle <>
 drivers/spi/spi-nxp-fspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
index c36bb1bb464e..8c5084a3a617 100644
--- a/drivers/spi/spi-nxp-fspi.c
+++ b/drivers/spi/spi-nxp-fspi.c
@@ -439,7 +439,7 @@ static bool nxp_fspi_supports_op(struct spi_mem *mem,
 	    op->data.nbytes > f->devtype_data->txfifo)
 		return false;
-	return true;
+	return spi_mem_default_supports_op(mem, op);
 /* Instead of busy looping invoke readl_poll_timeout functionality. */

             reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 19:57 Michael Walle [this message]
2019-12-16 12:06 ` Applied "spi: nxp-fspi: Ensure width is respected in spi-mem operations" to the spi tree Mark Brown
2020-01-07  5:39 ` [EXT] [PATCH] spi: nxp-fspi: Ensure width is respected in spi-mem operations Kuldeep Singh
2020-01-07  8:32   ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-SPI Archive on

Archives are clonable:
	git clone --mirror linux-spi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spi linux-spi/ \
	public-inbox-index linux-spi

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone