linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Kuldeep Singh <kuldeep.singh@nxp.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yogesh Gaur <yogeshgaur.83@gmail.com>,
	Ashish Kumar <ashish.kumar@nxp.com>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [EXT] [PATCH] spi: nxp-fspi: Ensure width is respected in spi-mem operations
Date: Tue, 07 Jan 2020 09:32:15 +0100	[thread overview]
Message-ID: <650f957c95e2ee99db646fe620268ff9@walle.cc> (raw)
In-Reply-To: <AM0PR0402MB3556E16D1027FB5D6C3FDC88E03F0@AM0PR0402MB3556.eurprd04.prod.outlook.com>

Am 2020-01-07 06:39, schrieb Kuldeep Singh:
> Hi Michael,
> 
>> -----Original Message-----
>> From: linux-kernel-owner@vger.kernel.org <linux-kernel-
>> owner@vger.kernel.org> On Behalf Of Michael Walle
>> Sent: Thursday, December 12, 2019 1:28 AM
>> To: linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org
>> Cc: Yogesh Gaur <yogeshgaur.83@gmail.com>; Ashish Kumar
>> <ashish.kumar@nxp.com>; Mark Brown <broonie@kernel.org>; Michael
>> Walle <michael@walle.cc>
>> Subject: [EXT] [PATCH] spi: nxp-fspi: Ensure width is respected in 
>> spi-mem
>> operations
>> 
>> Caution: EXT Email
>> 
>> Make use of a core helper to ensure the desired width is respected 
>> when
>> calling spi-mem operators.
>> 
>> Otherwise only the SPI controller will be matched with the flash chip, 
>> which
>> might lead to wrong widths. Also consider the width specified by the 
>> user in
>> the device tree.
> 
> Could you please mention the flash and modes you tested. Does it
> support DUAL/QUAD mode?
> I couldn't test these modes as NXP LS1028ARDB has "mt35xu02g" which
> supports SINGLE and OCTAL modes only.

That commit is already upstream. But FWIW, it was a Winbond W25Q32FW in 
dual i/o mode.

-michael

      reply	other threads:[~2020-01-07  8:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 19:57 [PATCH] spi: nxp-fspi: Ensure width is respected in spi-mem operations Michael Walle
2019-12-16 12:06 ` Applied "spi: nxp-fspi: Ensure width is respected in spi-mem operations" to the spi tree Mark Brown
2020-01-07  5:39 ` [EXT] [PATCH] spi: nxp-fspi: Ensure width is respected in spi-mem operations Kuldeep Singh
2020-01-07  8:32   ` Michael Walle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=650f957c95e2ee99db646fe620268ff9@walle.cc \
    --to=michael@walle.cc \
    --cc=ashish.kumar@nxp.com \
    --cc=broonie@kernel.org \
    --cc=kuldeep.singh@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=yogeshgaur.83@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).