From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Konrad Kociolek <konrad-vna1KIf7WgpBDgjK7y7TUQ@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 1/2] Add Cadence XSPI driver
Date: Thu, 20 Feb 2020 11:40:49 +0000 [thread overview]
Message-ID: <20200220114048.GA3926@sirena.org.uk> (raw)
In-Reply-To: <20200220082354.GA15619-3ZcXq++oLud4Zxsjz0bX7NBPR1lH4CV8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
On Thu, Feb 20, 2020 at 09:23:56AM +0100, Konrad Kociolek wrote:
> The 02/10/2020 19:16, Mark Brown wrote:
> > > # Add new SPI master controllers in alphabetical order above this line
> > Please keep Kconfig and Makefile alphabetically sorted as the comment in
> > the context from the diff says. :/
> What I see is Kconfig is first and Makefile is second file in diff,
> according to:
> drivers/spi/Kconfig | 11 +
> drivers/spi/Makefile | 1 +
> Is that wrong?
Please keep the *contents* of the files Kconfig and Makefile
alphabetically sorted as the comment in the context from the diff says.
> > > +#ifdef CONFIG_OF
> > > +static const struct of_device_id cdns_xspi_of_match[] = {
> > > + {
> > > + .compatible = "cdns,xspi-nor-fpga",
> > > + },
> > Why -fpga?
> This is because this driver was tested only on FPGA board.
> This driver was not tested for ASIC version as PHY
> initialization algorithm is differ.
So there will need to be a separate compatible for any silicon
integrations? Will that always be the same for all silicon integrations
or should we have properties for the PHY type?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-02-20 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 12:41 [PATCH v2 1/2] Add Cadence XSPI driver Konrad Kociolek
[not found] ` <20200128124212.12298-1-konrad-vna1KIf7WgpBDgjK7y7TUQ@public.gmane.org>
2020-02-10 19:16 ` Mark Brown
[not found] ` <20200210191620.GE14166-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2020-02-20 8:23 ` Konrad Kociolek
[not found] ` <20200220082354.GA15619-3ZcXq++oLud4Zxsjz0bX7NBPR1lH4CV8@public.gmane.org>
2020-02-20 11:40 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220114048.GA3926@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=konrad-vna1KIf7WgpBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).