[PATCH v1] spi: dw: Replace dma_request_slave_channel() with dma_request_chan()

[PATCH v1] spi: dw: Replace dma_request_slave_channel() with dma_request_chan()

[Andy Shevchenko]

Drivers should use dma_request_chan() instead of dma_request_slave_channel().

dma_request_slave_channel() is a simple wrapper for dma_request_chan() eating
up the error code for channel request failure and makes deferred probing
impossible.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/spi/spi-dw-dma.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-dw-dma.c b/drivers/spi/spi-dw-dma.c
index bb390ff67d1d..afc2f11a3473 100644
--- a/drivers/spi/spi-dw-dma.c
+++ b/drivers/spi/spi-dw-dma.c
@@ -107,11 +107,11 @@ static int dw_spi_dma_init_mfld(struct device *dev, struct dw_spi *dws)
 
 static int dw_spi_dma_init_generic(struct device *dev, struct dw_spi *dws)
 {
-	dws->rxchan = dma_request_slave_channel(dev, "rx");
+	dws->rxchan = dma_request_chan(dev, "rx");
 	if (!dws->rxchan)
 		return -ENODEV;
 
-	dws->txchan = dma_request_slave_channel(dev, "tx");
+	dws->txchan = dma_request_chan(dev, "tx");
 	if (!dws->txchan) {
 		dma_release_channel(dws->rxchan);
 		dws->rxchan = NULL;
-- 
2.28.0

Re: [PATCH v1] spi: dw: Replace dma_request_slave_channel() with dma_request_chan()

[Andy Shevchenko]

On Fri, Aug 28, 2020 at 04:58:18PM +0300, Andy Shevchenko wrote:
> Drivers should use dma_request_chan() instead of dma_request_slave_channel().
> 
> dma_request_slave_channel() is a simple wrapper for dma_request_chan() eating
> up the error code for channel request failure and makes deferred probing
> impossible.

It's not fully correct change.

-- 
With Best Regards,
Andy Shevchenko