* [PATCH] spi: spi-au1550: pr_err instead of printk
@ 2021-01-23 3:03 corentin noel
2021-01-25 13:02 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: corentin noel @ 2021-01-23 3:03 UTC (permalink / raw)
To: broonie; +Cc: linux-spi, linux-kernel, corentin noel
Signed-off-by: corentin noel <corentin.noel56@gmail.com>
---
drivers/spi/spi-au1550.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/spi/spi-au1550.c b/drivers/spi/spi-au1550.c
index dfb7196f4caf..8f92bbdf391b 100644
--- a/drivers/spi/spi-au1550.c
+++ b/drivers/spi/spi-au1550.c
@@ -972,8 +972,7 @@ static int __init au1550_spi_init(void)
if (usedma) {
ddma_memid = au1xxx_ddma_add_device(&au1550_spi_mem_dbdev);
if (!ddma_memid)
- printk(KERN_ERR "au1550-spi: cannot add memory"
- "dbdma device\n");
+ pr_err("au1550-spi: cannot add memory dbdma device\n");
}
return platform_driver_register(&au1550_spi_drv);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi: spi-au1550: pr_err instead of printk
2021-01-23 3:03 [PATCH] spi: spi-au1550: pr_err instead of printk corentin noel
@ 2021-01-25 13:02 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2021-01-25 13:02 UTC (permalink / raw)
To: corentin noel; +Cc: linux-spi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
On Sat, Jan 23, 2021 at 04:03:44AM +0100, corentin noel wrote:
> Signed-off-by: corentin noel <corentin.noel56@gmail.com>
This doesn't apply against current code, please check and resend. It
should apply against my tree which already has your previous patches
including the one which
> if (!ddma_memid)
> - printk(KERN_ERR "au1550-spi: cannot add memory"
> - "dbdma device\n");
> + pr_err("au1550-spi: cannot add memory dbdma device\n");
merged this onto a single line.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-26 3:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-23 3:03 [PATCH] spi: spi-au1550: pr_err instead of printk corentin noel
2021-01-25 13:02 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).