From: Mark Brown <broonie@kernel.org>
To: Jay Fang <f.fangjian@huawei.com>
Cc: linux-spi@vger.kernel.org, huangdaode@huawei.com, linuxarm@huawei.com
Subject: Re: [PATCH V2] spi: Add HiSilicon SPI Controller Driver for Kunpeng SoCs
Date: Thu, 18 Mar 2021 13:28:21 +0000 [thread overview]
Message-ID: <20210318132821.GH5469@sirena.org.uk> (raw)
In-Reply-To: <1616061024-57818-1-git-send-email-f.fangjian@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Thu, Mar 18, 2021 at 05:50:24PM +0800, Jay Fang wrote:
> Changes in v2:
> - Use a more specific name (Kunpeng SoCs) for this driver.
> drivers/spi/spi-hisi.c | 505 +++++++++++++++++++++++++++++++++++++++++++++++++
> +config SPI_HISI
> + tristate "HiSilicon SPI Controller for Kunpeng SoCs"
You've changed the display name for the driver but the Kconfig symbol
and filename are still very generic - can you update them as well
please?
Otherwise this looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-18 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 9:50 [PATCH V2] spi: Add HiSilicon SPI Controller Driver for Kunpeng SoCs Jay Fang
2021-03-18 13:28 ` Mark Brown [this message]
2021-03-20 9:44 ` Jay Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318132821.GH5469@sirena.org.uk \
--to=broonie@kernel.org \
--cc=f.fangjian@huawei.com \
--cc=huangdaode@huawei.com \
--cc=linux-spi@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).