From: Mark Brown <broonie@kernel.org>
To: Jay Fang <f.fangjian@huawei.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Wei Xu <xuwei5@hisilicon.com>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, huangdaode@huawei.com
Subject: Re: [PATCH] spi: SPI_HISI_KUNPENG should depend on ARCH_HISI
Date: Tue, 13 Apr 2021 14:09:39 +0100 [thread overview]
Message-ID: <20210413130939.GF5586@sirena.org.uk> (raw)
In-Reply-To: <46a47db2-338e-2ca4-0eac-c2b129ee7b7d@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
On Tue, Apr 13, 2021 at 08:59:02PM +0800, Jay Fang wrote:
> On 2021/4/13 20:47, Mark Brown wrote:
> > On Tue, Apr 13, 2021 at 02:27:23PM +0200, Geert Uytterhoeven wrote:
> >> The HiSilicon Kunpeng SPI controller is only present on HiSilicon
> >> Kunpeng SoCs. Hence add a dependency on ARCH_HISI, to prevent asking
> >> the user about this driver when configuring a kernel without Hisilicon
> >> platform support.
> > Are you *sure* about this? HiSilicon produce a wide range of SoCs with
> > very diverse target markets, this driver looks like it's for enterprise
> > stuff while most things guarded by that config option look like they're
> > for embedded applications.
> SPI_HISI_KUNPENG does not depend on ARCH_HISI.
Right, but that's what Geert is proposing to change - the question is
does it make sense to do so or not?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-04-13 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 12:27 [PATCH] spi: SPI_HISI_KUNPENG should depend on ARCH_HISI Geert Uytterhoeven
2021-04-13 12:47 ` Mark Brown
2021-04-13 12:59 ` Jay Fang
2021-04-13 13:09 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413130939.GF5586@sirena.org.uk \
--to=broonie@kernel.org \
--cc=f.fangjian@huawei.com \
--cc=geert+renesas@glider.be \
--cc=huangdaode@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).