Linux-SPI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] spi: SPI_HISI_KUNPENG should depend on ARCH_HISI
@ 2021-04-13 12:27 Geert Uytterhoeven
  2021-04-13 12:47 ` Mark Brown
  0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-04-13 12:27 UTC (permalink / raw)
  To: Jay Fang, Wei Xu, Mark Brown
  Cc: linux-spi, linux-arm-kernel, linux-kernel, Geert Uytterhoeven

The HiSilicon Kunpeng SPI controller is only present on HiSilicon
Kunpeng SoCs.  Hence add a dependency on ARCH_HISI, to prevent asking
the user about this driver when configuring a kernel without Hisilicon
platform support.

Fixes: c770d8631e1810d8 ("spi: Add HiSilicon SPI Controller Driver for Kunpeng SoCs")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 1ffcad19c0562a39..7d438ad343598bb8 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -334,7 +334,7 @@ config SPI_FSL_QUADSPI
 
 config SPI_HISI_KUNPENG
 	tristate "HiSilicon SPI Controller for Kunpeng SoCs"
-	depends on (ARM64 && ACPI) || COMPILE_TEST
+	depends on (ARM64 && ARCH_HISI && ACPI) || COMPILE_TEST
 	help
 	  This enables support for HiSilicon SPI controller found on
 	  Kunpeng SoCs.
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] spi: SPI_HISI_KUNPENG should depend on ARCH_HISI
  2021-04-13 12:27 [PATCH] spi: SPI_HISI_KUNPENG should depend on ARCH_HISI Geert Uytterhoeven
@ 2021-04-13 12:47 ` Mark Brown
  2021-04-13 12:59   ` Jay Fang
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2021-04-13 12:47 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Jay Fang, Wei Xu, linux-spi, linux-arm-kernel, linux-kernel


[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

On Tue, Apr 13, 2021 at 02:27:23PM +0200, Geert Uytterhoeven wrote:
> The HiSilicon Kunpeng SPI controller is only present on HiSilicon
> Kunpeng SoCs.  Hence add a dependency on ARCH_HISI, to prevent asking
> the user about this driver when configuring a kernel without Hisilicon
> platform support.

Are you *sure* about this?  HiSilicon produce a wide range of SoCs with
very diverse target markets, this driver looks like it's for enterprise
stuff while most things guarded by that config option look like they're
for embedded applications.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] spi: SPI_HISI_KUNPENG should depend on ARCH_HISI
  2021-04-13 12:47 ` Mark Brown
@ 2021-04-13 12:59   ` Jay Fang
  2021-04-13 13:09     ` Mark Brown
  0 siblings, 1 reply; 4+ messages in thread
From: Jay Fang @ 2021-04-13 12:59 UTC (permalink / raw)
  To: Mark Brown, Geert Uytterhoeven
  Cc: Wei Xu, linux-spi, linux-arm-kernel, linux-kernel, huangdaode

On 2021/4/13 20:47, Mark Brown wrote:
> On Tue, Apr 13, 2021 at 02:27:23PM +0200, Geert Uytterhoeven wrote:
>> The HiSilicon Kunpeng SPI controller is only present on HiSilicon
>> Kunpeng SoCs.  Hence add a dependency on ARCH_HISI, to prevent asking
>> the user about this driver when configuring a kernel without Hisilicon
>> platform support.
> 
> Are you *sure* about this?  HiSilicon produce a wide range of SoCs with
> very diverse target markets, this driver looks like it's for enterprise
> stuff while most things guarded by that config option look like they're
> for embedded applications.
SPI_HISI_KUNPENG does not depend on ARCH_HISI.


Thanks,
Jay




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] spi: SPI_HISI_KUNPENG should depend on ARCH_HISI
  2021-04-13 12:59   ` Jay Fang
@ 2021-04-13 13:09     ` Mark Brown
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-04-13 13:09 UTC (permalink / raw)
  To: Jay Fang
  Cc: Geert Uytterhoeven, Wei Xu, linux-spi, linux-arm-kernel,
	linux-kernel, huangdaode


[-- Attachment #1: Type: text/plain, Size: 833 bytes --]

On Tue, Apr 13, 2021 at 08:59:02PM +0800, Jay Fang wrote:
> On 2021/4/13 20:47, Mark Brown wrote:
> > On Tue, Apr 13, 2021 at 02:27:23PM +0200, Geert Uytterhoeven wrote:

> >> The HiSilicon Kunpeng SPI controller is only present on HiSilicon
> >> Kunpeng SoCs.  Hence add a dependency on ARCH_HISI, to prevent asking
> >> the user about this driver when configuring a kernel without Hisilicon
> >> platform support.

> > Are you *sure* about this?  HiSilicon produce a wide range of SoCs with
> > very diverse target markets, this driver looks like it's for enterprise
> > stuff while most things guarded by that config option look like they're
> > for embedded applications.

> SPI_HISI_KUNPENG does not depend on ARCH_HISI.

Right, but that's what Geert is proposing to change - the question is
does it make sense to do so or not?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 12:27 [PATCH] spi: SPI_HISI_KUNPENG should depend on ARCH_HISI Geert Uytterhoeven
2021-04-13 12:47 ` Mark Brown
2021-04-13 12:59   ` Jay Fang
2021-04-13 13:09     ` Mark Brown

Linux-SPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spi/0 linux-spi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spi linux-spi/ https://lore.kernel.org/linux-spi \
		linux-spi@vger.kernel.org
	public-inbox-index linux-spi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git