* [PATCH AUTOSEL 5.10 03/66] spi: ath79: always call chipselect function [not found] <20210502140411.2719301-1-sashal@kernel.org> @ 2021-05-02 14:03 ` Sasha Levin 2021-05-02 14:03 ` [PATCH AUTOSEL 5.10 04/66] spi: ath79: remove spi-master setup and cleanup assignment Sasha Levin 1 sibling, 0 replies; 2+ messages in thread From: Sasha Levin @ 2021-05-02 14:03 UTC (permalink / raw) To: linux-kernel, stable; +Cc: David Bauer, Mark Brown, Sasha Levin, linux-spi From: David Bauer <mail@david-bauer.net> [ Upstream commit 19e2132174583beb90c1bd3e9c842bc6d5c944d1 ] spi-bitbang has to call the chipselect function on the ath79 SPI driver in order to communicate with the SPI slave device, as the ath79 SPI driver has three dedicated chipselect lines but can also be used with GPIOs for the CS lines. Fixes commit 4a07b8bcd503 ("spi: bitbang: Make chipselect callback optional") Signed-off-by: David Bauer <mail@david-bauer.net> Link: https://lore.kernel.org/r/20210303160837.165771-1-mail@david-bauer.net Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/spi/spi-ath79.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c index eb9a243e9526..436327fb58de 100644 --- a/drivers/spi/spi-ath79.c +++ b/drivers/spi/spi-ath79.c @@ -158,6 +158,7 @@ static int ath79_spi_probe(struct platform_device *pdev) master->bits_per_word_mask = SPI_BPW_RANGE_MASK(1, 32); master->setup = spi_bitbang_setup; master->cleanup = spi_bitbang_cleanup; + master->flags = SPI_MASTER_GPIO_SS; if (pdata) { master->bus_num = pdata->bus_num; master->num_chipselect = pdata->num_chipselect; -- 2.30.2 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH AUTOSEL 5.10 04/66] spi: ath79: remove spi-master setup and cleanup assignment [not found] <20210502140411.2719301-1-sashal@kernel.org> 2021-05-02 14:03 ` [PATCH AUTOSEL 5.10 03/66] spi: ath79: always call chipselect function Sasha Levin @ 2021-05-02 14:03 ` Sasha Levin 1 sibling, 0 replies; 2+ messages in thread From: Sasha Levin @ 2021-05-02 14:03 UTC (permalink / raw) To: linux-kernel, stable; +Cc: David Bauer, Mark Brown, Sasha Levin, linux-spi From: David Bauer <mail@david-bauer.net> [ Upstream commit ffb597b2bd3cd78b9bfb68f536743cd46dbb2cc4 ] This removes the assignment of setup and cleanup functions for the ath79 target. Assigning the setup-method will lead to 'setup_transfer' not being assigned in spi_bitbang_init. Because of this, performing any TX/RX operation will lead to a kernel oops. Also drop the redundant cleanup assignment, as it's also assigned in spi_bitbang_init. Signed-off-by: David Bauer <mail@david-bauer.net> Link: https://lore.kernel.org/r/20210303160837.165771-2-mail@david-bauer.net Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/spi/spi-ath79.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c index 436327fb58de..98ace748cd98 100644 --- a/drivers/spi/spi-ath79.c +++ b/drivers/spi/spi-ath79.c @@ -156,8 +156,6 @@ static int ath79_spi_probe(struct platform_device *pdev) master->use_gpio_descriptors = true; master->bits_per_word_mask = SPI_BPW_RANGE_MASK(1, 32); - master->setup = spi_bitbang_setup; - master->cleanup = spi_bitbang_cleanup; master->flags = SPI_MASTER_GPIO_SS; if (pdata) { master->bus_num = pdata->bus_num; -- 2.30.2 ^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-02 14:04 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20210502140411.2719301-1-sashal@kernel.org> 2021-05-02 14:03 ` [PATCH AUTOSEL 5.10 03/66] spi: ath79: always call chipselect function Sasha Levin 2021-05-02 14:03 ` [PATCH AUTOSEL 5.10 04/66] spi: ath79: remove spi-master setup and cleanup assignment Sasha Levin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).