* Re: [PATCH] spi: tegra20: fix build with CONFIG_PM_SLEEP=n
2021-10-13 14:45 [PATCH] spi: tegra20: fix build with CONFIG_PM_SLEEP=n Arnd Bergmann
@ 2021-10-13 15:42 ` Guenter Roeck
2021-10-13 19:59 ` Mark Brown
2021-10-18 13:57 ` Thierry Reding
2 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2021-10-13 15:42 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Laxman Dewangan, Mark Brown, Thierry Reding, Jonathan Hunter,
Arnd Bergmann, Dmitry Osipenko, Geert Uytterhoeven, Zhang Qilong,
Yang Yingliang, linux-spi, linux-tegra, linux-kernel
On Wed, Oct 13, 2021 at 04:45:23PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> There is another one of these warnings:
>
> drivers/spi/spi-tegra20-slink.c:1197:12: error: 'tegra_slink_runtime_resume' defined but not used [-Werror=unused-function]
> 1197 | static int tegra_slink_runtime_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Give it the same treatment as the other functions in this file.
>
> Fixes: efafec27c565 ("spi: Fix tegra20 build with CONFIG_PM=n")
> Fixes: 2bab94090b01 ("spi: tegra20-slink: Declare runtime suspend and resume functions conditionally")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/spi/spi-tegra20-slink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
> index 713292b0c71e..33302f6b42d7 100644
> --- a/drivers/spi/spi-tegra20-slink.c
> +++ b/drivers/spi/spi-tegra20-slink.c
> @@ -1194,7 +1194,7 @@ static int __maybe_unused tegra_slink_runtime_suspend(struct device *dev)
> return 0;
> }
>
> -static int tegra_slink_runtime_resume(struct device *dev)
> +static __maybe_unused int tegra_slink_runtime_resume(struct device *dev)
That was actually done in efafec27c565. The error is the result of a bad
conflict resolution against 2bab94090b01, not a result of any of the
two patches listed in the Fixes: tags. So, yes, either this patch needs
to be applied in -next or the conflict resolution needs to be fixed.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Guenter
> {
> struct spi_master *master = dev_get_drvdata(dev);
> struct tegra_slink_data *tspi = spi_master_get_devdata(master);
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] spi: tegra20: fix build with CONFIG_PM_SLEEP=n
2021-10-13 14:45 [PATCH] spi: tegra20: fix build with CONFIG_PM_SLEEP=n Arnd Bergmann
2021-10-13 15:42 ` Guenter Roeck
@ 2021-10-13 19:59 ` Mark Brown
2021-10-18 13:57 ` Thierry Reding
2 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-10-13 19:59 UTC (permalink / raw)
To: Arnd Bergmann, Thierry Reding, Laxman Dewangan, Jonathan Hunter
Cc: Mark Brown, linux-spi, Zhang Qilong, Geert Uytterhoeven,
Arnd Bergmann, Guenter Roeck, Dmitry Osipenko, linux-kernel,
Yang Yingliang, linux-tegra
On Wed, 13 Oct 2021 16:45:23 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> There is another one of these warnings:
>
> drivers/spi/spi-tegra20-slink.c:1197:12: error: 'tegra_slink_runtime_resume' defined but not used [-Werror=unused-function]
> 1197 | static int tegra_slink_runtime_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: tegra20: fix build with CONFIG_PM_SLEEP=n
commit: 7dc9b9562740d858332894447c9779b146559239
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] spi: tegra20: fix build with CONFIG_PM_SLEEP=n
2021-10-13 14:45 [PATCH] spi: tegra20: fix build with CONFIG_PM_SLEEP=n Arnd Bergmann
2021-10-13 15:42 ` Guenter Roeck
2021-10-13 19:59 ` Mark Brown
@ 2021-10-18 13:57 ` Thierry Reding
2021-10-18 14:28 ` Guenter Roeck
2 siblings, 1 reply; 5+ messages in thread
From: Thierry Reding @ 2021-10-18 13:57 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Laxman Dewangan, Mark Brown, Jonathan Hunter, Arnd Bergmann,
Dmitry Osipenko, Geert Uytterhoeven, Guenter Roeck, Zhang Qilong,
Yang Yingliang, linux-spi, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On Wed, Oct 13, 2021 at 04:45:23PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> There is another one of these warnings:
>
> drivers/spi/spi-tegra20-slink.c:1197:12: error: 'tegra_slink_runtime_resume' defined but not used [-Werror=unused-function]
> 1197 | static int tegra_slink_runtime_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Give it the same treatment as the other functions in this file.
>
> Fixes: efafec27c565 ("spi: Fix tegra20 build with CONFIG_PM=n")
> Fixes: 2bab94090b01 ("spi: tegra20-slink: Declare runtime suspend and resume functions conditionally")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/spi/spi-tegra20-slink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] spi: tegra20: fix build with CONFIG_PM_SLEEP=n
2021-10-18 13:57 ` Thierry Reding
@ 2021-10-18 14:28 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2021-10-18 14:28 UTC (permalink / raw)
To: Thierry Reding, Arnd Bergmann
Cc: Laxman Dewangan, Mark Brown, Jonathan Hunter, Arnd Bergmann,
Dmitry Osipenko, Geert Uytterhoeven, Zhang Qilong,
Yang Yingliang, linux-spi, linux-tegra, linux-kernel
On 10/18/21 6:57 AM, Thierry Reding wrote:
> On Wed, Oct 13, 2021 at 04:45:23PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> There is another one of these warnings:
>>
>> drivers/spi/spi-tegra20-slink.c:1197:12: error: 'tegra_slink_runtime_resume' defined but not used [-Werror=unused-function]
>> 1197 | static int tegra_slink_runtime_resume(struct device *dev)
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Give it the same treatment as the other functions in this file.
>>
>> Fixes: efafec27c565 ("spi: Fix tegra20 build with CONFIG_PM=n")
>> Fixes: 2bab94090b01 ("spi: tegra20-slink: Declare runtime suspend and resume functions conditionally")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/spi/spi-tegra20-slink.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Thierry Reding <treding@nvidia.com>
>
The problem has now been (re-)introduced into the mainline kernel
and causes various test build failures there.
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread