* [PATCH] spi: tegra210-quad: Fix missin IRQ check in tegra_qspi_probe
@ 2022-01-28 16:59 Miaoqian Lin
2022-02-08 19:00 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-01-28 16:59 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter, Sowjanya Komatineni,
Laxman Dewangan, Mark Brown, linux-tegra, linux-spi,
linux-kernel
Cc: linmq006
This func misses checking for platform_get_irq()'s call and may passes the
negative error codes to request_threaded_irq(), which takes unsigned IRQ #,
causing it to fail with -EINVAL, overriding an original error code.
Stop calling request_threaded_irq() with invalid IRQ #s.
Fixes: 921fc1838fb0 ("spi: tegra210-quad: Add support for Tegra210 QSPI controller")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/spi/spi-tegra210-quad.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/spi/spi-tegra210-quad.c b/drivers/spi/spi-tegra210-quad.c
index ce1bdb4767ea..cb00ac2fc7d8 100644
--- a/drivers/spi/spi-tegra210-quad.c
+++ b/drivers/spi/spi-tegra210-quad.c
@@ -1240,6 +1240,8 @@ static int tegra_qspi_probe(struct platform_device *pdev)
tqspi->phys = r->start;
qspi_irq = platform_get_irq(pdev, 0);
+ if (qspi_irq < 0)
+ return qspi_irq;
tqspi->irq = qspi_irq;
tqspi->clk = devm_clk_get(&pdev->dev, "qspi");
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi: tegra210-quad: Fix missin IRQ check in tegra_qspi_probe
2022-01-28 16:59 [PATCH] spi: tegra210-quad: Fix missin IRQ check in tegra_qspi_probe Miaoqian Lin
@ 2022-02-08 19:00 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2022-02-08 19:00 UTC (permalink / raw)
To: linux-kernel, linux-spi, Miaoqian Lin, linux-tegra,
Thierry Reding, Sowjanya Komatineni, Laxman Dewangan,
Jonathan Hunter
On Fri, 28 Jan 2022 16:59:56 +0000, Miaoqian Lin wrote:
> This func misses checking for platform_get_irq()'s call and may passes the
> negative error codes to request_threaded_irq(), which takes unsigned IRQ #,
> causing it to fail with -EINVAL, overriding an original error code.
> Stop calling request_threaded_irq() with invalid IRQ #s.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: tegra210-quad: Fix missin IRQ check in tegra_qspi_probe
commit: 47c3e06ed95aa9b74932dbc6b23b544f644faf84
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-08 19:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-28 16:59 [PATCH] spi: tegra210-quad: Fix missin IRQ check in tegra_qspi_probe Miaoqian Lin
2022-02-08 19:00 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).