* [PATCH 0/2] spi: stm32-qspi: Remove unused parameters
@ 2022-06-02 8:59 patrice.chotard
2022-06-02 8:59 ` [PATCH 1/2] spi: stm32-qspi: Remove stm32_qspi_get_mode() unused parameter patrice.chotard
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: patrice.chotard @ 2022-06-02 8:59 UTC (permalink / raw)
To: Mark Brown, Alexandre Torgue
Cc: linux-spi, linux-stm32, linux-arm-kernel, linux-kernel,
christophe.kerello, patrice.chotard
From: Patrice Chotard <patrice.chotard@foss.st.com>
This series cleans up spi-stm32-qspi driver by removing unused parameters
Patrice Chotard (2):
spi: stm32-qspi: Remove stm32_qspi_get_mode() unused parameter
spi: stm32-qspi: Remove stm32_qspi_wait_cmd() unused parameter
drivers/spi/spi-stm32-qspi.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] spi: stm32-qspi: Remove stm32_qspi_get_mode() unused parameter
2022-06-02 8:59 [PATCH 0/2] spi: stm32-qspi: Remove unused parameters patrice.chotard
@ 2022-06-02 8:59 ` patrice.chotard
2022-06-02 8:59 ` [PATCH 2/2] spi: stm32-qspi: Remove stm32_qspi_wait_cmd() " patrice.chotard
2022-06-02 10:03 ` [PATCH 0/2] spi: stm32-qspi: Remove unused parameters Patrice CHOTARD
2 siblings, 0 replies; 4+ messages in thread
From: patrice.chotard @ 2022-06-02 8:59 UTC (permalink / raw)
To: Mark Brown, Alexandre Torgue
Cc: linux-spi, linux-stm32, linux-arm-kernel, linux-kernel,
christophe.kerello, patrice.chotard
From: Patrice Chotard <patrice.chotard@foss.st.com>
struct stm32_qspi *qsp is no more used remove it.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
drivers/spi/spi-stm32-qspi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c
index c0239e405c39..2ad43c2f0526 100644
--- a/drivers/spi/spi-stm32-qspi.c
+++ b/drivers/spi/spi-stm32-qspi.c
@@ -349,7 +349,7 @@ static int stm32_qspi_wait_poll_status(struct stm32_qspi *qspi,
return 0;
}
-static int stm32_qspi_get_mode(struct stm32_qspi *qspi, u8 buswidth)
+static int stm32_qspi_get_mode(u8 buswidth)
{
if (buswidth == 4)
return CCR_BUSWIDTH_4;
@@ -382,11 +382,11 @@ static int stm32_qspi_send(struct spi_mem *mem, const struct spi_mem_op *op)
ccr = qspi->fmode;
ccr |= FIELD_PREP(CCR_INST_MASK, op->cmd.opcode);
ccr |= FIELD_PREP(CCR_IMODE_MASK,
- stm32_qspi_get_mode(qspi, op->cmd.buswidth));
+ stm32_qspi_get_mode(op->cmd.buswidth));
if (op->addr.nbytes) {
ccr |= FIELD_PREP(CCR_ADMODE_MASK,
- stm32_qspi_get_mode(qspi, op->addr.buswidth));
+ stm32_qspi_get_mode(op->addr.buswidth));
ccr |= FIELD_PREP(CCR_ADSIZE_MASK, op->addr.nbytes - 1);
}
@@ -396,7 +396,7 @@ static int stm32_qspi_send(struct spi_mem *mem, const struct spi_mem_op *op)
if (op->data.nbytes) {
ccr |= FIELD_PREP(CCR_DMODE_MASK,
- stm32_qspi_get_mode(qspi, op->data.buswidth));
+ stm32_qspi_get_mode(op->data.buswidth));
}
writel_relaxed(ccr, qspi->io_base + QSPI_CCR);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] spi: stm32-qspi: Remove stm32_qspi_wait_cmd() unused parameter
2022-06-02 8:59 [PATCH 0/2] spi: stm32-qspi: Remove unused parameters patrice.chotard
2022-06-02 8:59 ` [PATCH 1/2] spi: stm32-qspi: Remove stm32_qspi_get_mode() unused parameter patrice.chotard
@ 2022-06-02 8:59 ` patrice.chotard
2022-06-02 10:03 ` [PATCH 0/2] spi: stm32-qspi: Remove unused parameters Patrice CHOTARD
2 siblings, 0 replies; 4+ messages in thread
From: patrice.chotard @ 2022-06-02 8:59 UTC (permalink / raw)
To: Mark Brown, Alexandre Torgue
Cc: linux-spi, linux-stm32, linux-arm-kernel, linux-kernel,
christophe.kerello, patrice.chotard
From: Patrice Chotard <patrice.chotard@foss.st.com>
struct spi_mem_op *op parameter is no more used, remove it.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
drivers/spi/spi-stm32-qspi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c
index 2ad43c2f0526..e5068e694ca5 100644
--- a/drivers/spi/spi-stm32-qspi.c
+++ b/drivers/spi/spi-stm32-qspi.c
@@ -299,8 +299,7 @@ static int stm32_qspi_wait_nobusy(struct stm32_qspi *qspi)
STM32_BUSY_TIMEOUT_US);
}
-static int stm32_qspi_wait_cmd(struct stm32_qspi *qspi,
- const struct spi_mem_op *op)
+static int stm32_qspi_wait_cmd(struct stm32_qspi *qspi)
{
u32 cr, sr;
int err = 0;
@@ -420,7 +419,7 @@ static int stm32_qspi_send(struct spi_mem *mem, const struct spi_mem_op *op)
goto abort;
/* wait end of tx in indirect mode */
- err = stm32_qspi_wait_cmd(qspi, op);
+ err = stm32_qspi_wait_cmd(qspi);
if (err)
goto abort;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] spi: stm32-qspi: Remove unused parameters
2022-06-02 8:59 [PATCH 0/2] spi: stm32-qspi: Remove unused parameters patrice.chotard
2022-06-02 8:59 ` [PATCH 1/2] spi: stm32-qspi: Remove stm32_qspi_get_mode() unused parameter patrice.chotard
2022-06-02 8:59 ` [PATCH 2/2] spi: stm32-qspi: Remove stm32_qspi_wait_cmd() " patrice.chotard
@ 2022-06-02 10:03 ` Patrice CHOTARD
2 siblings, 0 replies; 4+ messages in thread
From: Patrice CHOTARD @ 2022-06-02 10:03 UTC (permalink / raw)
To: Mark Brown, Alexandre Torgue
Cc: linux-spi, linux-stm32, linux-arm-kernel, linux-kernel,
christophe.kerello
A v2 as been sent, as a patch was missing
PAtrice
On 6/2/22 10:59, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
>
> This series cleans up spi-stm32-qspi driver by removing unused parameters
>
> Patrice Chotard (2):
> spi: stm32-qspi: Remove stm32_qspi_get_mode() unused parameter
> spi: stm32-qspi: Remove stm32_qspi_wait_cmd() unused parameter
>
> drivers/spi/spi-stm32-qspi.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-02 10:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-02 8:59 [PATCH 0/2] spi: stm32-qspi: Remove unused parameters patrice.chotard
2022-06-02 8:59 ` [PATCH 1/2] spi: stm32-qspi: Remove stm32_qspi_get_mode() unused parameter patrice.chotard
2022-06-02 8:59 ` [PATCH 2/2] spi: stm32-qspi: Remove stm32_qspi_wait_cmd() " patrice.chotard
2022-06-02 10:03 ` [PATCH 0/2] spi: stm32-qspi: Remove unused parameters Patrice CHOTARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).