From: Louis Chauvet <louis.chauvet@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
Miquel Raynal <miquel.raynal@bootlin.com>,
yen-mei.goh@keysight.com, koon-kee.lie@keysight.com,
jeremie.dautheribes@bootlin.com,
Louis Chauvet <louis.chauvet@bootlin.com>
Subject: [PATCH v2 3/3] spi: omap2-mcpsi: Enable MULTI-mode in more situations
Date: Fri, 23 Feb 2024 10:32:13 +0100 [thread overview]
Message-ID: <20240223-spi-omap2-mcspi-multi-mode-v2-3-afe94476b9c3@bootlin.com> (raw)
In-Reply-To: <20240223-spi-omap2-mcspi-multi-mode-v2-0-afe94476b9c3@bootlin.com>
Enable multimode when a transfer of multiple small words can be
transformed in a transfer with a single bigger word. This is allowed as
long as the result on the cable is the same, so word_delay must be zero.
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
I am not sure if this is the best place to put such "optimization". I
think this improvment should be in the core, as it is not depending on the
driver itself, but I think Mark suggested something like this so if that
fits to what was expected, I am happy to share this small improvement.
---
drivers/spi/spi-omap2-mcspi.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
index 36075c4416d5..f64cc8cc7587 100644
--- a/drivers/spi/spi-omap2-mcspi.c
+++ b/drivers/spi/spi-omap2-mcspi.c
@@ -1397,14 +1397,26 @@ static int omap2_mcspi_prepare_message(struct spi_controller *ctlr,
else
bits_per_word = tr->bits_per_word;
- /* Only a single channel can have the FORCE bit enabled
/*
* Check if this transfer contains only one word;
+ * OR contains 1 to 4 words, with bits_per_word == 8 and no delay between each word
+ * OR contains 1 to 2 words, with bits_per_word == 16 and no delay between each word
+ *
+ * If one of the two last case is true, this also change the bits_per_word of this
+ * transfer to make it a bit faster.
+ * It's not an issue to change the bits_per_word here even if the multi-mode is not
+ * applicable for this message, the signal on the wire will be the same.
*/
if (bits_per_word < 8 && tr->len == 1) {
/* multi-mode is applicable, only one word (1..7 bits) */
+ } else if (tr->word_delay.value == 0 && bits_per_word == 8 && tr->len <= 4) {
+ /* multi-mode is applicable, only one "bigger" word (8,16,24,32 bits) */
+ tr->bits_per_word = tr->len * bits_per_word;
+ } else if (tr->word_delay.value == 0 && bits_per_word == 16 && tr->len <= 2) {
+ /* multi-mode is applicable, only one "bigger" word (16,32 bits) */
+ tr->bits_per_word = tr->len * bits_per_word / 2;
} else if (bits_per_word >= 8 && tr->len == bits_per_word / 8) {
- /* multi-mode is applicable, only one word (8..32 bits) */
+ /* multi-mode is applicable, only one word (9..15,17..32 bits) */
} else {
/* multi-mode is not applicable: more than one word in the transfer */
mcspi->use_multi_mode = false;
--
2.43.0
next prev parent reply other threads:[~2024-02-23 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 9:32 [PATCH v2 0/3] Add multi mode support for omap-mcspi Louis Chauvet
2024-02-23 9:32 ` [PATCH v2 1/3] spi: spi-omap2-mcspi.c: revert "Toggle CS after each word" Louis Chauvet
2024-02-23 9:32 ` [PATCH v2 2/3] spi: omap2-mcspi: Add support for MULTI-mode Louis Chauvet
2024-03-25 14:05 ` Mark Brown
2024-03-27 9:27 ` Louis Chauvet
2024-02-23 9:32 ` Louis Chauvet [this message]
2024-03-14 13:56 ` [PATCH v2 0/3] Add multi mode support for omap-mcspi Louis Chauvet
2024-03-14 14:04 ` Mark Brown
2024-03-29 12:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223-spi-omap2-mcspi-multi-mode-v2-3-afe94476b9c3@bootlin.com \
--to=louis.chauvet@bootlin.com \
--cc=broonie@kernel.org \
--cc=jeremie.dautheribes@bootlin.com \
--cc=koon-kee.lie@keysight.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yen-mei.goh@keysight.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).