From: Mark Brown <broonie@kernel.org>
To: Louis Chauvet <louis.chauvet@bootlin.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
Miquel Raynal <miquel.raynal@bootlin.com>,
yen-mei.goh@keysight.com, koon-kee.lie@keysight.com,
jeremie.dautheribes@bootlin.com
Subject: Re: [PATCH v2 2/3] spi: omap2-mcspi: Add support for MULTI-mode
Date: Mon, 25 Mar 2024 14:05:24 +0000 [thread overview]
Message-ID: <8e5f3551-75c5-4211-84f6-18bbaf061dfb@sirena.org.uk> (raw)
In-Reply-To: <20240223-spi-omap2-mcspi-multi-mode-v2-2-afe94476b9c3@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
On Fri, Feb 23, 2024 at 10:32:12AM +0100, Louis Chauvet wrote:
> Introduce support for MULTI-mode in the OMAP2 MCSPI driver. Currently, the
> driver always uses SINGLE mode to handle the chip select (CS). With this
> enhancement, MULTI-mode is enabled for specific messages, allowing for a
> shorter delay between CS enable and the message (some FPGA devices are
> sensitive to this delay).
This breaks an allmodconfig build:
/build/stage/linux/drivers/spi/spi-omap2-mcspi.c: In function ‘omap2_mcspi_prepare_message’:
/build/stage/linux/drivers/spi/spi-omap2-mcspi.c:1280:17: error: "/*" within comment [-Werror=comment]
1280 | /*
|
/build/stage/linux/drivers/spi/spi-omap2-mcspi.c:1265:14: error: unused variable ‘word_delay_is_zero’ [-Werror=unused-variable]
1265 | bool word_delay_is_zero;
| ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-03-25 14:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 9:32 [PATCH v2 0/3] Add multi mode support for omap-mcspi Louis Chauvet
2024-02-23 9:32 ` [PATCH v2 1/3] spi: spi-omap2-mcspi.c: revert "Toggle CS after each word" Louis Chauvet
2024-02-23 9:32 ` [PATCH v2 2/3] spi: omap2-mcspi: Add support for MULTI-mode Louis Chauvet
2024-03-25 14:05 ` Mark Brown [this message]
2024-03-27 9:27 ` Louis Chauvet
2024-02-23 9:32 ` [PATCH v2 3/3] spi: omap2-mcpsi: Enable MULTI-mode in more situations Louis Chauvet
2024-03-14 13:56 ` [PATCH v2 0/3] Add multi mode support for omap-mcspi Louis Chauvet
2024-03-14 14:04 ` Mark Brown
2024-03-29 12:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e5f3551-75c5-4211-84f6-18bbaf061dfb@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jeremie.dautheribes@bootlin.com \
--cc=koon-kee.lie@keysight.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yen-mei.goh@keysight.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).