* [PATCH] mtd: spi-nor: macronix: Add support for mx25um51245g
@ 2024-03-28 11:52 Witold Sadowski
2024-04-02 8:34 ` Michael Walle
0 siblings, 1 reply; 2+ messages in thread
From: Witold Sadowski @ 2024-03-28 11:52 UTC (permalink / raw)
To: linux-spi, linux-kernel, broonie; +Cc: Witold Sadowski
The Macronix mx25um51245g is a 1.8V, 512Mbit (64MB) device that
supports x1, or x8 operation.
Tested on Marvell Octeon SoC hardware with a Cadence xSPI controller.
Signed-off-by: Witold Sadowski <wsadowski@marvell.com>
---
drivers/mtd/spi-nor/macronix.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
index ea6be95e75a5..f5fbdb7912e0 100644
--- a/drivers/mtd/spi-nor/macronix.c
+++ b/drivers/mtd/spi-nor/macronix.c
@@ -182,6 +182,12 @@ static const struct flash_info macronix_nor_parts[] = {
.name = "mx25l3255e",
.size = SZ_4M,
.no_sfdp_flags = SECT_4K,
+ }, {
+ .id = SNOR_ID(0xc2, 0x80, 0x3a),
+ .name = "mx25um51245g",
+ .size = SZ_64M,
+ .no_sfdp_flags = SECT_4K,
+ .fixup_flags = SPI_NOR_4B_OPCODES,
}
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: spi-nor: macronix: Add support for mx25um51245g
2024-03-28 11:52 [PATCH] mtd: spi-nor: macronix: Add support for mx25um51245g Witold Sadowski
@ 2024-04-02 8:34 ` Michael Walle
0 siblings, 0 replies; 2+ messages in thread
From: Michael Walle @ 2024-04-02 8:34 UTC (permalink / raw)
To: Witold Sadowski, linux-spi, linux-kernel, broonie; +Cc: linux-mtd
[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]
[+ linux-mtd ]
Hi,
On Thu Mar 28, 2024 at 12:52 PM CET, Witold Sadowski wrote:
> The Macronix mx25um51245g is a 1.8V, 512Mbit (64MB) device that
> supports x1, or x8 operation.
>
> Tested on Marvell Octeon SoC hardware with a Cadence xSPI controller.
>
> Signed-off-by: Witold Sadowski <wsadowski@marvell.com>
You haven't CC'ed the correct list, therefore it's unlikely this
will get a proper review/getting merged at all.
As Krzysztof already pointed out on another series of yours, please
read submitting-patches.rst.
For nor flash related submissions please also read:
https://docs.kernel.org/driver-api/mtd/spi-nor.html
> ---
> drivers/mtd/spi-nor/macronix.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> index ea6be95e75a5..f5fbdb7912e0 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -182,6 +182,12 @@ static const struct flash_info macronix_nor_parts[] = {
> .name = "mx25l3255e",
> .size = SZ_4M,
> .no_sfdp_flags = SECT_4K,
> + }, {
> + .id = SNOR_ID(0xc2, 0x80, 0x3a),
Wrong indentation?. Please use checkpatch.pl.
> + .name = "mx25um51245g",
drop the name.
> + .size = SZ_64M,
This is also autodetected. Drop it.
> + .no_sfdp_flags = SECT_4K,
No "no_sfdp_flags" for SFDP capable flashes. Drop it.
> + .fixup_flags = SPI_NOR_4B_OPCODES,
Doesn't the flash have proper a 4BAIT table?
-michael
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-02 8:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-28 11:52 [PATCH] mtd: spi-nor: macronix: Add support for mx25um51245g Witold Sadowski
2024-04-02 8:34 ` Michael Walle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).