From: David Brownell <david-b@pacbell.net>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>,
Kevin Hilman <khilman@deeprootsystems.com>
Cc: spi-devel-general@lists.sourceforge.net,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v5 1/1] OMAP2: Spi: Force CS to be in inactive state after off-mode transition
Date: Wed, 24 Nov 2010 19:55:25 -0800 (PST) [thread overview]
Message-ID: <249691.92718.qm@web180302.mail.gq1.yahoo.com> (raw)
In-Reply-To: <87y68i447o.fsf@deeprootsystems.com>
--- On Wed, 11/24/10, Kevin Hilman <khilman@deeprootsystems.com> wrote:
> I'm not SPI-aware enough to ack
> this patch or
> test it thoroughly.
Heh, my excuse is usually "not enough time"
or sometimes "no test setup" ... ;)
In this case I can at least ack the fix in
principle. CS active means an active trransfer,
which must not happen during OFF or other
suspend states.
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> Also, in the last patch I suggested you do more of a
> save/restore of
> this value instead of a restore to a hard-coded
> value. IOW, save the
> value in the suspend method, restore it in resume.
More correct to restart
message queue processing
after resume, if it's non-empty, and to have
cleanly stopped it (between messages) before
entering suspend states like OFF.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-11-25 3:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 22:19 [PATCH v5 1/1] OMAP2: Spi: Force CS to be in inactive state after off-mode transition Gregory CLEMENT
2010-11-25 0:49 ` Kevin Hilman
2010-11-25 3:55 ` David Brownell [this message]
2010-11-29 16:59 ` Gregory CLEMENT
2010-12-23 23:08 ` Grant Likely
2010-12-24 10:38 ` Gregory CLEMENT
2010-11-25 8:58 ` Hemanth V
2010-11-29 17:18 ` Gregory CLEMENT
2010-11-29 14:22 ` Kevin Hilman
2010-11-29 17:03 ` Gregory CLEMENT
2010-11-30 3:08 ` David Brownell
2010-11-30 8:26 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=249691.92718.qm@web180302.mail.gq1.yahoo.com \
--to=david-b@pacbell.net \
--cc=gregory.clement@free-electrons.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).