From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
linux-omap <linux-omap@vger.kernel.org>,
spi-devel-general@lists.sourceforge.net,
David Brownell <dbrownell@users.sourceforge.net>
Subject: Re: [PATCH v5 1/1] OMAP2: Spi: Force CS to be in inactive state after off-mode transition
Date: Fri, 24 Dec 2010 11:38:07 +0100 [thread overview]
Message-ID: <4D14780F.3070409@free-electrons.com> (raw)
In-Reply-To: <20101223230828.GP20384@angua.secretlab.ca>
On 12/24/2010 12:08 AM, Grant Likely wrote:
> On Wed, Nov 24, 2010 at 04:49:47PM -0800, Kevin Hilman wrote:
>> Gregory CLEMENT <gregory.clement@free-electrons.com> writes:
>>
>>> As request by Grant Likely, there is no more cover letter. Full changelog is following.
>>> I am still reluctant to add this changelog in the patch description, as it adds no value to
>>> the patch itself: when it was needed I try to updat comments or patch description.
>>
>> You're right, the changelog should not be in the patch description.
>> This bit of meta-description and changelog should go after the '---'
>> just after your signoff. That way, git tools can still auto-apply the
>> email, and git ignores stuff after the '---' so it doesn't end up in the
>> git history.
>
> Actually, I used to have the same opinion, but dwmw2 clued me in that
> it really is valuable and proper to have the revision history and
> changelog in the patch description. When looking back at what
> actually got committed into Linus' tree, the changelog gives hints as
> to which exact version of the patch got committed (for instance, if a
> v6 got merged, but a v7 was also posted that didn't get merged.)
>
OK if it is the rule for spi subsystem, I will conform to it, and I will
add my changelog in the patch description.
> BTW, this thread has some discussion about this patch not actually
> working correctly. What is the state? Should this version get
> merged, or do I need to wait for a v6?
Well, I tried to answer to each points to Kevin and to David Brownell. I
was waiting for some feedback. I didn't realize it was already near a
month ago, so it should be OK. Then I will insert the last comments of
Kevin and release the v6.
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2010-12-24 10:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 22:19 [PATCH v5 1/1] OMAP2: Spi: Force CS to be in inactive state after off-mode transition Gregory CLEMENT
2010-11-25 0:49 ` Kevin Hilman
2010-11-25 3:55 ` David Brownell
2010-11-29 16:59 ` Gregory CLEMENT
2010-12-23 23:08 ` Grant Likely
2010-12-24 10:38 ` Gregory CLEMENT [this message]
2010-11-25 8:58 ` Hemanth V
2010-11-29 17:18 ` Gregory CLEMENT
2010-11-29 14:22 ` Kevin Hilman
2010-11-29 17:03 ` Gregory CLEMENT
2010-11-30 3:08 ` David Brownell
2010-11-30 8:26 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D14780F.3070409@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).