PATCH[V2 1/3]: Update Platform files for SPI

PATCH[V2 1/3]: Update Platform files for SPI

[Hemanth V]

>From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
From: Hemanth V <hemanthv@ti.com>
Date: Fri, 27 Nov 2009 14:22:30 +0530
Subject: [PATCH] Update platform files

This patch updates platform files for
fifo, slave support

Signed-off-by: Hemanth V <hemanthv@ti.com>
---
 arch/arm/mach-omap2/devices.c           |    5 +++++
 arch/arm/plat-omap/include/plat/mcspi.h |   29 ++++++++++++++++++++++++++++- 2
files changed, 33 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 733d3dc..79b5396 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -282,6 +282,7 @@ static inline void omap_init_sti(void) {}

 static struct omap2_mcspi_platform_config omap2_mcspi1_config = {
 	.num_cs		= 4,
+	.force_cs_mode	= 1,
 };

 static struct resource omap2_mcspi1_resources[] = {
@@ -304,6 +305,10 @@ static struct platform_device omap2_mcspi1 = {

 static struct omap2_mcspi_platform_config omap2_mcspi2_config = {
 	.num_cs		= 2,
+	.mode		= OMAP2_MCSPI_MASTER,
+	.dma_mode	= 0,
+	.force_cs_mode	= 0,
+	.fifo_depth	= 0,
 };

 static struct resource omap2_mcspi2_resources[] = {
diff --git a/arch/arm/plat-omap/include/plat/mcspi.h
b/arch/arm/plat-omap/include/plat/mcspi.h
index 1254e49..ffda0a1 100644
--- a/arch/arm/plat-omap/include/plat/mcspi.h
+++ b/arch/arm/plat-omap/include/plat/mcspi.h
@@ -1,8 +1,35 @@
 #ifndef _OMAP2_MCSPI_H
 #define _OMAP2_MCSPI_H

+#define OMAP2_MCSPI_MASTER		0
+#define OMAP2_MCSPI_SLAVE		1
+
+/**
+ * struct omap2_mcspi_platform_config - McSPI controller configuration + *
@num_cs: Number of chip selects or channels supported
+ * @mode: SPI is master or slave
+ * @dma_mode: Use only DMA for data transfers
+ * @force_cs_mode: Use force chip select mode or auto chip select mode + *
@fifo_depth: FIFO depth in bytes, max value 64
+ *
+ * @dma_mode when set to 1 uses only dma for data transfers
+ * else the default behaviour is to use PIO mode for transfer
+ * size of 8 bytes or less. This mode is useful when mcspi
+ * is configured as slave
+ *
+ * @force_cs_mode when set to 1 allows continuous transfer of multiple + * spi
words without toggling the chip select line.
+ *
+ * @fifo_depth when set to non zero values enables FIFO. fifo_depth + * should
be set as a multiple of buffer size used for read/write. + */
+
 struct omap2_mcspi_platform_config {
-	unsigned short	num_cs;
+	u8	num_cs;
+	u8	mode;
+	u8	dma_mode;
+	u8	force_cs_mode;
+	unsigned short fifo_depth;
 };

 struct omap2_mcspi_device_config {
-- 
1.5.6.3

Re: PATCH[V2 1/3]: Update Platform files for SPI

[Tony Lindgren]

* Hemanth V <hemanthv@ti.com> [100203 02:19]:
> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
> From: Hemanth V <hemanthv@ti.com>
> Date: Fri, 27 Nov 2009 14:22:30 +0530
> Subject: [PATCH] Update platform files
> 
> This patch updates platform files for
> fifo, slave support
> 
> Signed-off-by: Hemanth V <hemanthv@ti.com>

This should get merged via the spi-devel list with the other patches.

Acked-by: Tony Lindgren <tony@atomide.com>


> ---
>  arch/arm/mach-omap2/devices.c           |    5 +++++
>  arch/arm/plat-omap/include/plat/mcspi.h |   29 ++++++++++++++++++++++++++++- 2
> files changed, 33 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index 733d3dc..79b5396 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -282,6 +282,7 @@ static inline void omap_init_sti(void) {}
> 
>  static struct omap2_mcspi_platform_config omap2_mcspi1_config = {
>  	.num_cs		= 4,
> +	.force_cs_mode	= 1,
>  };
> 
>  static struct resource omap2_mcspi1_resources[] = {
> @@ -304,6 +305,10 @@ static struct platform_device omap2_mcspi1 = {
> 
>  static struct omap2_mcspi_platform_config omap2_mcspi2_config = {
>  	.num_cs		= 2,
> +	.mode		= OMAP2_MCSPI_MASTER,
> +	.dma_mode	= 0,
> +	.force_cs_mode	= 0,
> +	.fifo_depth	= 0,
>  };
> 
>  static struct resource omap2_mcspi2_resources[] = {
> diff --git a/arch/arm/plat-omap/include/plat/mcspi.h
> b/arch/arm/plat-omap/include/plat/mcspi.h
> index 1254e49..ffda0a1 100644
> --- a/arch/arm/plat-omap/include/plat/mcspi.h
> +++ b/arch/arm/plat-omap/include/plat/mcspi.h
> @@ -1,8 +1,35 @@
>  #ifndef _OMAP2_MCSPI_H
>  #define _OMAP2_MCSPI_H
> 
> +#define OMAP2_MCSPI_MASTER		0
> +#define OMAP2_MCSPI_SLAVE		1
> +
> +/**
> + * struct omap2_mcspi_platform_config - McSPI controller configuration + *
> @num_cs: Number of chip selects or channels supported
> + * @mode: SPI is master or slave
> + * @dma_mode: Use only DMA for data transfers
> + * @force_cs_mode: Use force chip select mode or auto chip select mode + *
> @fifo_depth: FIFO depth in bytes, max value 64
> + *
> + * @dma_mode when set to 1 uses only dma for data transfers
> + * else the default behaviour is to use PIO mode for transfer
> + * size of 8 bytes or less. This mode is useful when mcspi
> + * is configured as slave
> + *
> + * @force_cs_mode when set to 1 allows continuous transfer of multiple + * spi
> words without toggling the chip select line.
> + *
> + * @fifo_depth when set to non zero values enables FIFO. fifo_depth + * should
> be set as a multiple of buffer size used for read/write. + */
> +
>  struct omap2_mcspi_platform_config {
> -	unsigned short	num_cs;
> +	u8	num_cs;
> +	u8	mode;
> +	u8	dma_mode;
> +	u8	force_cs_mode;
> +	unsigned short fifo_depth;
>  };
> 
>  struct omap2_mcspi_device_config {
> -- 
> 1.5.6.3
> 
> 
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: PATCH[V2 1/3]: Update Platform files for SPI

[Grant Likely]

On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Hemanth V <hemanthv@ti.com> [100203 02:19]:
>> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
>> From: Hemanth V <hemanthv@ti.com>
>> Date: Fri, 27 Nov 2009 14:22:30 +0530
>> Subject: [PATCH] Update platform files
>>
>> This patch updates platform files for
>> fifo, slave support
>>
>> Signed-off-by: Hemanth V <hemanthv@ti.com>
>
> This should get merged via the spi-devel list with the other patches.
>
> Acked-by: Tony Lindgren <tony@atomide.com>

Personally, I prefer not to carry arch/* changes in my next-spi
branch, since it means that my pull requests are less obvious for
Linus and there is greater chance of conflict.

But if you still really want me to merge it through my tree, (or if
getting the patches out of order will break things) then I'll pick it
up.  Just let me know.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: PATCH[V2 1/3]: Update Platform files for SPI

[Tony Lindgren]

* Grant Likely <grant.likely@secretlab.ca> [100209 14:38]:
> On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Hemanth V <hemanthv@ti.com> [100203 02:19]:
> >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
> >> From: Hemanth V <hemanthv@ti.com>
> >> Date: Fri, 27 Nov 2009 14:22:30 +0530
> >> Subject: [PATCH] Update platform files
> >>
> >> This patch updates platform files for
> >> fifo, slave support
> >>
> >> Signed-off-by: Hemanth V <hemanthv@ti.com>
> >
> > This should get merged via the spi-devel list with the other patches.
> >
> > Acked-by: Tony Lindgren <tony@atomide.com>
> 
> Personally, I prefer not to carry arch/* changes in my next-spi
> branch, since it means that my pull requests are less obvious for
> Linus and there is greater chance of conflict.
> 
> But if you still really want me to merge it through my tree, (or if
> getting the patches out of order will break things) then I'll pick it
> up.  Just let me know.

OK, if you ack it, I'll add the header into omap for-next. That
might break git bisect for some configurations depending in which
order the patches get pulled by Linus..

I guess eventually this header should not live under plat.

Regards,

Tony

Re: PATCH[V2 1/3]: Update Platform files for SPI

[Grant Likely]

On Tue, Feb 9, 2010 at 4:07 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Grant Likely <grant.likely@secretlab.ca> [100209 14:38]:
>> On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren <tony@atomide.com> wrote:
>> > * Hemanth V <hemanthv@ti.com> [100203 02:19]:
>> >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
>> >> From: Hemanth V <hemanthv@ti.com>
>> >> Date: Fri, 27 Nov 2009 14:22:30 +0530
>> >> Subject: [PATCH] Update platform files
>> >>
>> >> This patch updates platform files for
>> >> fifo, slave support
>> >>
>> >> Signed-off-by: Hemanth V <hemanthv@ti.com>
>> >
>> > This should get merged via the spi-devel list with the other patches.
>> >
>> > Acked-by: Tony Lindgren <tony@atomide.com>
>>
>> Personally, I prefer not to carry arch/* changes in my next-spi
>> branch, since it means that my pull requests are less obvious for
>> Linus and there is greater chance of conflict.
>>
>> But if you still really want me to merge it through my tree, (or if
>> getting the patches out of order will break things) then I'll pick it
>> up.  Just let me know.
>
> OK, if you ack it, I'll add the header into omap for-next. That
> might break git bisect for some configurations depending in which
> order the patches get pulled by Linus..

git bisect breakage is breakage enough.  :-)  You're right.  I should
pick this one up.  I can see that now that I've had my tea and I'm no
longer grumpy.

> I guess eventually this header should not live under plat.

Any reason the header cannot be moved to include/linux/spi/ now?

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: PATCH[V2 1/3]: Update Platform files for SPI

[Hemanth V]

> On Tue, Feb 9, 2010 at 4:07 PM, Tony Lindgren <tony@atomide.com> wrote:
>> * Grant Likely <grant.likely@secretlab.ca> [100209 14:38]:
>>> On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren <tony@atomide.com> wrote:
>>> > * Hemanth V <hemanthv@ti.com> [100203 02:19]:
>>> >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
>>> >> From: Hemanth V <hemanthv@ti.com>
>>> >> Date: Fri, 27 Nov 2009 14:22:30 +0530
>>> >> Subject: [PATCH] Update platform files
>>> >>
>>> >> This patch updates platform files for
>>> >> fifo, slave support
>>> >>
>>> >> Signed-off-by: Hemanth V <hemanthv@ti.com>
>>> >
>>> > This should get merged via the spi-devel list with the other patches.
>>> >
>>> > Acked-by: Tony Lindgren <tony@atomide.com>
>>>
>>> Personally, I prefer not to carry arch/* changes in my next-spi
>>> branch, since it means that my pull requests are less obvious for
>>> Linus and there is greater chance of conflict.
>>>
>>> But if you still really want me to merge it through my tree, (or if
>>> getting the patches out of order will break things) then I'll pick it
>>> up.  Just let me know.
>>
>> OK, if you ack it, I'll add the header into omap for-next. That
>> might break git bisect for some configurations depending in which
>> order the patches get pulled by Linus..
>
> git bisect breakage is breakage enough.  :-)  You're right.  I should
> pick this one up.  I can see that now that I've had my tea and I'm no
> longer grumpy.
>
>> I guess eventually this header should not live under plat.
>
> Any reason the header cannot be moved to include/linux/spi/ now?

Quite a few board files use this header file, which would also require changes.
Tony, are you ok with accepting changes to board files.

Thanks
Hemanth
>
> g.
>
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
>


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: PATCH[V2 1/3]: Update Platform files for SPI

[Tony Lindgren]

* Tony Lindgren <tony@atomide.com> [100209 15:03]:
> * Grant Likely <grant.likely@secretlab.ca> [100209 14:38]:
> > On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren <tony@atomide.com> wrote:
> > > * Hemanth V <hemanthv@ti.com> [100203 02:19]:
> > >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
> > >> From: Hemanth V <hemanthv@ti.com>
> > >> Date: Fri, 27 Nov 2009 14:22:30 +0530
> > >> Subject: [PATCH] Update platform files
> > >>
> > >> This patch updates platform files for
> > >> fifo, slave support
> > >>
> > >> Signed-off-by: Hemanth V <hemanthv@ti.com>
> > >
> > > This should get merged via the spi-devel list with the other patches.
> > >
> > > Acked-by: Tony Lindgren <tony@atomide.com>
> > 
> > Personally, I prefer not to carry arch/* changes in my next-spi
> > branch, since it means that my pull requests are less obvious for
> > Linus and there is greater chance of conflict.
> > 
> > But if you still really want me to merge it through my tree, (or if
> > getting the patches out of order will break things) then I'll pick it
> > up.  Just let me know.
> 
> OK, if you ack it, I'll add the header into omap for-next. That
> might break git bisect for some configurations depending in which
> order the patches get pulled by Linus..
> 
> I guess eventually this header should not live under plat.

Hemanth, the patch is missing line breaks so it won't apply:

http://patchwork.kernel.org/patch/76675/

Please resend, I'm not editing patches manually any longer thanks.

Regards,

Tony

Re: PATCH[V2 1/3]: Update Platform files for SPI

[Hemanth V]

> * Tony Lindgren <tony@atomide.com> [100209 15:03]:
>> * Grant Likely <grant.likely@secretlab.ca> [100209 14:38]:
>> > On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren <tony@atomide.com> wrote:
>> > > * Hemanth V <hemanthv@ti.com> [100203 02:19]:
>> > >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
>> > >> From: Hemanth V <hemanthv@ti.com>
>> > >> Date: Fri, 27 Nov 2009 14:22:30 +0530
>> > >> Subject: [PATCH] Update platform files
>> > >>
>> > >> This patch updates platform files for
>> > >> fifo, slave support
>> > >>
>> > >> Signed-off-by: Hemanth V <hemanthv@ti.com>
>> > >
>> > > This should get merged via the spi-devel list with the other patches.
>> > >
>> > > Acked-by: Tony Lindgren <tony@atomide.com>
>> >
>> > Personally, I prefer not to carry arch/* changes in my next-spi
>> > branch, since it means that my pull requests are less obvious for
>> > Linus and there is greater chance of conflict.
>> >
>> > But if you still really want me to merge it through my tree, (or if
>> > getting the patches out of order will break things) then I'll pick it
>> > up.  Just let me know.
>>
>> OK, if you ack it, I'll add the header into omap for-next. That
>> might break git bisect for some configurations depending in which
>> order the patches get pulled by Linus..
>>
>> I guess eventually this header should not live under plat.
>
> Hemanth, the patch is missing line breaks so it won't apply:
>
> http://patchwork.kernel.org/patch/76675/
>
> Please resend, I'm not editing patches manually any longer thanks.
>
> Regards,
>
> Tony
>
Pl find the patches attached, hopefully it doesnot get corrupted this
time

>From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
From: Hemanth V <hemanthv@ti.com>
Date: Fri, 27 Nov 2009 14:22:30 +0530
Subject: [PATCH] Update platform files

This patch updates platform files for
fifo, slave support

Signed-off-by: Hemanth V <hemanthv@ti.com>
---
 arch/arm/mach-omap2/devices.c           |    5 +++++
 arch/arm/plat-omap/include/plat/mcspi.h |   29 ++++++++++++++++++++++++++++-
 2 files changed, 33 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 733d3dc..79b5396 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -282,6 +282,7 @@ static inline void omap_init_sti(void) {}

 static struct omap2_mcspi_platform_config omap2_mcspi1_config = {
 	.num_cs		= 4,
+	.force_cs_mode	= 1,
 };

 static struct resource omap2_mcspi1_resources[] = {
@@ -304,6 +305,10 @@ static struct platform_device omap2_mcspi1 = {

 static struct omap2_mcspi_platform_config omap2_mcspi2_config = {
 	.num_cs		= 2,
+	.mode		= OMAP2_MCSPI_MASTER,
+	.dma_mode	= 0,
+	.force_cs_mode	= 0,
+	.fifo_depth	= 0,
 };

 static struct resource omap2_mcspi2_resources[] = {
diff --git a/arch/arm/plat-omap/include/plat/mcspi.h
b/arch/arm/plat-omap/include/plat/mcspi.h
index 1254e49..ffda0a1 100644
--- a/arch/arm/plat-omap/include/plat/mcspi.h
+++ b/arch/arm/plat-omap/include/plat/mcspi.h
@@ -1,8 +1,35 @@
 #ifndef _OMAP2_MCSPI_H
 #define _OMAP2_MCSPI_H

+#define OMAP2_MCSPI_MASTER		0
+#define OMAP2_MCSPI_SLAVE		1
+
+/**
+ * struct omap2_mcspi_platform_config - McSPI controller configuration
+ * @num_cs: Number of chip selects or channels supported
+ * @mode: SPI is master or slave
+ * @dma_mode: Use only DMA for data transfers
+ * @force_cs_mode: Use force chip select mode or auto chip select mode
+ * @fifo_depth: FIFO depth in bytes, max value 64
+ *
+ * @dma_mode when set to 1 uses only dma for data transfers
+ * else the default behaviour is to use PIO mode for transfer
+ * size of 8 bytes or less. This mode is useful when mcspi
+ * is configured as slave
+ *
+ * @force_cs_mode when set to 1 allows continuous transfer of multiple
+ * spi words without toggling the chip select line.
+ *
+ * @fifo_depth when set to non zero values enables FIFO. fifo_depth
+ * should be set as a multiple of buffer size used for read/write.
+ */
+
 struct omap2_mcspi_platform_config {
-	unsigned short	num_cs;
+	u8	num_cs;
+	u8	mode;
+	u8	dma_mode;
+	u8	force_cs_mode;
+	unsigned short fifo_depth;
 };

 struct omap2_mcspi_device_config {
-- 
1.5.6.3

Re: PATCH[V2 1/3]: Update Platform files for SPI

[Grant Likely]

On Tue, Feb 16, 2010 at 7:38 AM, Hemanth V <hemanthv@ti.com> wrote:
>> * Tony Lindgren <tony@atomide.com> [100209 15:03]:
>>> * Grant Likely <grant.likely@secretlab.ca> [100209 14:38]:
>>> > On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren <tony@atomide.com> wrote:
>>> > > * Hemanth V <hemanthv@ti.com> [100203 02:19]:
>>> > >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
>>> > >> From: Hemanth V <hemanthv@ti.com>
>>> > >> Date: Fri, 27 Nov 2009 14:22:30 +0530
>>> > >> Subject: [PATCH] Update platform files
>>> > >>
>>> > >> This patch updates platform files for
>>> > >> fifo, slave support
>>> > >>
>>> > >> Signed-off-by: Hemanth V <hemanthv@ti.com>
>>> > >
>>> > > This should get merged via the spi-devel list with the other patches.
>>> > >
>>> > > Acked-by: Tony Lindgren <tony@atomide.com>
>>> >
>>> > Personally, I prefer not to carry arch/* changes in my next-spi
>>> > branch, since it means that my pull requests are less obvious for
>>> > Linus and there is greater chance of conflict.
>>> >
>>> > But if you still really want me to merge it through my tree, (or if
>>> > getting the patches out of order will break things) then I'll pick it
>>> > up.  Just let me know.
>>>
>>> OK, if you ack it, I'll add the header into omap for-next. That
>>> might break git bisect for some configurations depending in which
>>> order the patches get pulled by Linus..
>>>
>>> I guess eventually this header should not live under plat.
>>
>> Hemanth, the patch is missing line breaks so it won't apply:
>>
>> http://patchwork.kernel.org/patch/76675/
>>
>> Please resend, I'm not editing patches manually any longer thanks.
>>
>> Regards,
>>
>> Tony
>>
> Pl find the patches attached, hopefully it doesnot get corrupted this
> time

This one is okay, and I've got it in my tree, but I need patches 2 and
3 resent also.

Thanks,
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: PATCH[V2 1/3]: Update Platform files for SPI

[Grant Likely]

On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Hemanth V <hemanthv@ti.com> [100203 02:19]:
>> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
>> From: Hemanth V <hemanthv@ti.com>
>> Date: Fri, 27 Nov 2009 14:22:30 +0530
>> Subject: [PATCH] Update platform files
>>
>> This patch updates platform files for
>> fifo, slave support
>>
>> Signed-off-by: Hemanth V <hemanthv@ti.com>
>
> This should get merged via the spi-devel list with the other patches.
>
> Acked-by: Tony Lindgren <tony@atomide.com>

Tony, do you want me to add your acked-by to patches 2 & 3?

Also, what is your feeling about patch 3/3, spi slave support.  spi
slave usage model is still a matter under debate, but that patch
doesn't touch core spi code, so I'm okay to merge it as a
driver-specific feature.  However, I'm not convinced that it is
actually a useful patch to merge yet, so I'll defer to you on this
one.  Thoughts?

Thanks,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: PATCH[V2 1/3]: Update Platform files for SPI

[Tony Lindgren]

* Grant Likely <grant.likely@secretlab.ca> [100218 08:26]:
> On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Hemanth V <hemanthv@ti.com> [100203 02:19]:
> >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
> >> From: Hemanth V <hemanthv@ti.com>
> >> Date: Fri, 27 Nov 2009 14:22:30 +0530
> >> Subject: [PATCH] Update platform files
> >>
> >> This patch updates platform files for
> >> fifo, slave support
> >>
> >> Signed-off-by: Hemanth V <hemanthv@ti.com>
> >
> > This should get merged via the spi-devel list with the other patches.
> >
> > Acked-by: Tony Lindgren <tony@atomide.com>
> 
> Tony, do you want me to add your acked-by to patches 2 & 3?

No thanks, I've only looked at them briefly.
 
> Also, what is your feeling about patch 3/3, spi slave support.  spi
> slave usage model is still a matter under debate, but that patch
> doesn't touch core spi code, so I'm okay to merge it as a
> driver-specific feature.  However, I'm not convinced that it is
> actually a useful patch to merge yet, so I'll defer to you on this
> one.  Thoughts?

Up to you to decide. But here's my experience so far..

Based on my experience if temporary hacks are merged, then nobody
bothers to clean them up properly afterwards and the clean-up task
unfairly falls on the maintainer.

So IMHO, hacks like that are better floating on the mailing list
until they're properly done. It's best to concentrate on getting
the core things done right to make long term support easier.

Regards,

Tony

Re: PATCH[V2 1/3]: Update Platform files for SPI

[Grant Likely]

On Thu, Feb 18, 2010 at 10:09 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Grant Likely <grant.likely@secretlab.ca> [100218 08:26]:
>> On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren <tony@atomide.com> wrote:
>> > * Hemanth V <hemanthv@ti.com> [100203 02:19]:
>> >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
>> >> From: Hemanth V <hemanthv@ti.com>
>> >> Date: Fri, 27 Nov 2009 14:22:30 +0530
>> >> Subject: [PATCH] Update platform files
>> >>
>> >> This patch updates platform files for
>> >> fifo, slave support
>> >>
>> >> Signed-off-by: Hemanth V <hemanthv@ti.com>
>> >
>> > This should get merged via the spi-devel list with the other patches.
>> >
>> > Acked-by: Tony Lindgren <tony@atomide.com>
>>
>> Tony, do you want me to add your acked-by to patches 2 & 3?
>
> No thanks, I've only looked at them briefly.

Okay, thanks.

Hemanth, I'm going to drop this series for the moment.  I'd like to
see some feedback/acks from current users and maintainers of the
omap2_mcspi driver before I merge support, especially now when the
merge window is about to open and it hasn't gotten any linux-next
exposure.

>> Also, what is your feeling about patch 3/3, spi slave support.  spi
>> slave usage model is still a matter under debate, but that patch
>> doesn't touch core spi code, so I'm okay to merge it as a
>> driver-specific feature.  However, I'm not convinced that it is
>> actually a useful patch to merge yet, so I'll defer to you on this
>> one.  Thoughts?
>
> Up to you to decide. But here's my experience so far..
>
> Based on my experience if temporary hacks are merged, then nobody
> bothers to clean them up properly afterwards and the clean-up task
> unfairly falls on the maintainer.
>
> So IMHO, hacks like that are better floating on the mailing list
> until they're properly done. It's best to concentrate on getting
> the core things done right to make long term support easier.

Right, I agree.  I'll ignore patch 3 entirely until I at least see a
patch for an in-tree user.

Thanks,
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: PATCH[V2 1/3]: Update Platform files for SPI

[Grant Likely]

On Thu, Feb 18, 2010 at 11:29 AM, Grant Likely
<grant.likely@secretlab.ca> wrote:
> On Thu, Feb 18, 2010 at 10:09 AM, Tony Lindgren <tony@atomide.com> wrote:
>> * Grant Likely <grant.likely@secretlab.ca> [100218 08:26]:
>>> On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren <tony@atomide.com> wrote:
>>> > * Hemanth V <hemanthv@ti.com> [100203 02:19]:
>>> >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
>>> >> From: Hemanth V <hemanthv@ti.com>
>>> >> Date: Fri, 27 Nov 2009 14:22:30 +0530
>>> >> Subject: [PATCH] Update platform files
>>> >>
>>> >> This patch updates platform files for
>>> >> fifo, slave support
>>> >>
>>> >> Signed-off-by: Hemanth V <hemanthv@ti.com>
>>> >
>>> > This should get merged via the spi-devel list with the other patches.
>>> >
>>> > Acked-by: Tony Lindgren <tony@atomide.com>
>>>
>>> Tony, do you want me to add your acked-by to patches 2 & 3?
>>
>> No thanks, I've only looked at them briefly.
>
> Okay, thanks.
>
> Hemanth, I'm going to drop this series for the moment.  I'd like to
> see some feedback/acks from current users and maintainers of the
> omap2_mcspi driver before I merge support, especially now when the
> merge window is about to open and it hasn't gotten any linux-next
> exposure.
>
>>> Also, what is your feeling about patch 3/3, spi slave support.  spi
>>> slave usage model is still a matter under debate, but that patch
>>> doesn't touch core spi code, so I'm okay to merge it as a
>>> driver-specific feature.  However, I'm not convinced that it is
>>> actually a useful patch to merge yet, so I'll defer to you on this
>>> one.  Thoughts?
>>
>> Up to you to decide. But here's my experience so far..
>>
>> Based on my experience if temporary hacks are merged, then nobody
>> bothers to clean them up properly afterwards and the clean-up task
>> unfairly falls on the maintainer.
>>
>> So IMHO, hacks like that are better floating on the mailing list
>> until they're properly done. It's best to concentrate on getting
>> the core things done right to make long term support easier.
>
> Right, I agree.  I'll ignore patch 3 entirely until I at least see a
> patch for an in-tree user.

Hi Hemanth.  Could you please respin patches 1 and 2 against
2.6.35-rc3?  The current patches do not apply anymore.

Thanks,
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: PATCH[V2 1/3]: Update Platform files for SPI

[Hemanth V]

> On Thu, Feb 18, 2010 at 11:29 AM, Grant Likely
> <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote:
>> On Thu, Feb 18, 2010 at 10:09 AM, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> wrote:
>>> * Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> [100218 08:26]:
>>>> On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> wrote:
>>>> > * Hemanth V <hemanthv-l0cyMroinI0@public.gmane.org> [100203 02:19]:
>>>> >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001
>>>> >> From: Hemanth V <hemanthv-l0cyMroinI0@public.gmane.org>
>>>> >> Date: Fri, 27 Nov 2009 14:22:30 +0530
>>>> >> Subject: [PATCH] Update platform files
>>>> >>
>>>> >> This patch updates platform files for
>>>> >> fifo, slave support
>>>> >>
>>>> >> Signed-off-by: Hemanth V <hemanthv-l0cyMroinI0@public.gmane.org>
>>>> >
>>>> > This should get merged via the spi-devel list with the other patches.
>>>> >
>>>> > Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>>>>
>>>> Tony, do you want me to add your acked-by to patches 2 & 3?
>>>
>>> No thanks, I've only looked at them briefly.
>>
>> Okay, thanks.
>>
>> Hemanth, I'm going to drop this series for the moment.  I'd like to
>> see some feedback/acks from current users and maintainers of the
>> omap2_mcspi driver before I merge support, especially now when the
>> merge window is about to open and it hasn't gotten any linux-next
>> exposure.
>>
>>>> Also, what is your feeling about patch 3/3, spi slave support.  spi
>>>> slave usage model is still a matter under debate, but that patch
>>>> doesn't touch core spi code, so I'm okay to merge it as a
>>>> driver-specific feature.  However, I'm not convinced that it is
>>>> actually a useful patch to merge yet, so I'll defer to you on this
>>>> one.  Thoughts?
>>>
>>> Up to you to decide. But here's my experience so far..
>>>
>>> Based on my experience if temporary hacks are merged, then nobody
>>> bothers to clean them up properly afterwards and the clean-up task
>>> unfairly falls on the maintainer.
>>>
>>> So IMHO, hacks like that are better floating on the mailing list
>>> until they're properly done. It's best to concentrate on getting
>>> the core things done right to make long term support easier.
>>
>> Right, I agree.  I'll ignore patch 3 entirely until I at least see a
>> patch for an in-tree user.
>
> Hi Hemanth.  Could you please respin patches 1 and 2 against
> 2.6.35-rc3?  The current patches do not apply anymore.
>

Grant,

Govindraj marked in this mail would rebase the patches and post the
same.

Thanks
Hemanth



------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first