linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/4] OMAP4: SPI: Fix Driver Kconfig
@ 2010-04-22 14:43 Arce, Abraham
  2010-05-04 19:48 ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Arce, Abraham @ 2010-04-22 14:43 UTC (permalink / raw)
  To: linux-omap, spi-devel-general
  Cc: Shilimkar, Santosh, Tony Lindgren, Russell King - ARM Linux

From: Syed Rafiuddin <rafiuddin.syed@ti.com>

Add OMAP4 data to allow McSPI driver built

Signed-off-by: Syed Rafiuddin <rafiuddin.syed@ti.com>
Signed-off-by: Shubhro <a0393217@ti.com>
Signed-off-by: Santosh Shilimkar <santosh shilimkar@ti.com>
Signed-off-by: Abraham Arce <x0066660@ti.com>
---
 drivers/spi/Kconfig |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index a191fa2..5f54235 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -180,10 +180,10 @@ config SPI_OMAP_UWIRE
 	  This hooks up to the MicroWire controller on OMAP1 chips.
 
 config SPI_OMAP24XX
-	tristate "McSPI driver for OMAP24xx/OMAP34xx"
-	depends on ARCH_OMAP2 || ARCH_OMAP3
+	tristate "McSPI driver for OMAP24xx/OMAP34xx/OMAP44xx"
+	depends on ARCH_OMAP24XX || ARCH_OMAP34XX || ARCH_OMAP4
 	help
-	  SPI master controller for OMAP24xx/OMAP34xx Multichannel SPI
+	  SPI master controller for OMAP24xx/OMAP34xx/OMAP44xx Multichannel SPI
 	  (McSPI) modules.
 
 config SPI_OMAP_100K
-- 
1.5.4.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/4] OMAP4: SPI: Fix Driver Kconfig
  2010-04-22 14:43 [PATCH 2/4] OMAP4: SPI: Fix Driver Kconfig Arce, Abraham
@ 2010-05-04 19:48 ` Tony Lindgren
  2010-05-05  6:24   ` Arce, Abraham
  0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2010-05-04 19:48 UTC (permalink / raw)
  To: Arce, Abraham
  Cc: linux-omap, spi-devel-general, Shilimkar, Santosh,
	Russell King - ARM Linux

* Arce, Abraham <x0066660@ti.com> [100422 07:39]:
> From: Syed Rafiuddin <rafiuddin.syed@ti.com>
> 
> Add OMAP4 data to allow McSPI driver built
> 
> Signed-off-by: Syed Rafiuddin <rafiuddin.syed@ti.com>
> Signed-off-by: Shubhro <a0393217@ti.com>
> Signed-off-by: Santosh Shilimkar <santosh shilimkar@ti.com>
> Signed-off-by: Abraham Arce <x0066660@ti.com>
> ---
>  drivers/spi/Kconfig |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index a191fa2..5f54235 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -180,10 +180,10 @@ config SPI_OMAP_UWIRE
>  	  This hooks up to the MicroWire controller on OMAP1 chips.
>  
>  config SPI_OMAP24XX
> -	tristate "McSPI driver for OMAP24xx/OMAP34xx"
> -	depends on ARCH_OMAP2 || ARCH_OMAP3
> +	tristate "McSPI driver for OMAP24xx/OMAP34xx/OMAP44xx"
> +	depends on ARCH_OMAP24XX || ARCH_OMAP34XX || ARCH_OMAP4
>  	help
> -	  SPI master controller for OMAP24xx/OMAP34xx Multichannel SPI
> +	  SPI master controller for OMAP24xx/OMAP34xx/OMAP44xx Multichannel SPI
>  	  (McSPI) modules.
>  
>  config SPI_OMAP_100K

You can simplify this and make it more future proof with something like:

config SPI_OMAP24XX
	tristate "McSPI driver for OMAP"
	depends on ARCH_OMAP2PLUS
	help
	  SPI master controller for OMAP24XX and later

Regards,

Tony

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH 2/4] OMAP4: SPI: Fix Driver Kconfig
  2010-05-04 19:48 ` Tony Lindgren
@ 2010-05-05  6:24   ` Arce, Abraham
  0 siblings, 0 replies; 3+ messages in thread
From: Arce, Abraham @ 2010-05-05  6:24 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: linux-omap, spi-devel-general, Shilimkar, Santosh,
	Russell King - ARM Linux

Hi Tony,

> >  config SPI_OMAP24XX
> > -	tristate "McSPI driver for OMAP24xx/OMAP34xx"
> > -	depends on ARCH_OMAP2 || ARCH_OMAP3
> > +	tristate "McSPI driver for OMAP24xx/OMAP34xx/OMAP44xx"
> > +	depends on ARCH_OMAP24XX || ARCH_OMAP34XX || ARCH_OMAP4
> >  	help
> > -	  SPI master controller for OMAP24xx/OMAP34xx Multichannel SPI
> > +	  SPI master controller for OMAP24xx/OMAP34xx/OMAP44xx Multichannel SPI
> >  	  (McSPI) modules.
> >
> >  config SPI_OMAP_100K
> 
> You can simplify this and make it more future proof with something like:
> 
> config SPI_OMAP24XX
> 	tristate "McSPI driver for OMAP"
> 	depends on ARCH_OMAP2PLUS
> 	help
> 	  SPI master controller for OMAP24XX and later

Changed as suggested...

ARCH_OMAP2PLUS
"Systems based on omap24xx, omap34xx or omap44xx"

Best Regards
Abraham

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-05-05  6:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-22 14:43 [PATCH 2/4] OMAP4: SPI: Fix Driver Kconfig Arce, Abraham
2010-05-04 19:48 ` Tony Lindgren
2010-05-05  6:24   ` Arce, Abraham

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).