* [PATCH 4/4] spi: dt-bindings: qcom,spi-qup: convert to dtschema [not found] <20220329112902.252937-1-krzysztof.kozlowski@linaro.org> @ 2022-03-29 11:29 ` Krzysztof Kozlowski 2022-03-29 11:38 ` Krzysztof Kozlowski ` (2 more replies) 0 siblings, 3 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-03-29 11:29 UTC (permalink / raw) To: linux-kernel Cc: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Mark Brown, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, linux-spi, devicetree Convert the Qualcomm Universal Peripheral (QUP) Serial Peripheral Interface (SPI) bindings to DT Schema. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/spi/qcom,spi-qup.txt | 103 ------------------ .../devicetree/bindings/spi/qcom,spi-qup.yaml | 82 ++++++++++++++ 2 files changed, 82 insertions(+), 103 deletions(-) delete mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qup.txt create mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt deleted file mode 100644 index 5c090771c016..000000000000 --- a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt +++ /dev/null @@ -1,103 +0,0 @@ -Qualcomm Universal Peripheral (QUP) Serial Peripheral Interface (SPI) - -The QUP core is an AHB slave that provides a common data path (an output FIFO -and an input FIFO) for serial peripheral interface (SPI) mini-core. - -SPI in master mode supports up to 50MHz, up to four chip selects, programmable -data path from 4 bits to 32 bits and numerous protocol variants. - -Required properties: -- compatible: Should contain: - "qcom,spi-qup-v1.1.1" for 8660, 8960 and 8064. - "qcom,spi-qup-v2.1.1" for 8974 and later - "qcom,spi-qup-v2.2.1" for 8974 v2 and later. - -- reg: Should contain base register location and length -- interrupts: Interrupt number used by this controller - -- clocks: Should contain the core clock and the AHB clock. -- clock-names: Should be "core" for the core clock and "iface" for the - AHB clock. - -- #address-cells: Number of cells required to define a chip select - address on the SPI bus. Should be set to 1. -- #size-cells: Should be zero. - -Optional properties: -- spi-max-frequency: Specifies maximum SPI clock frequency, - Units - Hz. Definition as per - Documentation/devicetree/bindings/spi/spi-bus.txt -- num-cs: total number of chipselects -- cs-gpios: should specify GPIOs used for chipselects. - The gpios will be referred to as reg = <index> in the SPI child - nodes. If unspecified, a single SPI device without a chip - select can be used. - -- dmas: Two DMA channel specifiers following the convention outlined - in bindings/dma/dma.txt -- dma-names: Names for the dma channels, if present. There must be at - least one channel named "tx" for transmit and named "rx" for - receive. - -SPI slave nodes must be children of the SPI master node and can contain -properties described in Documentation/devicetree/bindings/spi/spi-bus.txt - -Example: - - spi_8: spi@f9964000 { /* BLSP2 QUP2 */ - - compatible = "qcom,spi-qup-v2"; - #address-cells = <1>; - #size-cells = <0>; - reg = <0xf9964000 0x1000>; - interrupts = <0 102 0>; - spi-max-frequency = <19200000>; - - clocks = <&gcc GCC_BLSP2_QUP2_SPI_APPS_CLK>, <&gcc GCC_BLSP2_AHB_CLK>; - clock-names = "core", "iface"; - - dmas = <&blsp1_bam 13>, <&blsp1_bam 12>; - dma-names = "rx", "tx"; - - pinctrl-names = "default"; - pinctrl-0 = <&spi8_default>; - - device@0 { - compatible = "arm,pl022-dummy"; - #address-cells = <1>; - #size-cells = <1>; - reg = <0>; /* Chip select 0 */ - spi-max-frequency = <19200000>; - spi-cpol; - }; - - device@1 { - compatible = "arm,pl022-dummy"; - #address-cells = <1>; - #size-cells = <1>; - reg = <1>; /* Chip select 1 */ - spi-max-frequency = <9600000>; - spi-cpha; - }; - - device@2 { - compatible = "arm,pl022-dummy"; - #address-cells = <1>; - #size-cells = <1>; - reg = <2>; /* Chip select 2 */ - spi-max-frequency = <19200000>; - spi-cpol; - spi-cpha; - }; - - device@3 { - compatible = "arm,pl022-dummy"; - #address-cells = <1>; - #size-cells = <1>; - reg = <3>; /* Chip select 3 */ - spi-max-frequency = <19200000>; - spi-cpol; - spi-cpha; - spi-cs-high; - }; - }; diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml new file mode 100644 index 000000000000..aa5756f7ba85 --- /dev/null +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml @@ -0,0 +1,82 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/qcom,spi-qup.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Universal Peripheral (QUP) Serial Peripheral Interface (SPI) + +maintainers: + - Andy Gross <agross@kernel.org> + - Bjorn Andersson <bjorn.andersson@linaro.org> + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> + +description: + The QUP core is an AHB slave that provides a common data path (an output FIFO + and an input FIFO) for serial peripheral interface (SPI) mini-core. + + SPI in master mode supports up to 50MHz, up to four chip selects, + programmable data path from 4 bits to 32 bits and numerous protocol variants. + +allOf: + - $ref: /spi/spi-controller.yaml# + +properties: + compatible: + enum: + - qcom,spi-qup-v1.1.1 # for 8660, 8960 and 8064 + - qcom,spi-qup-v2.1.1 # for 8974 and later + - qcom,spi-qup-v2.2.1 # for 8974 v2 and later + + clocks: + maxItems: 2 + + clock-names: + items: + - const: core + - const: iface + + dmas: + maxItems: 2 + + dma-names: + items: + - const: tx + - const: rx + + interrupts: + maxItems: 1 + + reg: + maxItems: 1 + +required: + - compatible + - clocks + - clock-names + - interrupts + - reg + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,gcc-msm8996.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + spi@7575000 { + compatible = "qcom,spi-qup-v2.2.1"; + reg = <0x07575000 0x600>; + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&gcc GCC_BLSP1_QUP1_SPI_APPS_CLK>, + <&gcc GCC_BLSP1_AHB_CLK>; + clock-names = "core", + "iface"; + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&blsp1_spi1_default>; + pinctrl-1 = <&blsp1_spi1_sleep>; + dmas = <&blsp1_dma 12>, <&blsp1_dma 13>; + dma-names = "tx", "rx"; + #address-cells = <1>; + #size-cells = <0>; + }; -- 2.32.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] spi: dt-bindings: qcom,spi-qup: convert to dtschema 2022-03-29 11:29 ` [PATCH 4/4] spi: dt-bindings: qcom,spi-qup: convert to dtschema Krzysztof Kozlowski @ 2022-03-29 11:38 ` Krzysztof Kozlowski 2022-03-29 19:05 ` Rob Herring 2022-03-30 11:42 ` Kuldeep Singh 2 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-03-29 11:38 UTC (permalink / raw) To: linux-kernel Cc: Andy Gross, Bjorn Andersson, Mark Brown, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, linux-spi, devicetree On 29/03/2022 13:29, Krzysztof Kozlowski wrote: > Convert the Qualcomm Universal Peripheral (QUP) Serial Peripheral > Interface (SPI) bindings to DT Schema. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/spi/qcom,spi-qup.txt | 103 ------------------ > .../devicetree/bindings/spi/qcom,spi-qup.yaml | 82 ++++++++++++++ > 2 files changed, 82 insertions(+), 103 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qup.txt > create mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml I forgot to update the path in Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.txt I will send a v2 ~tomorrow. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] spi: dt-bindings: qcom,spi-qup: convert to dtschema 2022-03-29 11:29 ` [PATCH 4/4] spi: dt-bindings: qcom,spi-qup: convert to dtschema Krzysztof Kozlowski 2022-03-29 11:38 ` Krzysztof Kozlowski @ 2022-03-29 19:05 ` Rob Herring 2022-03-29 19:11 ` Krzysztof Kozlowski 2022-03-30 11:42 ` Kuldeep Singh 2 siblings, 1 reply; 6+ messages in thread From: Rob Herring @ 2022-03-29 19:05 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Mark Brown, linux-arm-msm, linux-spi, Rob Herring, Krzysztof Kozlowski, Bjorn Andersson, devicetree, linux-kernel, Andy Gross On Tue, 29 Mar 2022 13:29:02 +0200, Krzysztof Kozlowski wrote: > Convert the Qualcomm Universal Peripheral (QUP) Serial Peripheral > Interface (SPI) bindings to DT Schema. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/spi/qcom,spi-qup.txt | 103 ------------------ > .../devicetree/bindings/spi/qcom,spi-qup.yaml | 82 ++++++++++++++ > 2 files changed, 82 insertions(+), 103 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qup.txt > create mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1610591 spi@78b5000: clock-names:0: 'core' was expected arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml spi@78b5000: clock-names:1: 'iface' was expected arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml spi@78b5000: dma-names:0: 'tx' was expected arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm/boot/dts/qcom-apq8016-sbc.dt.yaml arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dt.yaml spi@78b5000: dma-names:1: 'rx' was expected arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm/boot/dts/qcom-apq8016-sbc.dt.yaml arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dt.yaml spi@78b6000: clock-names:0: 'core' was expected arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml spi@78b6000: clock-names:1: 'iface' was expected arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml spi@78b6000: dma-names:0: 'tx' was expected arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm/boot/dts/qcom-apq8016-sbc.dt.yaml arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dt.yaml spi@78b6000: dma-names:1: 'rx' was expected arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm/boot/dts/qcom-apq8016-sbc.dt.yaml arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dt.yaml spi@78b7000: clock-names:0: 'core' was expected arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml spi@78b7000: clock-names:1: 'iface' was expected arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml spi@78b7000: dma-names:0: 'tx' was expected arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm/boot/dts/qcom-apq8016-sbc.dt.yaml arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dt.yaml spi@78b7000: dma-names:1: 'rx' was expected arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm/boot/dts/qcom-apq8016-sbc.dt.yaml arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dt.yaml spi@78b8000: clock-names:0: 'core' was expected arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml spi@78b8000: clock-names:1: 'iface' was expected arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml spi@78b8000: dma-names:0: 'tx' was expected arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm/boot/dts/qcom-apq8016-sbc.dt.yaml arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dt.yaml spi@78b8000: dma-names:1: 'rx' was expected arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm/boot/dts/qcom-apq8016-sbc.dt.yaml arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dt.yaml spi@78b9000: clock-names:0: 'core' was expected arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml spi@78b9000: clock-names:1: 'iface' was expected arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml spi@78b9000: dma-names:0: 'tx' was expected arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm/boot/dts/qcom-apq8016-sbc.dt.yaml arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dt.yaml spi@78b9000: dma-names:1: 'rx' was expected arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm/boot/dts/qcom-apq8016-sbc.dt.yaml arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dt.yaml spi@78ba000: dma-names:0: 'tx' was expected arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm/boot/dts/qcom-apq8016-sbc.dt.yaml arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dt.yaml spi@78ba000: dma-names:1: 'rx' was expected arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dt.yaml arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dt.yaml arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dt.yaml arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dt.yaml arch/arm64/boot/dts/qcom/msm8916-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dt.yaml arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dt.yaml arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dt.yaml arch/arm/boot/dts/qcom-apq8016-sbc.dt.yaml arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dt.yaml spi@7af5000: clock-names:0: 'core' was expected arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml spi@7af5000: clock-names:1: 'iface' was expected arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] spi: dt-bindings: qcom,spi-qup: convert to dtschema 2022-03-29 19:05 ` Rob Herring @ 2022-03-29 19:11 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-03-29 19:11 UTC (permalink / raw) To: Rob Herring Cc: Mark Brown, linux-arm-msm, linux-spi, Rob Herring, Krzysztof Kozlowski, Bjorn Andersson, devicetree, linux-kernel, Andy Gross On 29/03/2022 21:05, Rob Herring wrote: > On Tue, 29 Mar 2022 13:29:02 +0200, Krzysztof Kozlowski wrote: >> Convert the Qualcomm Universal Peripheral (QUP) Serial Peripheral >> Interface (SPI) bindings to DT Schema. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../devicetree/bindings/spi/qcom,spi-qup.txt | 103 ------------------ >> .../devicetree/bindings/spi/qcom,spi-qup.yaml | 82 ++++++++++++++ >> 2 files changed, 82 insertions(+), 103 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qup.txt >> create mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1610591 > > > spi@78b5000: clock-names:0: 'core' was expected > arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml > arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml > > spi@78b5000: clock-names:1: 'iface' was expected > arch/arm64/boot/dts/qcom/qcs404-evb-1000.dt.yaml > arch/arm64/boot/dts/qcom/qcs404-evb-4000.dt.yaml All of these (and dma-names) should be fixed with my DTS patches in the series. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] spi: dt-bindings: qcom,spi-qup: convert to dtschema 2022-03-29 11:29 ` [PATCH 4/4] spi: dt-bindings: qcom,spi-qup: convert to dtschema Krzysztof Kozlowski 2022-03-29 11:38 ` Krzysztof Kozlowski 2022-03-29 19:05 ` Rob Herring @ 2022-03-30 11:42 ` Kuldeep Singh 2022-03-30 11:45 ` Krzysztof Kozlowski 2 siblings, 1 reply; 6+ messages in thread From: Kuldeep Singh @ 2022-03-30 11:42 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: linux-kernel, Andy Gross, Bjorn Andersson, Mark Brown, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, linux-spi, devicetree On Tue, Mar 29, 2022 at 01:29:02PM +0200, Krzysztof Kozlowski wrote: > Convert the Qualcomm Universal Peripheral (QUP) Serial Peripheral > Interface (SPI) bindings to DT Schema. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/spi/qcom,spi-qup.txt | 103 ------------------ > .../devicetree/bindings/spi/qcom,spi-qup.yaml | 82 ++++++++++++++ > 2 files changed, 82 insertions(+), 103 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qup.txt > create mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml > > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt > deleted file mode 100644 > index 5c090771c016..000000000000 > --- a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt > +++ /dev/null > @@ -1,103 +0,0 @@ > -Qualcomm Universal Peripheral (QUP) Serial Peripheral Interface (SPI) > - > -The QUP core is an AHB slave that provides a common data path (an output FIFO > -and an input FIFO) for serial peripheral interface (SPI) mini-core. > - > -SPI in master mode supports up to 50MHz, up to four chip selects, programmable > -data path from 4 bits to 32 bits and numerous protocol variants. > - > -Required properties: > -- compatible: Should contain: > - "qcom,spi-qup-v1.1.1" for 8660, 8960 and 8064. > - "qcom,spi-qup-v2.1.1" for 8974 and later > - "qcom,spi-qup-v2.2.1" for 8974 v2 and later. > - > -- reg: Should contain base register location and length > -- interrupts: Interrupt number used by this controller > - > -- clocks: Should contain the core clock and the AHB clock. > -- clock-names: Should be "core" for the core clock and "iface" for the > - AHB clock. > - > -- #address-cells: Number of cells required to define a chip select > - address on the SPI bus. Should be set to 1. > -- #size-cells: Should be zero. > - > -Optional properties: > -- spi-max-frequency: Specifies maximum SPI clock frequency, > - Units - Hz. Definition as per > - Documentation/devicetree/bindings/spi/spi-bus.txt > -- num-cs: total number of chipselects > -- cs-gpios: should specify GPIOs used for chipselects. > - The gpios will be referred to as reg = <index> in the SPI child > - nodes. If unspecified, a single SPI device without a chip > - select can be used. > - > -- dmas: Two DMA channel specifiers following the convention outlined > - in bindings/dma/dma.txt > -- dma-names: Names for the dma channels, if present. There must be at > - least one channel named "tx" for transmit and named "rx" for > - receive. > - > -SPI slave nodes must be children of the SPI master node and can contain > -properties described in Documentation/devicetree/bindings/spi/spi-bus.txt > - > -Example: > - > - spi_8: spi@f9964000 { /* BLSP2 QUP2 */ > - > - compatible = "qcom,spi-qup-v2"; > - #address-cells = <1>; > - #size-cells = <0>; > - reg = <0xf9964000 0x1000>; > - interrupts = <0 102 0>; > - spi-max-frequency = <19200000>; > - > - clocks = <&gcc GCC_BLSP2_QUP2_SPI_APPS_CLK>, <&gcc GCC_BLSP2_AHB_CLK>; > - clock-names = "core", "iface"; > - > - dmas = <&blsp1_bam 13>, <&blsp1_bam 12>; > - dma-names = "rx", "tx"; > - > - pinctrl-names = "default"; > - pinctrl-0 = <&spi8_default>; > - > - device@0 { > - compatible = "arm,pl022-dummy"; > - #address-cells = <1>; > - #size-cells = <1>; > - reg = <0>; /* Chip select 0 */ > - spi-max-frequency = <19200000>; > - spi-cpol; > - }; > - > - device@1 { > - compatible = "arm,pl022-dummy"; > - #address-cells = <1>; > - #size-cells = <1>; > - reg = <1>; /* Chip select 1 */ > - spi-max-frequency = <9600000>; > - spi-cpha; > - }; > - > - device@2 { > - compatible = "arm,pl022-dummy"; > - #address-cells = <1>; > - #size-cells = <1>; > - reg = <2>; /* Chip select 2 */ > - spi-max-frequency = <19200000>; > - spi-cpol; > - spi-cpha; > - }; > - > - device@3 { > - compatible = "arm,pl022-dummy"; > - #address-cells = <1>; > - #size-cells = <1>; > - reg = <3>; /* Chip select 3 */ > - spi-max-frequency = <19200000>; > - spi-cpol; > - spi-cpha; > - spi-cs-high; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml > new file mode 100644 > index 000000000000..aa5756f7ba85 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml > @@ -0,0 +1,82 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/qcom,spi-qup.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Universal Peripheral (QUP) Serial Peripheral Interface (SPI) > + > +maintainers: > + - Andy Gross <agross@kernel.org> > + - Bjorn Andersson <bjorn.andersson@linaro.org> > + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > + > +description: > + The QUP core is an AHB slave that provides a common data path (an output FIFO > + and an input FIFO) for serial peripheral interface (SPI) mini-core. > + > + SPI in master mode supports up to 50MHz, up to four chip selects, > + programmable data path from 4 bits to 32 bits and numerous protocol variants. > + > +allOf: > + - $ref: /spi/spi-controller.yaml# Same thing for reference here as we discussed on other thread. > + > +properties: > + compatible: > + enum: > + - qcom,spi-qup-v1.1.1 # for 8660, 8960 and 8064 > + - qcom,spi-qup-v2.1.1 # for 8974 and later > + - qcom,spi-qup-v2.2.1 # for 8974 v2 and later > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: core > + - const: iface > + > + dmas: > + maxItems: 2 > + > + dma-names: > + items: > + - const: tx > + - const: rx Just wanted to confirm one thing, did you try with rx-tx? As once I noticed for some other spec, that warnings were reduced when order was reversed as most of the DTs follow rx-tx order. We can keep order which disturb less DTs. > + > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - clocks > + - clock-names > + - interrupts > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/qcom,gcc-msm8996.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + spi@7575000 { > + compatible = "qcom,spi-qup-v2.2.1"; > + reg = <0x07575000 0x600>; > + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&gcc GCC_BLSP1_QUP1_SPI_APPS_CLK>, > + <&gcc GCC_BLSP1_AHB_CLK>; > + clock-names = "core", > + "iface"; clock-names can be written in one line. > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&blsp1_spi1_default>; > + pinctrl-1 = <&blsp1_spi1_sleep>; > + dmas = <&blsp1_dma 12>, <&blsp1_dma 13>; > + dma-names = "tx", "rx"; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > -- > 2.32.0 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] spi: dt-bindings: qcom,spi-qup: convert to dtschema 2022-03-30 11:42 ` Kuldeep Singh @ 2022-03-30 11:45 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-03-30 11:45 UTC (permalink / raw) To: Kuldeep Singh Cc: linux-kernel, Andy Gross, Bjorn Andersson, Mark Brown, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, linux-spi, devicetree On 30/03/2022 13:42, Kuldeep Singh wrote: > On Tue, Mar 29, 2022 at 01:29:02PM +0200, Krzysztof Kozlowski wrote: >> Convert the Qualcomm Universal Peripheral (QUP) Serial Peripheral >> Interface (SPI) bindings to DT Schema. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../devicetree/bindings/spi/qcom,spi-qup.txt | 103 ------------------ >> .../devicetree/bindings/spi/qcom,spi-qup.yaml | 82 ++++++++++++++ >> 2 files changed, 82 insertions(+), 103 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qup.txt >> create mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml >> >> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt >> deleted file mode 100644 >> index 5c090771c016..000000000000 >> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt >> +++ /dev/null >> @@ -1,103 +0,0 @@ >> -Qualcomm Universal Peripheral (QUP) Serial Peripheral Interface (SPI) >> - >> -The QUP core is an AHB slave that provides a common data path (an output FIFO >> -and an input FIFO) for serial peripheral interface (SPI) mini-core. >> - >> -SPI in master mode supports up to 50MHz, up to four chip selects, programmable >> -data path from 4 bits to 32 bits and numerous protocol variants. >> - >> -Required properties: >> -- compatible: Should contain: >> - "qcom,spi-qup-v1.1.1" for 8660, 8960 and 8064. >> - "qcom,spi-qup-v2.1.1" for 8974 and later >> - "qcom,spi-qup-v2.2.1" for 8974 v2 and later. >> - >> -- reg: Should contain base register location and length >> -- interrupts: Interrupt number used by this controller >> - >> -- clocks: Should contain the core clock and the AHB clock. >> -- clock-names: Should be "core" for the core clock and "iface" for the >> - AHB clock. >> - >> -- #address-cells: Number of cells required to define a chip select >> - address on the SPI bus. Should be set to 1. >> -- #size-cells: Should be zero. >> - >> -Optional properties: >> -- spi-max-frequency: Specifies maximum SPI clock frequency, >> - Units - Hz. Definition as per >> - Documentation/devicetree/bindings/spi/spi-bus.txt >> -- num-cs: total number of chipselects >> -- cs-gpios: should specify GPIOs used for chipselects. >> - The gpios will be referred to as reg = <index> in the SPI child >> - nodes. If unspecified, a single SPI device without a chip >> - select can be used. >> - >> -- dmas: Two DMA channel specifiers following the convention outlined >> - in bindings/dma/dma.txt >> -- dma-names: Names for the dma channels, if present. There must be at >> - least one channel named "tx" for transmit and named "rx" for >> - receive. >> - >> -SPI slave nodes must be children of the SPI master node and can contain >> -properties described in Documentation/devicetree/bindings/spi/spi-bus.txt >> - >> -Example: >> - >> - spi_8: spi@f9964000 { /* BLSP2 QUP2 */ >> - >> - compatible = "qcom,spi-qup-v2"; >> - #address-cells = <1>; >> - #size-cells = <0>; >> - reg = <0xf9964000 0x1000>; >> - interrupts = <0 102 0>; >> - spi-max-frequency = <19200000>; >> - >> - clocks = <&gcc GCC_BLSP2_QUP2_SPI_APPS_CLK>, <&gcc GCC_BLSP2_AHB_CLK>; >> - clock-names = "core", "iface"; >> - >> - dmas = <&blsp1_bam 13>, <&blsp1_bam 12>; >> - dma-names = "rx", "tx"; >> - >> - pinctrl-names = "default"; >> - pinctrl-0 = <&spi8_default>; >> - >> - device@0 { >> - compatible = "arm,pl022-dummy"; >> - #address-cells = <1>; >> - #size-cells = <1>; >> - reg = <0>; /* Chip select 0 */ >> - spi-max-frequency = <19200000>; >> - spi-cpol; >> - }; >> - >> - device@1 { >> - compatible = "arm,pl022-dummy"; >> - #address-cells = <1>; >> - #size-cells = <1>; >> - reg = <1>; /* Chip select 1 */ >> - spi-max-frequency = <9600000>; >> - spi-cpha; >> - }; >> - >> - device@2 { >> - compatible = "arm,pl022-dummy"; >> - #address-cells = <1>; >> - #size-cells = <1>; >> - reg = <2>; /* Chip select 2 */ >> - spi-max-frequency = <19200000>; >> - spi-cpol; >> - spi-cpha; >> - }; >> - >> - device@3 { >> - compatible = "arm,pl022-dummy"; >> - #address-cells = <1>; >> - #size-cells = <1>; >> - reg = <3>; /* Chip select 3 */ >> - spi-max-frequency = <19200000>; >> - spi-cpol; >> - spi-cpha; >> - spi-cs-high; >> - }; >> - }; >> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml >> new file mode 100644 >> index 000000000000..aa5756f7ba85 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qup.yaml >> @@ -0,0 +1,82 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/spi/qcom,spi-qup.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Universal Peripheral (QUP) Serial Peripheral Interface (SPI) >> + >> +maintainers: >> + - Andy Gross <agross@kernel.org> >> + - Bjorn Andersson <bjorn.andersson@linaro.org> >> + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> + >> +description: >> + The QUP core is an AHB slave that provides a common data path (an output FIFO >> + and an input FIFO) for serial peripheral interface (SPI) mini-core. >> + >> + SPI in master mode supports up to 50MHz, up to four chip selects, >> + programmable data path from 4 bits to 32 bits and numerous protocol variants. >> + >> +allOf: >> + - $ref: /spi/spi-controller.yaml# > > Same thing for reference here as we discussed on other thread. Yes. > >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,spi-qup-v1.1.1 # for 8660, 8960 and 8064 >> + - qcom,spi-qup-v2.1.1 # for 8974 and later >> + - qcom,spi-qup-v2.2.1 # for 8974 v2 and later >> + >> + clocks: >> + maxItems: 2 >> + >> + clock-names: >> + items: >> + - const: core >> + - const: iface >> + >> + dmas: >> + maxItems: 2 >> + >> + dma-names: >> + items: >> + - const: tx >> + - const: rx > > Just wanted to confirm one thing, did you try with rx-tx? > As once I noticed for some other spec, that warnings were reduced when > order was reversed as most of the DTs follow rx-tx order. > > We can keep order which disturb less DTs. Yeah, I tried. The amount is more or less the same, so I went with tx-rx as mentioned in original bindings. > >> + >> + interrupts: >> + maxItems: 1 >> + >> + reg: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - clocks >> + - clock-names >> + - interrupts >> + - reg >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/qcom,gcc-msm8996.h> >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + >> + spi@7575000 { >> + compatible = "qcom,spi-qup-v2.2.1"; >> + reg = <0x07575000 0x600>; >> + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&gcc GCC_BLSP1_QUP1_SPI_APPS_CLK>, >> + <&gcc GCC_BLSP1_AHB_CLK>; >> + clock-names = "core", >> + "iface"; > > clock-names can be written in one line. I made it on purpose to align the format with clocks. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-30 11:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220329112902.252937-1-krzysztof.kozlowski@linaro.org>
2022-03-29 11:29 ` [PATCH 4/4] spi: dt-bindings: qcom,spi-qup: convert to dtschema Krzysztof Kozlowski
2022-03-29 11:38 ` Krzysztof Kozlowski
2022-03-29 19:05 ` Rob Herring
2022-03-29 19:11 ` Krzysztof Kozlowski
2022-03-30 11:42 ` Kuldeep Singh
2022-03-30 11:45 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).