From: Thor Thayer <tthayer@opensource.altera.com>
To: Mark Brown <broonie@kernel.org>
Cc: <jkosina@suse.cz>, <pawel.moll@arm.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <dinguyen@opensource.altera.com>,
<linux-spi@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<devicetree@vger.kernel.org>, <tthayer.linux@gmail.com>,
<tthayer@altera.com>, <axel.lin@ingics.com>, <baruch@tkos.co.il>,
<andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 2/2] arm: dts: socfpga: Add SPI nodes & update copyright.
Date: Wed, 8 Oct 2014 13:05:35 -0500 [thread overview]
Message-ID: <54357CEF.8000108@opensource.altera.com> (raw)
In-Reply-To: <20141007231200.GR4609@sirena.org.uk>
On 10/07/2014 06:12 PM, Mark Brown wrote:
> On Tue, Oct 07, 2014 at 02:48:17PM -0500,tthayer@opensource.altera.com wrote:
>
>> Add 2 SPI nodes to SOCFPGA device tree. Update copyright.
>> Update spi-dw.txt with bus-num as an optional property.
> Again, this is just randomly mixing multiple changes. Also why are we
> adding a bus-num property - bus numbers are an implementation detail of
> Linux and I can't see any reason to put them in the device tree. If
> there were one the binding would need to explain what they were.
OK. I will leave these changes out of the patch.
Sorry about the noise. I saw the spi-summary referenced the bus-num
spi<bus-num>.<chip-select> so I thought it could be added to the
bindings document. The bus was defaulting to 32766 if the bus wasn't
assigned from the device tree (spi32766.0).
Thanks,
Thor
prev parent reply other threads:[~2014-10-08 18:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 19:48 [PATCH 0/2] SPI: Enable devicetree spi child nodes tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
[not found] ` <1412711297-31857-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-07 19:48 ` [PATCH 1/2] spi: dw: Initialize of_node to discover DT node children tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
[not found] ` <1412711297-31857-2-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-07 19:42 ` Dinh Nguyen
[not found] ` <54344237.9010809-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-07 19:55 ` Thor Thayer
2014-10-07 20:40 ` Mark Brown
[not found] ` <20141007204026.GK4609-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-10-07 20:59 ` Thor Thayer
2014-10-08 8:17 ` Andy Shevchenko
2014-10-08 18:27 ` Thor Thayer
2014-10-07 19:48 ` [PATCH 2/2] arm: dts: socfpga: Add SPI nodes & update copyright tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
[not found] ` <1412711297-31857-3-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-07 20:31 ` Steffen Trumtrar
2014-10-07 20:55 ` Thor Thayer
[not found] ` <5434535A.9070101-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-08 8:01 ` Steffen Trumtrar
2014-10-08 18:07 ` Thor Thayer
2014-10-07 23:12 ` Mark Brown
2014-10-08 18:05 ` Thor Thayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54357CEF.8000108@opensource.altera.com \
--to=tthayer@opensource.altera.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axel.lin@ingics.com \
--cc=baruch@tkos.co.il \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jkosina@suse.cz \
--cc=linux-doc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tthayer.linux@gmail.com \
--cc=tthayer@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).