Re: [PATCH v3 3/3] spi:amd:Fix for compilation error for non X86 platforms. - Shah, Nehal-bakulchandra

From: "Shah, Nehal-bakulchandra" <nehal-bakulchandra.shah@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	Liang Liang <liang.liang@amd.com>
Subject: Re: [PATCH v3 3/3] spi:amd:Fix for compilation error for non X86 platforms.
Date: Tue, 27 Jul 2021 17:24:46 +0530	[thread overview]
Message-ID: <59d72fb4-3623-be6e-72d7-e47c5d434576@amd.com> (raw)
In-Reply-To: <20210630124717.GE5106@sirena.org.uk>

Hi Mark
On 6/30/2021 6:17 PM, Mark Brown wrote:
> On Wed, Jun 30, 2021 at 05:34:25PM +0530, Nehal Bakulchandra Shah wrote:
>
>> Update the KConfig with dependency for ACPI as driver is only
>> supported for x86 platform. This fixes the compilation error
>> reported by kernel test robot.
> If one of the earlier patches in the series fails to build you need to
> fix that patch so you don't break bisection or cause people to spend
> time finding errors in the earlier patches you fix later.
>
> In any case this doesn't do what the commit log says, ACPI is supported
> on at least arm64 so if you genuinely need an x86 dependency ACPI isn't
> going to cut it and COMPILE_TEST means the driver will still be built on
> everything.  I don't recall anything from 0day that looked like it was
> anything to do with dependencies though.

Thanks for reviewing this patch series, however we have decided to drop 
this patch series and our partner (Cirrus) will send the new patch 
series with

more finer changes.

Regards

Nehal Shah