From: "Shah, Nehal-bakulchandra" <nehal-bakulchandra.shah@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Liang Liang <liang.liang@amd.com>
Subject: Re: [PATCH v3 3/3] spi:amd:Fix for compilation error for non X86 platforms.
Date: Wed, 30 Jun 2021 20:14:12 +0530 [thread overview]
Message-ID: <fc174349-d2f6-6721-51e4-a23ae5a8262f@amd.com> (raw)
In-Reply-To: <20210630124717.GE5106@sirena.org.uk>
Hi Mark
On 6/30/2021 6:17 PM, Mark Brown wrote:
> On Wed, Jun 30, 2021 at 05:34:25PM +0530, Nehal Bakulchandra Shah wrote:
>
>> Update the KConfig with dependency for ACPI as driver is only
>> supported for x86 platform. This fixes the compilation error
>> reported by kernel test robot.
> If one of the earlier patches in the series fails to build you need to
> fix that patch so you don't break bisection or cause people to spend
> time finding errors in the earlier patches you fix later.
>
> In any case this doesn't do what the commit log says, ACPI is supported
> on at least arm64 so if you genuinely need an x86 dependency ACPI isn't
> going to cut it and COMPILE_TEST means the driver will still be built on
> everything. I don't recall anything from 0day that looked like it was
> anything to do with dependencies though.
so now should i RESEND this patch with suggested changes,i.e removing
ACPI depedency
change and removing COMPILE_TEST?
Thanks
Nehal
next prev parent reply other threads:[~2021-06-30 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 12:04 [PATCH v3 0/3] spi:amd:Support for new generation of AMD SOCs Nehal Bakulchandra Shah
2021-06-30 12:04 ` [PATCH v3 1/3] spi:amd: Add support for latest platform Nehal Bakulchandra Shah
2021-06-30 12:04 ` [PATCH v3 2/3] spi:amd: Fix for transfer large size of data Nehal Bakulchandra Shah
2021-06-30 12:04 ` [PATCH v3 3/3] spi:amd:Fix for compilation error for non X86 platforms Nehal Bakulchandra Shah
2021-06-30 12:47 ` Mark Brown
2021-06-30 14:44 ` Shah, Nehal-bakulchandra [this message]
2021-06-30 15:57 ` Mark Brown
2021-07-27 11:54 ` Shah, Nehal-bakulchandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc174349-d2f6-6721-51e4-a23ae5a8262f@amd.com \
--to=nehal-bakulchandra.shah@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=broonie@kernel.org \
--cc=liang.liang@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).