linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.ml.walleij-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Kevin Wells <kevin.wells-3arQi8VN3Tc@public.gmane.org>
Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Subject: Re: PATCH [1/1] SPI: AMBA_PL022: Limit TX FIFO fills based on current RX FIFO used
Date: Fri, 22 Jan 2010 13:56:26 +0100	[thread overview]
Message-ID: <63386a3d1001220456p484efc7fm811ae2240698cbdf@mail.gmail.com> (raw)
In-Reply-To: <083DF309106F364B939360100EC290F805C4BF1E97-SIPbe8o7cfX8DdpCu65jn8FrZmdRls4ZQQ4Iyu8u01E@public.gmane.org>

2010/1/20 Kevin Wells <kevin.wells-3arQi8VN3Tc@public.gmane.org>:

> Added logic to cap TX FIFO fill size based on current free RX
> FIFO entries instead of TX status flags. This is to prevent
> an issue with RX FIFO overflows

Excellent patch and works like a charm on the U300. My loopback code
would generate
spurious overfill errors before and now it *never* fails so you hit
exactly the right spot.
I remember being intrigued by this when I worked on the driver and now
it is finally
nailed.

As some sort of maintainer of this file I have signed it off and put
it into Russells
patch tracker for inclusion, OK? See;
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=5893/1

Linus Walleij

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev

  parent reply	other threads:[~2010-01-22 12:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-20 18:38 Kevin Wells
     [not found] ` <083DF309106F364B939360100EC290F805C4BF1E97-SIPbe8o7cfX8DdpCu65jn8FrZmdRls4ZQQ4Iyu8u01E@public.gmane.org>
2010-01-22 12:56   ` Linus Walleij [this message]
     [not found]     ` <63386a3d1001220456p484efc7fm811ae2240698cbdf-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-03 17:48       ` Grant Likely
     [not found]         ` <fa686aa41002030948g6359ef3o4c3a7b265490b93f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-03 22:15           ` Linus Walleij
2010-05-19 10:56           ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63386a3d1001220456p484efc7fm811ae2240698cbdf@mail.gmail.com \
    --to=linus.ml.walleij-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=kevin.wells-3arQi8VN3Tc@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --subject='Re: PATCH [1/1] SPI: AMBA_PL022: Limit TX FIFO fills based on current RX FIFO used' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).