From: Michael Walle <michael@walle.cc>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: linux-spi@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org,
Sumit Semwal <sumit.semwal@linaro.org>,
Mark Brown <broonie@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH] spi: spi-fsl-dspi: fix DMA mapping
Date: Tue, 10 Mar 2020 15:12:45 +0100 [thread overview]
Message-ID: <76923af394f334337a3cac125c270087@walle.cc> (raw)
In-Reply-To: <CA+h21hqMoPhbq8YG0UeV1kP0iXApYsJvb9MZjPGX54dm2U-KnQ@mail.gmail.com>
Am 2020-03-10 14:02, schrieb Vladimir Oltean:
> On Tue, 10 Mar 2020 at 10:12, Michael Walle <michael@walle.cc> wrote:
>>
>> Am 2020-03-10 08:40, schrieb Michael Walle:
>> > Am 2020-03-10 08:33, schrieb Michael Walle:
>> >> Use the correct device to request the DMA mapping. Otherwise the IOMMU
>> >> doesn't get the mapping and it will generate a page fault.
>> >>
>> >> The error messages look like:
>> >> [ 3.008452] arm-smmu 5000000.iommu: Unhandled context fault:
>> >> fsr=0x402, iova=0xf9800000, fsynr=0x3f0022, cbfrsynra=0x828, cb=8
>> >> [ 3.020123] arm-smmu 5000000.iommu: Unhandled context fault:
>> >> fsr=0x402, iova=0xf9800000, fsynr=0x3f0022, cbfrsynra=0x828, cb=8
>> >>
>> >> This was tested on a custom board with a LS1028A SoC.
>> >
>> > Oh fu.. please disregard this patch. DMA mapping still isn't working.
>> > Somehow I missed that the transfer mode was turned back to its default
>> > XSPI mode.
>>
>> Damn. I need more coffee.. this patch IS working. Only the first probe
>> fails due to EPROBE_DEFER.
>>
>> [ 2.539706] fsl-dspi 2120000.spi: rx dma channel not available
>> (-517)
>> [ 2.546200] fsl-dspi 2120000.spi: can't get dma channels
>> [ 3.622774] spi-nor spi1.0: w25q128fw (16384 Kbytes)
>>
>> -michael
>
> I'm testing LS1028A with IOMMU_DEFAULT_PASSTHROUGH=y and I didn't have
> time to change my setup now. I've also sent a v3 to my patch series
> which is going to conflict with this one, sorry.
No worries, its easy enough to rebase.
> I would have picked
> your patch up with my series but I didn't have the right environment
> to test it.
I'll resend a v2 once your series is working.
-michael
next prev parent reply other threads:[~2020-03-10 14:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 7:33 [PATCH] spi: spi-fsl-dspi: fix DMA mapping Michael Walle
[not found] ` <20200310073313.21277-1-michael-QKn5cuLxLXY@public.gmane.org>
2020-03-10 7:40 ` Michael Walle
2020-03-10 8:10 ` Michael Walle
[not found] ` <ea6ffa30ddc2459d07935e5e61a41172-QKn5cuLxLXY@public.gmane.org>
2020-03-10 13:02 ` Vladimir Oltean
2020-03-10 14:12 ` Michael Walle [this message]
[not found] ` <76923af394f334337a3cac125c270087-QKn5cuLxLXY@public.gmane.org>
2020-03-10 17:14 ` Mark Brown
[not found] ` <20200310171403.GL4106-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2020-03-10 17:26 ` Vladimir Oltean
2020-03-10 18:35 ` Applied "spi: spi-fsl-dspi: fix DMA mapping" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76923af394f334337a3cac125c270087@walle.cc \
--to=michael@walle.cc \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sumit.semwal@linaro.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).