* Re: [PATCH] spi: img-spfi: Add missing pm_runtime_put() call in img_spfi_resume()
@ 2020-06-02 9:30 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-06-02 9:30 UTC (permalink / raw)
To: Navid Emamdoost, linux-spi
Cc: Navid Emamdoost, Kangjie Lu, Stephen McCamant, Qiushi Wu,
Dinghao Liu, Mark Brown, LKML, kernel-janitors
Please avoid a typo in the patch subject (by a possible alternative?).
> Call to pm_runtime_get_sync increments counter even in case of
> failure leading to incorrect ref count.
> Call pm_runtime_put if pm_runtime_get_sync fails.
How do you think about a wording variant like the following?
Change description:
The PM runtime reference counter is generally incremented by a call of
the function “pm_runtime_get_sync”.
Thus call the function “pm_runtime_put” also in one error case
to keep the reference counting consistent.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-02 9:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 9:30 [PATCH] spi: img-spfi: Add missing pm_runtime_put() call in img_spfi_resume() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).