From: Hans Verkuil <hverkuil@xs4all.nl>
To: "Dmitry Osipenko" <digetx@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Viresh Kumar" <vireshk@kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Peter De Schrijver" <pdeschrijver@nvidia.com>,
"Mikko Perttunen" <mperttunen@nvidia.com>,
"Peter Chen" <peter.chen@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Lee Jones" <lee.jones@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Nishanth Menon" <nm@ti.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Richard Weinberger" <richard@nod.at>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Lucas Stach" <dev@lynxeye.de>, "Stefan Agner" <stefan@agner.ch>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-pm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-staging@lists.linux.dev, linux-spi@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-mmc@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v11 24/34] media: staging: tegra-vde: Support generic power domain
Date: Mon, 13 Sep 2021 12:37:51 +0200 [thread overview]
Message-ID: <77d205ef-469d-cfa3-f742-b009b2b05992@xs4all.nl> (raw)
In-Reply-To: <20210912200832.12312-25-digetx@gmail.com>
On 12/09/2021 22:08, Dmitry Osipenko wrote:
> Currently driver supports legacy power domain API, this patch adds generic
> power domain support. This allows us to utilize a modern GENPD API for
> newer device-trees.
>
> Tested-by: Peter Geis <pgwipeout@gmail.com> # Ouya T30
> Tested-by: Paul Fertser <fercerpav@gmail.com> # PAZ00 T20
> Tested-by: Nicolas Chauvet <kwizart@gmail.com> # PAZ00 T20 and TK1 T124
> Tested-by: Matt Merhar <mattmerhar@protonmail.com> # Ouya T30
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Regards,
Hans
> ---
> drivers/staging/media/tegra-vde/vde.c | 57 +++++++++++++++++++++------
> 1 file changed, 46 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/media/tegra-vde/vde.c b/drivers/staging/media/tegra-vde/vde.c
> index ed4c1250b303..bb3079a2c0b5 100644
> --- a/drivers/staging/media/tegra-vde/vde.c
> +++ b/drivers/staging/media/tegra-vde/vde.c
> @@ -20,6 +20,7 @@
> #include <linux/slab.h>
> #include <linux/uaccess.h>
>
> +#include <soc/tegra/common.h>
> #include <soc/tegra/pmc.h>
>
> #include "uapi.h"
> @@ -920,13 +921,17 @@ static __maybe_unused int tegra_vde_runtime_suspend(struct device *dev)
> struct tegra_vde *vde = dev_get_drvdata(dev);
> int err;
>
> - err = tegra_powergate_power_off(TEGRA_POWERGATE_VDEC);
> - if (err) {
> - dev_err(dev, "Failed to power down HW: %d\n", err);
> - return err;
> + if (!dev->pm_domain) {
> + err = tegra_powergate_power_off(TEGRA_POWERGATE_VDEC);
> + if (err) {
> + dev_err(dev, "Failed to power down HW: %d\n", err);
> + return err;
> + }
> }
>
> clk_disable_unprepare(vde->clk);
> + reset_control_release(vde->rst);
> + reset_control_release(vde->rst_mc);
>
> return 0;
> }
> @@ -936,14 +941,41 @@ static __maybe_unused int tegra_vde_runtime_resume(struct device *dev)
> struct tegra_vde *vde = dev_get_drvdata(dev);
> int err;
>
> - err = tegra_powergate_sequence_power_up(TEGRA_POWERGATE_VDEC,
> - vde->clk, vde->rst);
> + err = reset_control_acquire(vde->rst_mc);
> if (err) {
> - dev_err(dev, "Failed to power up HW : %d\n", err);
> + dev_err(dev, "Failed to acquire mc reset: %d\n", err);
> return err;
> }
>
> + err = reset_control_acquire(vde->rst);
> + if (err) {
> + dev_err(dev, "Failed to acquire reset: %d\n", err);
> + goto release_mc_reset;
> + }
> +
> + if (!dev->pm_domain) {
> + err = tegra_powergate_sequence_power_up(TEGRA_POWERGATE_VDEC,
> + vde->clk, vde->rst);
> + if (err) {
> + dev_err(dev, "Failed to power up HW : %d\n", err);
> + goto release_reset;
> + }
> + }
> +
> + err = clk_prepare_enable(vde->clk);
> + if (err) {
> + dev_err(dev, "Failed to enable clock: %d\n", err);
> + goto release_reset;
> + }
> +
> return 0;
> +
> +release_reset:
> + reset_control_release(vde->rst);
> +release_mc_reset:
> + reset_control_release(vde->rst_mc);
> +
> + return err;
> }
>
> static int tegra_vde_probe(struct platform_device *pdev)
> @@ -1001,14 +1033,14 @@ static int tegra_vde_probe(struct platform_device *pdev)
> return err;
> }
>
> - vde->rst = devm_reset_control_get(dev, NULL);
> + vde->rst = devm_reset_control_get_exclusive_released(dev, NULL);
> if (IS_ERR(vde->rst)) {
> err = PTR_ERR(vde->rst);
> dev_err(dev, "Could not get VDE reset %d\n", err);
> return err;
> }
>
> - vde->rst_mc = devm_reset_control_get_optional(dev, "mc");
> + vde->rst_mc = devm_reset_control_get_optional_exclusive_released(dev, "mc");
> if (IS_ERR(vde->rst_mc)) {
> err = PTR_ERR(vde->rst_mc);
> dev_err(dev, "Could not get MC reset %d\n", err);
> @@ -1066,6 +1098,10 @@ static int tegra_vde_probe(struct platform_device *pdev)
> pm_runtime_use_autosuspend(dev);
> pm_runtime_set_autosuspend_delay(dev, 300);
>
> + err = devm_tegra_core_dev_init_opp_table_common(dev);
> + if (err)
> + goto err_pm_runtime;
> +
> /*
> * VDE partition may be left ON after bootloader, hence let's
> * power-cycle it in order to put hardware into a predictable lower
> @@ -1133,8 +1169,7 @@ static void tegra_vde_shutdown(struct platform_device *pdev)
> * On some devices bootloader isn't ready to a power-gated VDE on
> * a warm-reboot, machine will hang in that case.
> */
> - if (pm_runtime_status_suspended(&pdev->dev))
> - tegra_vde_runtime_resume(&pdev->dev);
> + pm_runtime_get_sync(&pdev->dev);
> }
>
> static __maybe_unused int tegra_vde_pm_suspend(struct device *dev)
>
next prev parent reply other threads:[~2021-09-13 10:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 20:07 [PATCH v11 00/34] NVIDIA Tegra power management patches for 5.16 Dmitry Osipenko
2021-09-12 20:07 ` [PATCH v11 01/34] opp: Change type of dev_pm_opp_attach_genpd(names) argument Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 02/34] soc/tegra: Add devm_tegra_core_dev_init_opp_table_common() Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 03/34] soc/tegra: pmc: Disable PMC state syncing Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 04/34] soc/tegra: Don't print error message when OPPs not available Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 05/34] dt-bindings: clock: tegra-car: Document new clock sub-nodes Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 06/34] clk: tegra: Support runtime PM and power domain Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 07/34] dt-bindings: host1x: Document OPP and power domain properties Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 08/34] dt-bindings: host1x: Document Memory Client resets of Host1x, GR2D and GR3D Dmitry Osipenko
2021-09-16 19:49 ` Rob Herring
2021-09-12 20:08 ` [PATCH v11 09/34] gpu: host1x: Add runtime PM and OPP support Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 10/34] gpu: host1x: Add host1x_channel_stop() Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 11/34] drm/tegra: dc: Support OPP and SoC core voltage scaling Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 12/34] drm/tegra: hdmi: Add OPP support Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 13/34] drm/tegra: gr2d: Support generic power domain and runtime PM Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 14/34] drm/tegra: gr3d: " Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 15/34] drm/tegra: vic: Support system suspend Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 16/34] usb: chipidea: tegra: Add runtime PM and OPP support Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 17/34] bus: tegra-gmi: " Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 18/34] pwm: tegra: " Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 19/34] mmc: sdhci-tegra: " Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 20/34] mtd: rawnand: tegra: " Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 21/34] spi: tegra20-slink: Add " Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 22/34] media: dt: bindings: tegra-vde: Convert to schema Dmitry Osipenko
2021-09-13 10:36 ` Hans Verkuil
2021-09-12 20:08 ` [PATCH v11 23/34] media: dt: bindings: tegra-vde: Document OPP and power domain Dmitry Osipenko
2021-09-13 10:36 ` Hans Verkuil
2021-09-12 20:08 ` [PATCH v11 24/34] media: staging: tegra-vde: Support generic " Dmitry Osipenko
2021-09-13 10:37 ` Hans Verkuil [this message]
2021-09-12 20:08 ` [PATCH v11 25/34] soc/tegra: fuse: Reset hardware Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 26/34] soc/tegra: fuse: Use resource-managed helpers Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 27/34] soc/tegra: regulators: Prepare for suspend Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 28/34] soc/tegra: pmc: Change name of core power domain Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 29/34] soc/tegra: pmc: Enable core domain support for Tegra20 and Tegra30 Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 30/34] ARM: tegra: Add OPP tables and power domains to Tegra20 device-trees Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 31/34] ARM: tegra: Add OPP tables and power domains to Tegra30 device-trees Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 32/34] ARM: tegra: Add Memory Client resets to Tegra20 GR2D, GR3D and Host1x Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 33/34] ARM: tegra: Add Memory Client resets to Tegra30 " Dmitry Osipenko
2021-09-12 20:08 ` [PATCH v11 34/34] ARM: tegra20/30: Disable unused host1x hardware Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77d205ef-469d-cfa3-f742-b009b2b05992@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=adrian.hunter@intel.com \
--cc=broonie@kernel.org \
--cc=dev@lynxeye.de \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=mperttunen@nvidia.com \
--cc=mturquette@baylibre.com \
--cc=nm@ti.com \
--cc=pdeschrijver@nvidia.com \
--cc=peter.chen@kernel.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).