From: Grant Likely <grant.likely@secretlab.ca>
To: Hannu Heikkinen <ext-hannu.m.heikkinen@nokia.com>
Cc: linux-omap@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
dbrownell@users.sourceforge.net, ext-phil.2.carmody@nokia.com
Subject: Re: [PATCH 1/1] OMAP: McSPI: Off-by-one error in finding the right divisor
Date: Thu, 24 Feb 2011 09:10:52 -0700 [thread overview]
Message-ID: <AANLkTi==YjWgmqO2GVX-B=VMumsEUz4JiOKVtHbHVq5R@mail.gmail.com> (raw)
In-Reply-To: <20110224160045.GB17735@angua.secretlab.ca>
On Thu, Feb 24, 2011 at 9:00 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Thu, Feb 24, 2011 at 04:13:31PM +0200, Hannu Heikkinen wrote:
>> Off-by-one error, gave erroneous divisor value 16 if speed_hz is over zero but
>> less than OMAP2_MCSPI_MAX_FREQ / (1 << 15), that is, [1..1463].
>>
>> Also few overly complex bit shifts in divisor fixed.
>>
>> Also one dev_dgb line fixed, which indicated max speed exceeding transfer speed.
>>
>> Introducing a new function omap2_mcspi_calc_divisor() for getting the right
>> divisor in omap2_mcspi_setup_transfer().
>>
>> Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
>> Signed-off-by: Hannu Heikkinen <ext-hannu.m.heikkinen@nokia.com>
>
> Applied, thanks
Patch adds a build warning:
CC drivers/spi/omap2_mcspi.o
linux-2.6/drivers/spi/omap2_mcspi.c: In function 'omap2_mcspi_setup_transfer':
linux-2.6/drivers/spi/omap2_mcspi.c:687: warning: comparison of
distinct pointer types lacks a cast
I've dropped it, please fix up and resubmit.
Thanks,
g.
prev parent reply other threads:[~2011-02-24 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 14:13 [PATCH 1/1] OMAP: McSPI: Off-by-one error in finding the right divisor Hannu Heikkinen
2011-02-24 16:00 ` Grant Likely
2011-02-24 16:10 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi==YjWgmqO2GVX-B=VMumsEUz4JiOKVtHbHVq5R@mail.gmail.com' \
--to=grant.likely@secretlab.ca \
--cc=dbrownell@users.sourceforge.net \
--cc=ext-hannu.m.heikkinen@nokia.com \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).