From: "Nori, Sekhar" <nsekhar-l0cyMroinI0@public.gmane.org>
To: "Chemparathy, Cyril" <cyril-l0cyMroinI0@public.gmane.org>,
"davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org"
<davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org>,
"spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<spi
Cc: "akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org"
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
"alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org"
<alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
Subject: RE: [PATCH v7 11/12] davinci: add tnetv107x evm backlight device
Date: Thu, 9 Dec 2010 14:25:49 +0530 [thread overview]
Message-ID: <B85A65D85D7EB246BE421B3FB0FBB5930247CD83E1__324.203589889471$1291885021$gmane$org@dbde02.ent.ti.com> (raw)
In-Reply-To: <1291733522-3626-12-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
Hi Cyril,
On Tue, Dec 07, 2010 at 20:22:01, Chemparathy, Cyril wrote:
> The tnetv107x evm board has a backlight device that is connected on one of the
> SSP ports. This patch adds the board definitions necessary to plug the
> backlight driver to the GPIO corresponding to this SSP pin.
>
> Signed-off-by: Cyril Chemparathy <cyril-l0cyMroinI0@public.gmane.org>
> ---
> arch/arm/mach-davinci/board-tnetv107x-evm.c | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-tnetv107x-evm.c b/arch/arm/mach-davinci/board-tnetv107x-evm.c
> index e3863dd..ac62de2 100644
> --- a/arch/arm/mach-davinci/board-tnetv107x-evm.c
> +++ b/arch/arm/mach-davinci/board-tnetv107x-evm.c
> @@ -44,6 +44,7 @@
> #define EVM_MMC_WP_GPIO 21
> #define EVM_MMC_CD_GPIO 24
> #define EVM_SPI_CS_GPIO 54
> +#define EVM_BACKLIGHT_GPIO (SSP_GPIO_START + 2)
>
> static int initialize_gpio(int gpio, char *desc)
> {
> @@ -353,6 +354,12 @@ static struct spi_board_info spi_info[] __initconst = {
> },
> };
>
> +static struct platform_device backlight_device = {
> + .name = "tps6116x",
> + .id = -1,
> + .dev.platform_data = (void *)EVM_BACKLIGHT_GPIO,
> +};
> +
> static __init void tnetv107x_evm_board_init(void)
> {
> davinci_cfg_reg_list(sdio1_pins);
> @@ -364,6 +371,13 @@ static __init void tnetv107x_evm_board_init(void)
> spi_register_board_info(spi_info, ARRAY_SIZE(spi_info));
> }
>
> +static int __init tnetv107x_evm_late_init(void)
> +{
> + platform_device_register(&backlight_device);
> + return 0;
> +}
> +late_initcall(tnetv107x_evm_late_init);
This call should simply return if machine is not tnetv107x EVM.
I didn't follow the entire series but wondering why
platform device registration should be a late init call.
Typically the driver probe can be made a late init call
in case of init sequence dependencies.
Thanks,
Sekhar
------------------------------------------------------------------------------
This SF Dev2Dev email is sponsored by:
WikiLeaks The End of the Free Internet
http://p.sf.net/sfu/therealnews-com
next prev parent reply other threads:[~2010-12-09 8:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 14:51 [PATCH v7 00/12] tnetv107x ssp drivers Cyril Chemparathy
[not found] ` <1291733522-3626-1-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-12-07 14:51 ` [PATCH v7 01/12] misc: add driver for sequencer serial port Cyril Chemparathy
[not found] ` <1291733522-3626-2-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-12-11 0:13 ` Kevin Hilman
2010-12-07 14:51 ` [PATCH v7 02/12] davinci: add tnetv107x ssp platform device Cyril Chemparathy
2010-12-07 14:51 ` [PATCH v7 03/12] davinci: add ssp config for tnetv107x evm board Cyril Chemparathy
2010-12-07 14:51 ` [PATCH v7 04/12] spi: add ti-ssp spi master driver Cyril Chemparathy
[not found] ` <1291733522-3626-5-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-12-31 6:26 ` Grant Likely
2010-12-07 14:51 ` [PATCH v7 05/12] davinci: add spi devices on tnetv107x evm Cyril Chemparathy
2010-12-07 14:51 ` [PATCH v7 06/12] regulator: add driver for tps6524x regulator Cyril Chemparathy
[not found] ` <1291733522-3626-7-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-12-07 15:22 ` Mark Brown
[not found] ` <20101207152222.GD9689-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
2010-12-07 16:46 ` Cyril Chemparathy
2010-12-07 14:51 ` [PATCH v7 07/12] davinci: add tnetv107x evm regulators Cyril Chemparathy
2010-12-07 14:51 ` [PATCH v7 08/12] gpio: add ti-ssp gpio driver Cyril Chemparathy
[not found] ` <1291733522-3626-9-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-12-31 6:16 ` Grant Likely
2010-12-07 14:51 ` [PATCH v7 09/12] davinci: add tnetv107x evm ti-ssp gpio device Cyril Chemparathy
2010-12-07 14:52 ` [PATCH v7 10/12] backlight: add support for tps6116x controller Cyril Chemparathy
2010-12-07 14:52 ` [PATCH v7 11/12] davinci: add tnetv107x evm backlight device Cyril Chemparathy
[not found] ` <1291733522-3626-12-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-12-09 8:55 ` Nori, Sekhar [this message]
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB5930247CD83E1@dbde02.ent.ti.com>
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB5930247CD83E1-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-12-09 11:00 ` Nori, Sekhar
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB5930247CD84F4@dbde02.ent.ti.com>
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB5930247CD84F4-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-12-09 14:58 ` Cyril Chemparathy
[not found] ` <4D00EEA1.8070201-l0cyMroinI0@public.gmane.org>
2010-12-10 16:01 ` Nori, Sekhar
[not found] ` <B85A65D85D7EB246BE421B3FB0FBB5930247CD8CE8-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-12-10 16:56 ` Kevin Hilman
2010-12-07 14:52 ` [PATCH v7 12/12] davinci: add tnetv107x evm i2c eeprom device Cyril Chemparathy
2010-12-11 0:19 ` [PATCH v7 00/12] tnetv107x ssp drivers Kevin Hilman
[not found] ` <87r5dp6tzv.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2010-12-11 12:42 ` Mark Brown
[not found] ` <20101211124242.GE9380-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2010-12-30 21:05 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='B85A65D85D7EB246BE421B3FB0FBB5930247CD83E1__324.203589889471$1291885021$gmane$org@dbde02.ent.ti.com' \
--to=nsekhar-l0cymroini0@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
--cc=cyril-l0cyMroinI0@public.gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).