* [PATCH 2/7] dt-bindings: spi: flexspi: convert to json schema
[not found] <20210715082536.1882077-1-aisheng.dong@nxp.com>
@ 2021-07-15 8:25 ` Dong Aisheng
2021-07-15 9:25 ` [EXT] " Kuldeep Singh
0 siblings, 1 reply; 3+ messages in thread
From: Dong Aisheng @ 2021-07-15 8:25 UTC (permalink / raw)
To: devicetree
Cc: linux-arm-kernel, linux-imx, kernel, aisheng.dong, dongas86,
robh+dt, shawnguo, Ashish Kumar, Yogesh Gaur, Mark Brown,
linux-spi
Besides the conversion work, also added the missing clock property
in the original binding doc according to the current dts and driver
implementation. Otherwise, make dtbs_check will fail.
Also fixed example according to new jason schema.
Cc: Ashish Kumar <ashish.kumar@nxp.com>
Cc: Yogesh Gaur <yogeshgaur.83@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: linux-spi@vger.kernel.org
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
.../devicetree/bindings/spi/spi-nxp-fspi.txt | 44 ----------
.../devicetree/bindings/spi/spi-nxp-fspi.yaml | 87 +++++++++++++++++++
2 files changed, 87 insertions(+), 44 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
create mode 100644 Documentation/devicetree/bindings/spi/spi-nxp-fspi.yaml
diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
deleted file mode 100644
index 8f34a7c7d8b8..000000000000
--- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
+++ /dev/null
@@ -1,44 +0,0 @@
-* NXP Flex Serial Peripheral Interface (FSPI)
-
-Required properties:
- - compatible : Should be "nxp,lx2160a-fspi"
- "nxp,imx8qxp-fspi"
- "nxp,imx8mm-fspi"
- "nxp,imx8mp-fspi"
- "nxp,imx8dxl-fspi"
-
- - reg : First contains the register location and length,
- Second contains the memory mapping address and length
- - reg-names : Should contain the resource reg names:
- - fspi_base: configuration register address space
- - fspi_mmap: memory mapped address space
- - interrupts : Should contain the interrupt for the device
-
-Required SPI slave node properties:
- - reg : There are two buses (A and B) with two chip selects each.
- This encodes to which bus and CS the flash is connected:
- - <0>: Bus A, CS 0
- - <1>: Bus A, CS 1
- - <2>: Bus B, CS 0
- - <3>: Bus B, CS 1
-
-Example showing the usage of two SPI NOR slave devices on bus A:
-
-fspi0: spi@20c0000 {
- compatible = "nxp,lx2160a-fspi";
- reg = <0x0 0x20c0000 0x0 0x10000>, <0x0 0x20000000 0x0 0x10000000>;
- reg-names = "fspi_base", "fspi_mmap";
- interrupts = <0 25 0x4>; /* Level high type */
- clocks = <&clockgen 4 3>, <&clockgen 4 3>;
- clock-names = "fspi_en", "fspi";
-
- mt35xu512aba0: flash@0 {
- reg = <0>;
- ....
- };
-
- mt35xu512aba1: flash@1 {
- reg = <1>;
- ....
- };
-};
diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.yaml b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.yaml
new file mode 100644
index 000000000000..ca43583947ea
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.yaml
@@ -0,0 +1,87 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/spi/spi-nxp-fspi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP Flex Serial Peripheral Interface (FSPI)
+
+maintainers:
+ - Ashish Kumar <ashish.kumar@nxp.com>
+
+allOf:
+ - $ref: "/schemas/spi/spi-controller.yaml#"
+
+properties:
+ compatible:
+ enum:
+ - nxp,lx2160a-fspi
+ - nxp,imx8mm-fspi
+ - nxp,imx8mp-fspi
+ - nxp,imx8qxp-fspi
+ - nxp,imx8dxl-fspi
+
+ reg:
+ items:
+ - description: register location and length
+ - description: memory mapping address and length
+
+ reg-names:
+ items:
+ - const: fspi_base
+ - const: fspi_mmap
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: SPI Bus clock
+ - description: SPI Serial clock
+
+ clock-names:
+ items:
+ - const: fspi_en
+ - const: fspi
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - interrupts
+ - clocks
+ - clock-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/fsl,qoriq-clockgen.h>
+
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ fspi0: spi@20c0000 {
+ compatible = "nxp,lx2160a-fspi";
+ reg = <0x0 0x20c0000 0x0 0x10000>,
+ <0x0 0x20000000 0x0 0x10000000>;
+ reg-names = "fspi_base", "fspi_mmap";
+ interrupts = <0 25 0x4>; /* Level high type */
+ clocks = <&clockgen 4 3>, <&clockgen 4 3>;
+ clock-names = "fspi_en", "fspi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ mt35xu512aba0: flash@0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ };
+
+ mt35xu512aba1: flash@1 {
+ compatible = "jedec,spi-nor";
+ reg = <1>;
+ };
+ };
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [EXT] [PATCH 2/7] dt-bindings: spi: flexspi: convert to json schema
2021-07-15 8:25 ` [PATCH 2/7] dt-bindings: spi: flexspi: convert to json schema Dong Aisheng
@ 2021-07-15 9:25 ` Kuldeep Singh
2021-07-15 10:43 ` Dong Aisheng
0 siblings, 1 reply; 3+ messages in thread
From: Kuldeep Singh @ 2021-07-15 9:25 UTC (permalink / raw)
To: Aisheng Dong, devicetree
Cc: linux-arm-kernel, dl-linux-imx, kernel, Aisheng Dong, dongas86,
robh+dt, shawnguo, Ashish Kumar, Yogesh Gaur, Mark Brown,
linux-spi
Hi Aisheng,
> -----Original Message-----
> From: Dong Aisheng <aisheng.dong@nxp.com>
> Sent: Thursday, July 15, 2021 1:56 PM
> To: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>;
> kernel@pengutronix.de; Aisheng Dong <aisheng.dong@nxp.com>;
> dongas86@gmail.com; robh+dt@kernel.org; shawnguo@kernel.org; Ashish
> Kumar <ashish.kumar@nxp.com>; Yogesh Gaur <yogeshgaur.83@gmail.com>;
> Mark Brown <broonie@kernel.org>; linux-spi@vger.kernel.org
> Subject: [EXT] [PATCH 2/7] dt-bindings: spi: flexspi: convert to json schema
>
> Caution: EXT Email
>
> Besides the conversion work, also added the missing clock property in the
> original binding doc according to the current dts and driver implementation.
> Otherwise, make dtbs_check will fail.
> Also fixed example according to new jason schema.
>
> Cc: Ashish Kumar <ashish.kumar@nxp.com>
> Cc: Yogesh Gaur <yogeshgaur.83@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: linux-spi@vger.kernel.org
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
There's already a similar patch sent upstream for conversion to yaml format. Please see[1].
Regards
Kuldeep
[1] https://patchwork.kernel.org/project/spi-devel-general/patch/20210428102417.1936520-1-kuldeep.singh@nxp.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [EXT] [PATCH 2/7] dt-bindings: spi: flexspi: convert to json schema
2021-07-15 9:25 ` [EXT] " Kuldeep Singh
@ 2021-07-15 10:43 ` Dong Aisheng
0 siblings, 0 replies; 3+ messages in thread
From: Dong Aisheng @ 2021-07-15 10:43 UTC (permalink / raw)
To: Kuldeep Singh
Cc: Aisheng Dong, devicetree, linux-arm-kernel, dl-linux-imx, kernel,
robh+dt, shawnguo, Ashish Kumar, Yogesh Gaur, Mark Brown,
linux-spi
On Thu, Jul 15, 2021 at 5:25 PM Kuldeep Singh <kuldeep.singh@nxp.com> wrote:
>
> Hi Aisheng,
>
> > -----Original Message-----
> > From: Dong Aisheng <aisheng.dong@nxp.com>
> > Sent: Thursday, July 15, 2021 1:56 PM
> > To: devicetree@vger.kernel.org
> > Cc: linux-arm-kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>;
> > kernel@pengutronix.de; Aisheng Dong <aisheng.dong@nxp.com>;
> > dongas86@gmail.com; robh+dt@kernel.org; shawnguo@kernel.org; Ashish
> > Kumar <ashish.kumar@nxp.com>; Yogesh Gaur <yogeshgaur.83@gmail.com>;
> > Mark Brown <broonie@kernel.org>; linux-spi@vger.kernel.org
> > Subject: [EXT] [PATCH 2/7] dt-bindings: spi: flexspi: convert to json schema
> >
> > Caution: EXT Email
> >
> > Besides the conversion work, also added the missing clock property in the
> > original binding doc according to the current dts and driver implementation.
> > Otherwise, make dtbs_check will fail.
> > Also fixed example according to new jason schema.
> >
> > Cc: Ashish Kumar <ashish.kumar@nxp.com>
> > Cc: Yogesh Gaur <yogeshgaur.83@gmail.com>
> > Cc: Mark Brown <broonie@kernel.org>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: linux-spi@vger.kernel.org
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
>
> There's already a similar patch sent upstream for conversion to yaml format. Please see[1].
>
Thanks for letting me know.
Then this one can be dropped. :-)
Regards
Aisheng
> Regards
> Kuldeep
> [1] https://patchwork.kernel.org/project/spi-devel-general/patch/20210428102417.1936520-1-kuldeep.singh@nxp.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-15 10:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210715082536.1882077-1-aisheng.dong@nxp.com>
2021-07-15 8:25 ` [PATCH 2/7] dt-bindings: spi: flexspi: convert to json schema Dong Aisheng
2021-07-15 9:25 ` [EXT] " Kuldeep Singh
2021-07-15 10:43 ` Dong Aisheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).