archive mirror
 help / color / mirror / Atom feed
From: Chuanhong Guo <>
To: Mark Brown <>
	open list <>,
	Rob Herring <>,
	Mark Rutland <>,
Subject: Re: [PATCH resend 1/2] spi: add driver for ar934x spi controller
Date: Thu, 6 Feb 2020 20:33:33 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Feb 6, 2020 at 8:30 PM Chuanhong Guo <> wrote:
> > It looks like this could just be a transfer_one() operation
> > instead of transfer_one_message() (which is what this is in spite
> > of the name)?  There's nothing custom outside this loop that I
> > can see.
> Chipselect is also handled during transfer. Controller asserts
> corresponding chipselect in SHIFT_CTRL register, and if SHIFT_TERM bit
> is set, controller will deassert chipselect after current transfer is
> done. I need to know whether this is the last transfer and set
> SHIFT_TERM accordingly.

Oh, I remembered that I saw transfer_one function name somewhere and
thought maybe I could shorten the function name a bit. I'll correct
this back to ar934x_spi_transfer_one_message in v2.

Chuanhong Guo

  parent reply	other threads:[~2020-02-06 12:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06  8:44 [PATCH resend 0/2] spi: add driver for ar934x spi controller Chuanhong Guo
2020-02-06  8:44 ` [PATCH resend 1/2] " Chuanhong Guo
     [not found]   ` <>
2020-02-06 11:31     ` Mark Brown
     [not found]       ` <>
2020-02-06 12:30         ` Chuanhong Guo
     [not found]           ` <>
2020-02-06 12:33             ` Chuanhong Guo [this message]
     [not found]               ` <>
2020-02-06 13:54                 ` Mark Brown
     [not found] ` <>
2020-02-06  8:44   ` [PATCH resend 2/2] dt-binding: spi: add bindings for spi-ar934x Chuanhong Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).