Linux-SPI Archive on lore.kernel.org
 help / color / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Clark Wang <xiaoning.wang@nxp.com>
Cc: Mark Brown <broonie@kernel.org>,
	Anson Huang <Anson.Huang@nxp.com>,
	linux-spi <linux-spi@vger.kernel.org>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 4/4] dt-bindings: lpspi: New property in document DT bindings for LPSPI
Date: Fri, 31 Jul 2020 11:38:25 -0600
Message-ID: <CAL_Jsq+M0bjH6KnrT4ob6YF7VZxUtgUeAJOE84Omp4PNH2hSZQ@mail.gmail.com> (raw)
In-Reply-To: <20200727031513.31774-1-xiaoning.wang@nxp.com>

On Sun, Jul 26, 2020 at 9:15 PM Clark Wang <xiaoning.wang@nxp.com> wrote:
>
> Add "fsl,spi-only-use-cs1-sel" to fit i.MX8DXL-EVK.
> Spi common code does not support use of CS signals discontinuously.
> It only uses CS1 without using CS0. So, add this property to re-config
> chipselect value.
>
> Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
> ---
> Changes:
> V2:
>  - New patch added in the v2 patchset.
> ---
>  Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
> index 143b94a1883a..22882e769e26 100644
> --- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
> @@ -34,6 +34,12 @@ properties:
>        - const: per
>        - const: ipg
>
> +  fsl,spi-only-use-cs1-sel:
> +    description:
> +      spi common code does not support use of CS signals discontinuously.
> +      i.MX8DXL-EVK board only uses CS1 without using CS0. Therefore, add
> +      this property to re-config the chipselect value in the LPSPI driver.

This breaks linux-next and you didn't test with 'make dt_binding_check':

/builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml:
properties:fsl,spi-only-use-cs1-sel: {'description': 'spi common code
does not support use of CS signals discontinuously. i.MX8DXL-EVK board
only uses CS1 without using CS0. Therefore, add this property to
re-config the chipselect value in the LPSPI driver.'} is not valid
under any of the given schemas (Possible causes of the failure):
 /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml:
properties:fsl,spi-only-use-cs1-sel: 'not' is a required property

The problem is you need a type definition for a vendor specific
property. In this case 'type: boolean'.

Rob

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27  3:15 Clark Wang
2020-07-31 17:38 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_Jsq+M0bjH6KnrT4ob6YF7VZxUtgUeAJOE84Omp4PNH2hSZQ@mail.gmail.com \
    --to=robh+dt@kernel.org \
    --cc=Anson.Huang@nxp.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-SPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spi/0 linux-spi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spi linux-spi/ https://lore.kernel.org/linux-spi \
		linux-spi@vger.kernel.org
	public-inbox-index linux-spi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git