* [PATCH] spi: SPI_FSL_DSPI should depend on HAS_DMA
@ 2016-12-14 12:28 Geert Uytterhoeven
2016-12-14 14:37 ` Mark Brown
[not found] ` <1481718485-6966-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
0 siblings, 2 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2016-12-14 12:28 UTC (permalink / raw)
To: Mark Brown, Sanchayan Maity; +Cc: linux-spi, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
ERROR: "bad_dma_ops" [drivers/spi/spi-fsl-dspi.ko] undefined!
Add a dependency on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/spi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index cb6c7def29b26f15..f5c7915a23bc2417 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -378,6 +378,7 @@ config SPI_FSL_SPI
config SPI_FSL_DSPI
tristate "Freescale DSPI controller"
select REGMAP_MMIO
+ depends on HAS_DMA
depends on SOC_VF610 || SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
help
This enables support for the Freescale DSPI controller in master
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] spi: SPI_FSL_DSPI should depend on HAS_DMA
2016-12-14 12:28 [PATCH] spi: SPI_FSL_DSPI should depend on HAS_DMA Geert Uytterhoeven
@ 2016-12-14 14:37 ` Mark Brown
[not found] ` <20161214143713.3kl34okpr5vnuyc6-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
[not found] ` <1481718485-6966-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
1 sibling, 1 reply; 5+ messages in thread
From: Mark Brown @ 2016-12-14 14:37 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Sanchayan Maity, linux-spi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
On Wed, Dec 14, 2016 at 01:28:05PM +0100, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> ERROR: "bad_dma_ops" [drivers/spi/spi-fsl-dspi.ko] undefined!
> Add a dependency on HAS_DMA to fix this.
Honestly I think we should just fix the architectures that don't support
DMA to provide compile out stubs for DMA, it seems like these
dependencies are more trouble than they're worth.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <1481718485-6966-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>]
* Applied "spi: SPI_FSL_DSPI should depend on HAS_DMA" to the spi tree
[not found] ` <1481718485-6966-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
@ 2016-12-14 18:03 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2016-12-14 18:03 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Mark Brown, Mark Brown, Sanchayan Maity,
linux-spi-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
The patch
spi: SPI_FSL_DSPI should depend on HAS_DMA
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From dadab2d4e3cf708ceba22ecddd94aedfecb39199 Mon Sep 17 00:00:00 2001
From: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Date: Wed, 14 Dec 2016 13:28:05 +0100
Subject: [PATCH] spi: SPI_FSL_DSPI should depend on HAS_DMA
If NO_DMA=y:
ERROR: "bad_dma_ops" [drivers/spi/spi-fsl-dspi.ko] undefined!
Add a dependency on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
drivers/spi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index ec4aa252d6e8..2922a9908302 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -378,6 +378,7 @@ config SPI_FSL_SPI
config SPI_FSL_DSPI
tristate "Freescale DSPI controller"
select REGMAP_MMIO
+ depends on HAS_DMA
depends on SOC_VF610 || SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
help
This enables support for the Freescale DSPI controller in master
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-14 18:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-14 12:28 [PATCH] spi: SPI_FSL_DSPI should depend on HAS_DMA Geert Uytterhoeven
2016-12-14 14:37 ` Mark Brown
[not found] ` <20161214143713.3kl34okpr5vnuyc6-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-12-14 14:40 ` Geert Uytterhoeven
2016-12-14 15:13 ` Mark Brown
[not found] ` <1481718485-6966-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2016-12-14 18:03 ` Applied "spi: SPI_FSL_DSPI should depend on HAS_DMA" to the spi tree Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).