linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] spi: atmel: fix indenting in atmel_spi_gpio_cs()
@ 2016-11-14 14:26 Dan Carpenter
  2016-11-14 14:49 ` Nicolas Ferre
  2016-11-15 18:53 ` Applied "spi: atmel: fix indenting in atmel_spi_gpio_cs()" to the spi tree Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-11-14 14:26 UTC (permalink / raw)
  To: Nicolas Ferre; +Cc: Mark Brown, linux-spi, kernel-janitors

These lines were indented one extra tab.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index d3affa6..b293149 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -1510,15 +1510,15 @@ static int atmel_spi_gpio_cs(struct platform_device *pdev)
 		int cs_gpio = of_get_named_gpio(pdev->dev.of_node,
 						"cs-gpios", i);
 
-			if (cs_gpio == -EPROBE_DEFER)
-				return cs_gpio;
-
-			if (gpio_is_valid(cs_gpio)) {
-				ret = devm_gpio_request(&pdev->dev, cs_gpio,
-							dev_name(&pdev->dev));
-				if (ret)
-					return ret;
-			}
+		if (cs_gpio == -EPROBE_DEFER)
+			return cs_gpio;
+
+		if (gpio_is_valid(cs_gpio)) {
+			ret = devm_gpio_request(&pdev->dev, cs_gpio,
+						dev_name(&pdev->dev));
+			if (ret)
+				return ret;
+		}
 	}
 
 	return 0;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [patch] spi: atmel: fix indenting in atmel_spi_gpio_cs()
  2016-11-14 14:26 [patch] spi: atmel: fix indenting in atmel_spi_gpio_cs() Dan Carpenter
@ 2016-11-14 14:49 ` Nicolas Ferre
  2016-11-15 18:53 ` Applied "spi: atmel: fix indenting in atmel_spi_gpio_cs()" to the spi tree Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2016-11-14 14:49 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Mark Brown, linux-spi, kernel-janitors

Le 14/11/2016 à 15:26, Dan Carpenter a écrit :
> These lines were indented one extra tab.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Oh yes: sorry for that:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks, Dan. Best regards,

> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index d3affa6..b293149 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1510,15 +1510,15 @@ static int atmel_spi_gpio_cs(struct platform_device *pdev)
>  		int cs_gpio = of_get_named_gpio(pdev->dev.of_node,
>  						"cs-gpios", i);
>  
> -			if (cs_gpio == -EPROBE_DEFER)
> -				return cs_gpio;
> -
> -			if (gpio_is_valid(cs_gpio)) {
> -				ret = devm_gpio_request(&pdev->dev, cs_gpio,
> -							dev_name(&pdev->dev));
> -				if (ret)
> -					return ret;
> -			}
> +		if (cs_gpio == -EPROBE_DEFER)
> +			return cs_gpio;
> +
> +		if (gpio_is_valid(cs_gpio)) {
> +			ret = devm_gpio_request(&pdev->dev, cs_gpio,
> +						dev_name(&pdev->dev));
> +			if (ret)
> +				return ret;
> +		}
>  	}
>  
>  	return 0;
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Applied "spi: atmel: fix indenting in atmel_spi_gpio_cs()" to the spi tree
  2016-11-14 14:26 [patch] spi: atmel: fix indenting in atmel_spi_gpio_cs() Dan Carpenter
  2016-11-14 14:49 ` Nicolas Ferre
@ 2016-11-15 18:53 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2016-11-15 18:53 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Nicolas Ferre, Mark Brown, Nicolas Ferre, Mark Brown, linux-spi,
	kernel-janitors

The patch

   spi: atmel: fix indenting in atmel_spi_gpio_cs()

has been applied to the spi tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From b52b3484eec593a4fe75a68e57f0ade52b55ed8f Mon Sep 17 00:00:00 2001
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 14 Nov 2016 17:26:44 +0300
Subject: [PATCH] spi: atmel: fix indenting in atmel_spi_gpio_cs()

These lines were indented one extra tab.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-atmel.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index d3affa6afe7e..b2931493cab2 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -1510,15 +1510,15 @@ static int atmel_spi_gpio_cs(struct platform_device *pdev)
 		int cs_gpio = of_get_named_gpio(pdev->dev.of_node,
 						"cs-gpios", i);
 
-			if (cs_gpio == -EPROBE_DEFER)
-				return cs_gpio;
-
-			if (gpio_is_valid(cs_gpio)) {
-				ret = devm_gpio_request(&pdev->dev, cs_gpio,
-							dev_name(&pdev->dev));
-				if (ret)
-					return ret;
-			}
+		if (cs_gpio == -EPROBE_DEFER)
+			return cs_gpio;
+
+		if (gpio_is_valid(cs_gpio)) {
+			ret = devm_gpio_request(&pdev->dev, cs_gpio,
+						dev_name(&pdev->dev));
+			if (ret)
+				return ret;
+		}
 	}
 
 	return 0;
-- 
2.10.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-15 18:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-14 14:26 [patch] spi: atmel: fix indenting in atmel_spi_gpio_cs() Dan Carpenter
2016-11-14 14:49 ` Nicolas Ferre
2016-11-15 18:53 ` Applied "spi: atmel: fix indenting in atmel_spi_gpio_cs()" to the spi tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).