* [PATCH qcom v2] spi: dt-bindings: qcom,spi-geni-qcom: allow three interconnects
@ 2022-05-05 6:52 Krzysztof Kozlowski
2022-05-05 14:19 ` Rob Herring
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-05 6:52 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Mark Brown, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, linux-spi, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Recent Qualcomm Geni SPI nodes, e.g. on SM8450, come also with three
interconnects. This fixes dtbs_check warnings like:
sm8450-qrd.dtb: spi@a98000: interconnects: [[46, 1, 0, 46, 4, 0], [47, 2, 0, 48, 12, 0], [49, 1, 0, 50, 1, 0]] is too long
sm8450-qrd.dtb: spi@a98000: interconnect-names: ['qup-core', 'qup-config', 'qup-memory'] is too long
Fixes: 5bdcae1fe1c5 ("spi: dt-bindings: qcom,spi-geni-qcom: convert to dtschema")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Fix for a commit in MSM/Bjorn's tree.
Changes since v1:
1. Correct error msg (Rob).
---
.../devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
index e2c7b934c50d..47e1b3ee8b1b 100644
--- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
+++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
@@ -45,12 +45,15 @@ properties:
- const: rx
interconnects:
- maxItems: 2
+ minItems: 2
+ maxItems: 3
interconnect-names:
+ minItems: 2
items:
- const: qup-core
- const: qup-config
+ - const: qup-memory
interrupts:
maxItems: 1
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH qcom v2] spi: dt-bindings: qcom,spi-geni-qcom: allow three interconnects
2022-05-05 6:52 [PATCH qcom v2] spi: dt-bindings: qcom,spi-geni-qcom: allow three interconnects Krzysztof Kozlowski
@ 2022-05-05 14:19 ` Rob Herring
2022-05-05 17:13 ` [PATCH " Mark Brown
2022-06-20 19:41 ` [PATCH qcom " Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-05-05 14:19 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Mark Brown, linux-kernel, Krzysztof Kozlowski, devicetree,
Rob Herring, Andy Gross, Bjorn Andersson, linux-arm-msm,
linux-spi
On Thu, 05 May 2022 08:52:33 +0200, Krzysztof Kozlowski wrote:
> Recent Qualcomm Geni SPI nodes, e.g. on SM8450, come also with three
> interconnects. This fixes dtbs_check warnings like:
>
> sm8450-qrd.dtb: spi@a98000: interconnects: [[46, 1, 0, 46, 4, 0], [47, 2, 0, 48, 12, 0], [49, 1, 0, 50, 1, 0]] is too long
> sm8450-qrd.dtb: spi@a98000: interconnect-names: ['qup-core', 'qup-config', 'qup-memory'] is too long
>
> Fixes: 5bdcae1fe1c5 ("spi: dt-bindings: qcom,spi-geni-qcom: convert to dtschema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Fix for a commit in MSM/Bjorn's tree.
>
> Changes since v1:
> 1. Correct error msg (Rob).
> ---
> .../devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] spi: dt-bindings: qcom,spi-geni-qcom: allow three interconnects
2022-05-05 6:52 [PATCH qcom v2] spi: dt-bindings: qcom,spi-geni-qcom: allow three interconnects Krzysztof Kozlowski
2022-05-05 14:19 ` Rob Herring
@ 2022-05-05 17:13 ` Mark Brown
2022-06-20 19:41 ` [PATCH qcom " Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-05-05 17:13 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, linux-spi, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
On Thu, May 05, 2022 at 08:52:33AM +0200, Krzysztof Kozlowski wrote:
> Recent Qualcomm Geni SPI nodes, e.g. on SM8450, come also with three
> interconnects. This fixes dtbs_check warnings like:
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH qcom v2] spi: dt-bindings: qcom,spi-geni-qcom: allow three interconnects
2022-05-05 6:52 [PATCH qcom v2] spi: dt-bindings: qcom,spi-geni-qcom: allow three interconnects Krzysztof Kozlowski
2022-05-05 14:19 ` Rob Herring
2022-05-05 17:13 ` [PATCH " Mark Brown
@ 2022-06-20 19:41 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-20 19:41 UTC (permalink / raw)
To: linux-kernel, bjorn.andersson, agross, linux-arm-msm, devicetree,
linux-spi, robh+dt, krzysztof.kozlowski+dt, broonie,
krzysztof.kozlowski
On Thu, 5 May 2022 08:52:33 +0200, Krzysztof Kozlowski wrote:
> Recent Qualcomm Geni SPI nodes, e.g. on SM8450, come also with three
> interconnects. This fixes dtbs_check warnings like:
>
> sm8450-qrd.dtb: spi@a98000: interconnects: [[46, 1, 0, 46, 4, 0], [47, 2, 0, 48, 12, 0], [49, 1, 0, 50, 1, 0]] is too long
> sm8450-qrd.dtb: spi@a98000: interconnect-names: ['qup-core', 'qup-config', 'qup-memory'] is too long
>
>
> [...]
Applied, thanks!
[1/1] spi: dt-bindings: qcom,spi-geni-qcom: allow three interconnects
https://git.kernel.org/krzk/linux-dt/c/56cf5b7fde546f0203a91e002e1cfb3f51804db4
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-20 19:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-05 6:52 [PATCH qcom v2] spi: dt-bindings: qcom,spi-geni-qcom: allow three interconnects Krzysztof Kozlowski
2022-05-05 14:19 ` Rob Herring
2022-05-05 17:13 ` [PATCH " Mark Brown
2022-06-20 19:41 ` [PATCH qcom " Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).